Bugzilla – Attachment 39230 Details for
Bug 14120
Silence warnings t/db_dependent/Auth.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 14120: Fixing t/db_dependent/Auth.t noise
SIGNED-OFF-Bug-14120-Fixing-tdbdependentAutht-nois.patch (text/plain), 1.77 KB, created by
Bernardo Gonzalez Kriegel
on 2015-05-15 22:32:22 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 14120: Fixing t/db_dependent/Auth.t noise
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2015-05-15 22:32:22 UTC
Size:
1.77 KB
patch
obsolete
>From 343ab0b28303f87b84cdcc110622083dae29ed98 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Sat, 2 May 2015 00:02:04 -0400 >Subject: [PATCH] [SIGNED-OFF] Bug 14120: Fixing t/db_dependent/Auth.t noise > >TEST PLAN >--------- >1) $ prove t/db_dependent/Auth.t > -- warnings >2) Apply this patch >3) $ prove t/db_dependent/Auth.t > -- only one specific type of warning >4) Apply bug 5010 patch >5) $ prove t/db_dependent/Auth.t > -- noisy is eliminated >6) koha qa test tools. > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >With patch only one warn >With 5010 no more warns >No errors >--- > C4/Auth.pm | 2 +- > C4/Templates.pm | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index 9a5d6b4..1329e7b 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -252,7 +252,7 @@ sub get_template_and_user { > > if ($flags) { > foreach my $module ( keys %$all_perms ) { >- if ( $flags->{$module} == 1 ) { >+ if ( defined($flags->{$module}) && $flags->{$module} == 1 ) { > foreach my $subperm ( keys %{ $all_perms->{$module} } ) { > $template->param( "CAN_user_${module}_${subperm}" => 1 ); > } >diff --git a/C4/Templates.pm b/C4/Templates.pm >index 62a2b55..b7f770d 100644 >--- a/C4/Templates.pm >+++ b/C4/Templates.pm >@@ -161,6 +161,7 @@ sub _get_template_file { > my $is_intranet = $interface eq 'intranet'; > my $htdocs = C4::Context->config($is_intranet ? 'intrahtdocs' : 'opachtdocs'); > my ($theme, $lang, $availablethemes) = themelanguage($htdocs, $tmplbase, $interface, $query); >+ $lang //= 'en'; > my $filename = "$htdocs/$theme/$lang/modules/$tmplbase"; > > return ($htdocs, $theme, $lang, $filename); >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14120
:
38762
|
39230
|
39691