Bugzilla – Attachment 39234 Details for
Bug 14111
Silence warnings t/Auth_with_shibboleth.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14111: Silence warnings in t/Auth_with_shibboleth.t
Bug-14111-Silence-warnings-in-tAuthwithshibboletht.patch (text/plain), 1.87 KB, created by
Indranil Das Gupta
on 2015-05-16 09:26:57 UTC
(
hide
)
Description:
Bug 14111: Silence warnings in t/Auth_with_shibboleth.t
Filename:
MIME Type:
Creator:
Indranil Das Gupta
Created:
2015-05-16 09:26:57 UTC
Size:
1.87 KB
patch
obsolete
>From 1b83f00dd87355156f7fc40002b7eab5b3ad79bc Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Fri, 1 May 2015 15:14:49 -0400 >Subject: [PATCH] Bug 14111: Silence warnings in t/Auth_with_shibboleth.t > >Poorly capturing warnings_exist test cases generated noise. >This patch fixes that. > >TEST PLAN >--------- >1) $ prove t/Auth_with_shibboleth.t > -- There are messages about lines 132 and 133. Noise. >2) Apply patch >3) $ prove t/Auth_with_shibboleth.t > -- No messages. YAY! >4) koha qa test tools > >Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> > >Test remarks: Expected outcome as per test plan. No anomaly noted. >--- > t/Auth_with_shibboleth.t | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/t/Auth_with_shibboleth.t b/t/Auth_with_shibboleth.t >index 6b4a727..457153a 100644 >--- a/t/Auth_with_shibboleth.t >+++ b/t/Auth_with_shibboleth.t >@@ -17,6 +17,7 @@ > > use Modern::Perl; > >+$| = 1; > use Module::Load::Conditional qw/check_install/; > use Test::More; > use Test::MockModule; >@@ -216,7 +217,9 @@ subtest "checkpw_shib tests" => sub { > warnings_exist { > ( $retval, $retcard, $retuserid ) = checkpw_shib( $shib_login ); > } >- [ qr/checkpw_shib/, qr/User Shibboleth-authenticated as:/ ], >+ [ qr/checkpw_shib/, qr/koha borrower field to match: userid/, >+ qr/shibboleth attribute to match: uid/, >+ qr/User Shibboleth-authenticated as:/ ], > "good user with debug enabled"; > is( $retval, "1", "user authenticated" ); > is( $retcard, "testcardnumber", "expected cardnumber returned" ); >@@ -229,6 +232,8 @@ subtest "checkpw_shib tests" => sub { > } > [ > qr/checkpw_shib/, >+ qr/koha borrower field to match: userid/, >+ qr/shibboleth attribute to match: uid/, > qr/User Shibboleth-authenticated as:/, > qr/not a valid Koha user/ > ], >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14111
:
38752
|
38832
|
39227
|
39231
|
39232
|
39234
|
39235
|
39696
|
39697