Attachment 39235 Details for Bug 14111 – Bug 14111 - More t/Auth_with_shibboleth.t silencing

[patch] Bug 14111 - More t/Auth_with_shibboleth.t silencing

Bug-14111---More-tAuthwithshibboletht-silencing.patch (text/plain), 2.10 KB, created by Indranil Das Gupta on 2015-05-16 09:27:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Indranil Das Gupta

Created: 2015-05-16 09:27:08 UTC

Size: 2.10 KB

patch

obsolete

>From 1a13ab401248e84c651deb9424334ad8f32222b3 Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Mon, 4 May 2015 20:37:58 -0400
>Subject: [PATCH] Bug 14111 - More t/Auth_with_shibboleth.t silencing
>
>TEST PLAN
>---------
>1) Apply first patch
>2) prove t/Auth_with_shibboleth.t
>   -- failed?!
>3) apply this patch
>4) prove t/Auth_with_shibboleth.t
>   -- success. *whew*
>5) koha-qa test tools.
>
>Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
>
>Test remarks: Expected outcome as per test plan. No anomaly noted.
>---
> t/Auth_with_shibboleth.t | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
>diff --git a/t/Auth_with_shibboleth.t b/t/Auth_with_shibboleth.t
>index 457153a..a20dff5 100644
>--- a/t/Auth_with_shibboleth.t
>+++ b/t/Auth_with_shibboleth.t
>@@ -28,7 +28,7 @@ use C4::Context;
> 
> BEGIN {
>     if ( check_install( module => 'Test::DBIx::Class' ) ) {
>-        plan tests => 9;
>+        plan tests => 11;
>     } else {
>         plan skip_all => "Need Test::DBIx::Class"
>     }
>@@ -249,10 +249,8 @@ is( C4::Auth_with_shibboleth::_get_uri(),
> 
> $OPACBaseURL = "http://testopac.com";
> my $result;
>-warnings_are { $result = C4::Auth_with_shibboleth::_get_uri() }
>-             [ { carped =>
>-                 'Shibboleth requires OPACBaseURL to use the https protocol!' },
>-             ],
>+warning_like { $result = C4::Auth_with_shibboleth::_get_uri() }
>+             [ qr/Shibboleth requires OPACBaseURL to use the https protocol!/ ],
>              "improper protocol - received expected warning";
> is( $result, "https://testopac.com", "https opac uri returned" );
> 
>@@ -261,9 +259,8 @@ is( C4::Auth_with_shibboleth::_get_uri(),
>     "https://testopac.com", "https opac uri returned" );
> 
> $OPACBaseURL = undef;
>-warnings_are { $result = C4::Auth_with_shibboleth::_get_uri() }
>-             [ { carped => 'OPACBaseURL not set!' },
>-             ],
>+warning_like { $result = C4::Auth_with_shibboleth::_get_uri() }
>+             [ qr/OPACBaseURL not set!/ ],
>              "undefined OPACBaseURL - received expected warning";
> is( $result, "https://", "https opac uri returned" );
> 
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14111: 38752 | 38832 | 39227 | 39231 | 39232 | 39234 | 39235 | 39696 | 39697