Bugzilla – Attachment 39259 Details for
Bug 10355
Second click on modification log misses object parameter
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 10355: paramater 'object' lost on the road
SIGNED-OFF-Bug-10355-paramater-object-lost-on-the-.patch (text/plain), 2.62 KB, created by
Bernardo Gonzalez Kriegel
on 2015-05-17 21:41:45 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 10355: paramater 'object' lost on the road
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2015-05-17 21:41:45 UTC
Size:
2.62 KB
patch
obsolete
>From 8964bd708dabe9fe005fc2dff853fbe3a1a8143a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Thu, 16 Apr 2015 16:39:09 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 10355: paramater 'object' lost on the road > >Test plan: >1) Go to any detail page in staff >2) Click on the modification log tab >3) Verify, that the object is prefilled with the records biblionumber >and you can also see it as parameter in the url >4) Click a second time on modification log to reset your search > >Before this patch, the object parameter was empty. >It now contains the value of the biblionumber. > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Work as described, no koha-qa errors > >http://bugs.koha-community.org/show_bug.cgi?id=10335 >--- > .../prog/en/includes/biblio-view-menu.inc | 2 +- > tools/viewlog.pl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc >index b2edbe6..8d9ceec 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc >@@ -30,7 +30,7 @@ > <ul> > [% IF ( issuehistoryview ) %]<li class="active">[% ELSE %]<li>[% END %] > <a href="/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=[% IF ( object ) %][% object %][% ELSE %][% IF ( object ) %][% object %][% ELSE %][% biblionumber %][% END %][% END %]" >Checkout history</a></li> >-[% IF ( CAN_user_tools_view_system_logs ) %][% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=CATALOGUING&action=MODIFY&object=[% biblionumber %]">Modification log</a> </li>[% END %] >+[% IF ( CAN_user_tools_view_system_logs ) %][% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=CATALOGUING&action=MODIFY&object=[% biblionumber or object %]">Modification log</a> </li>[% END %] > </ul> > </div> > >diff --git a/tools/viewlog.pl b/tools/viewlog.pl >index a382fc8..a13ec5f 100755 >--- a/tools/viewlog.pl >+++ b/tools/viewlog.pl >@@ -101,6 +101,7 @@ if ( $src eq 'circ' ) { > $template->param( > debug => $debug, > C4::Search::enabled_staff_search_views, >+ object => $object, > ); > > if ($do_it) { >@@ -167,7 +168,6 @@ if ($do_it) { > datefrom => $datefrom, > dateto => $dateto, > user => $user, >- object => $object, > info => $info, > src => $src, > modules => \@modules, >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10355
:
37964
|
39259
|
39717