Attachment 39288 Details for Bug 14047 – Bug 14047: [QA Follow-up] Move result_class back into attributes

[patch] Bug 14047: [QA Follow-up] Move result_class back into attributes

Bug-14047-QA-Follow-up-Move-resultclass-back-into-.patch (text/plain), 1.94 KB, created by Marcel de Rooy on 2015-05-18 17:15:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2015-05-18 17:15:42 UTC

Size: 1.94 KB

patch

obsolete

>From 9e4b4d3a047f353085e0473cc94d48a5bb9b3df1 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 18 May 2015 18:51:50 +0200
>Subject: [PATCH] Bug 14047: [QA Follow-up] Move result_class back into
> attributes
>Content-Type: text/plain; charset=utf-8
>
>No need to put this into a separate call.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Note that we strictly speaking do not need the hashref inflator here,
>because TT understands hash.column as well as object.property.
>---
> acqui/z3950_search.pl       |    5 +++--
> cataloguing/z3950_search.pl |    5 +++--
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
>diff --git a/acqui/z3950_search.pl b/acqui/z3950_search.pl
>index f0cdb81..b11c508 100755
>--- a/acqui/z3950_search.pl
>+++ b/acqui/z3950_search.pl
>@@ -98,9 +98,10 @@ if ( $op ne "do_search" ) {
>             recordtype => 'biblio',
>             servertype => ['zed', 'sru'],
>         },
>-        { order_by   => ['rank', 'servername'],},
>+        {   result_class => 'DBIx::Class::ResultClass::HashRefInflator',
>+            order_by     => ['rank', 'servername'],
>+        },
>     );
>-    $rs->result_class('DBIx::Class::ResultClass::HashRefInflator');
>     $template->param(
>         serverloop   => [ $rs->all ],
>         opsearch     => "search",
>diff --git a/cataloguing/z3950_search.pl b/cataloguing/z3950_search.pl
>index 6a9b750..ebf5cda 100755
>--- a/cataloguing/z3950_search.pl
>+++ b/cataloguing/z3950_search.pl
>@@ -78,9 +78,10 @@ if ( $op ne "do_search" ) {
>             recordtype => 'biblio',
>             servertype => ['zed', 'sru'],
>         },
>-        { order_by   => ['rank', 'servername'],},
>+        {   result_class => 'DBIx::Class::ResultClass::HashRefInflator',
>+            order_by     => ['rank', 'servername'],
>+        },
>     );
>-    $rs->result_class('DBIx::Class::ResultClass::HashRefInflator');
>     $template->param(
>         serverloop   => [ $rs->all ],
>         opsearch     => "search",
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 14047: 38345 | 39214 | 39286 | 39287 | 39288 | 39412