Attachment 39316 Details for Bug 14206 – Bug 14206 Adds delete function for non email templates

[patch] Bug 14206 Adds delete function for non email templates

Bug-14206-Adds-delete-function-for-non-email-templ.patch (text/plain), 2.24 KB, created by Indranil Das Gupta on 2015-05-19 19:57:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Indranil Das Gupta

Created: 2015-05-19 19:57:09 UTC

Size: 2.24 KB

patch

obsolete

>From 48e9b6d73d18b2a81a4a2110d48a3f85c4e29d23 Mon Sep 17 00:00:00 2001
>From: Indranil Das Gupta <indradg@gmail.com>
>Date: Wed, 20 May 2015 01:25:35 +0530
>Subject: [PATCH] Bug 14206 Adds delete function for non email templates
>
>This patch adds deletion capability for notices that do not use email
>template, but uses any/all of the other templates i.e. sms, print or
>phone.
>
>Test plan (Continued)
>=====================
>
>3/ Go to Tools -> Notices & Slips. Add a new notice only for print,
>   leave 'Library' and 'Koha module' options as default selections.
>   Enter 'KOHA_14206' and 'Koha Test 14206' against Code and Name
>   respectively, and 'Test' and 'Test Message' for subject and body.
>   Leave the Email, Phone and SMS tabs blank. Save the notice.
>4/ On the notices listing page the new notice will be listed. Try to
>   delete it. It will load the 'Delete notice' dialog form, but the
>   table will not show any data under <th>s - 'Library', 'Module',
>   'Code' or 'Name'.
>5/ Click the "Yes, delete" button. The page will be submitted and the
>   Notices listing reloaded. The print-only KOHA_14206 notice should
>   continue to exist. This is *wrong*.
>6/ Apply this patch
>7/ Reload the listings page and click on the 'Delete' link for Notice
>   KOHA_14206. This time, it should show the data under 'Module',
>   'Code' or 'Name' at least.
>8/ Click on 'Yes, delete'. The page should submit and the listing page
>   reload. This time KOHA_14206 will be gone.
>9/ Re-run prove -v t/db_dependent/Letters.t
>   This time all tests should PASS without any error.
>---
> C4/Letters.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Letters.pm b/C4/Letters.pm
>index 55dd68e..5faedd7 100644
>--- a/C4/Letters.pm
>+++ b/C4/Letters.pm
>@@ -225,9 +225,9 @@ sub getletter {
>     my $dbh = C4::Context->dbh;
>     my $sth = $dbh->prepare(q{
>         SELECT *
>-        FROM letter
>+        FROM letter 
>         WHERE module=? AND code=? AND (branchcode = ? OR branchcode = '')
>-        AND (message_transport_type = ? OR message_transport_type IN (SELECT message_transport_type FROM message_transport_types))
>+        AND message_transport_type = ?
>         ORDER BY branchcode DESC LIMIT 1
>     });
>     $sth->execute( $module, $code, $branchcode, $message_transport_type );
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14206: 39270 | 39272 | 39283 | 39315 | 39316 | 39321 | 39342 | 39353 | 39354 | 39376 | 39380 | 39467 | 39512 | 39522 | 39523