Bugzilla – Attachment 39371 Details for
Bug 13437
Convert marc21 framework plugins to new style
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 13437: Perltidy some plugin files before conversion
SIGNED-OFF-Bug-13437-Perltidy-some-plugin-files-be.patch (text/plain), 46.88 KB, created by
Bernardo Gonzalez Kriegel
on 2015-05-21 18:55:12 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 13437: Perltidy some plugin files before conversion
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2015-05-21 18:55:12 UTC
Size:
46.88 KB
patch
obsolete
>From 79ca3b4ef18dcb396994ffd57f59996d732027d4 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 12 May 2015 17:31:29 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 13437: Perltidy some plugin files before > conversion > >Preliminary work before converting to new plugin style. Several files still >contained tabs or had strange indentation. > >Perltidied: marc21_linking_section.pl >Perltidied: marc21_field_007.pl >Perltidied: marc21_leader_authorities.pl >Perltidied: marc21_leader.pl >Perltidied: marc21_leader_book.pl >Perltidied: marc21_leader_computerfile.pl >Perltidied: marc21_leader_video.pl > >Test plan: >Run perltidy -pro=xt/perltidyrc on marc21_linking_section and compare. >Try another one too :) > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Minor differences on comparison :) >No errors >--- > cataloguing/value_builder/marc21_field_007.pl | 202 ++++---- > cataloguing/value_builder/marc21_leader.pl | 78 +-- > .../value_builder/marc21_leader_authorities.pl | 74 +-- > cataloguing/value_builder/marc21_leader_book.pl | 78 +-- > .../value_builder/marc21_leader_computerfile.pl | 78 +-- > cataloguing/value_builder/marc21_leader_video.pl | 78 +-- > .../value_builder/marc21_linking_section.pl | 519 ++++++++++---------- > 7 files changed, 553 insertions(+), 554 deletions(-) > >diff --git a/cataloguing/value_builder/marc21_field_007.pl b/cataloguing/value_builder/marc21_field_007.pl >index b5ba751..d65c33e 100755 >--- a/cataloguing/value_builder/marc21_field_007.pl >+++ b/cataloguing/value_builder/marc21_field_007.pl >@@ -1,6 +1,5 @@ > #!/usr/bin/perl > >- > # Copyright 2000-2002 Katipo Communications > # > # This file is part of Koha. >@@ -19,6 +18,7 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use strict; >+ > #use warnings; FIXME - Bug 2505 > use C4::Auth; > use CGI qw ( -utf8 ); >@@ -34,9 +34,9 @@ plugin_parameters : other parameters added when the plugin is called by the dopo > =cut > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >-my $function_name= $field_number; >-my $res=" >+ my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_; >+ my $function_name = $field_number; >+ my $res = " > <script type=\"text/javascript\"> > //<![CDATA[ > >@@ -49,101 +49,105 @@ function Clic$function_name(i) { > </script> > "; > >-return ($function_name,$res); >+ return ( $function_name, $res ); > } >+ > sub plugin { >-my ($input) = @_; >- my $index= $input->param('index'); >- my $result= $input->param('result'); >- >- >- my $dbh = C4::Context->dbh; >- >-my ($template, $loggedinuser, $cookie) >- = get_template_and_user({template_name => "cataloguing/value_builder/marc21_field_007.tt", >- query => $input, >- type => "intranet", >- authnotrequired => 0, >- flagsrequired => {editcatalogue => '*'}, >- debug => 1, >- }); >- $result = "ta" unless $result; >- my $f0 = substr($result,0,1); >- my $f1 = substr($result,1,1); >-#added new parameters to allow for all material types >- my $f2 = substr($result,2,1); >- my $f3 = substr($result,3,1); >- my $f4 = substr($result,4,1); >- my $f5 = substr($result,5,1); >- my $f6 = substr($result,6,1); >- my $f7 = substr($result,7,1); >- my $f8 = substr($result,8,1); >- my $f9 = substr($result,9,1); >- my $f10 = substr($result,10,1); >- my $f11 = substr($result,11,1); >- my $f12 = substr($result,12,1); >- my $f13 = substr($result,13,1); >- my $f14 = substr($result,14,1); >- my $f15 = substr($result,15,1); >- my $f16 = substr($result,16,1); >- my $f17 = substr($result,17,1); >- my $f18 = substr($result,18,1); >- my $f19 = substr($result,19,1); >- my $f20 = substr($result,20,1); >- my $f21 = substr($result,21,1); >- my $f22 = substr($result,22,1); >-#FIXME: There is probably a more-elegant way to do this! >-#FIXME: Two of the material types treat position 06, 07, and 08 as a single >-#three-char field. This script works fine for creating values and sending them >-#back to the MARC, but if there is already a value in the 007, it won't send >-#it properly to the value builder for those two instances. Not sure how to solve. >- $template->param( index => $index, >- f0 => $f0, >- "f0$f0" => $f0, >- f1 => $f1, >- "f1$f1" => $f1, >- f2 => $f2, >- "f2$f2" => $f2, >- f3 => $f3, >- "f3$f3" => $f3, >- f4 => $f4, >- "f4$f4" => $f4, >- f5 => $f5, >- "f5$f5" => $f5, >- f6 => $f6, >- "f6$f6" => $f6, >- f7 => $f7, >- "f7$f7" => $f7, >- f8 => $f8, >- "f8$f8" => $f8, >- f9 => $f9, >- "f9$f9" => $f9, >- f10 => $f10, >- "f10$f10" => $f10, >- f11 => $f11, >- "f11$f11" => $f11, >- f12 => $f12, >- "f12$f12" => $f12, >- f13 => $f13, >- "f13$f13" => $f13, >- f14 => $f14, >- "f14$f14" => $f14, >- f15 => $f15, >- "f15$f15" => $f15, >- f16 => $f16, >- "f16$f16" => $f16, >- f17 => $f17, >- "f17$f17" => $f17, >- f18 => $f18, >- "f18$f18" => $f18, >- f19 => $f19, >- "f19$f19" => $f19, >- f20 => $f20, >- "f20$f20" => $f20, >- f21 => $f21, >- "f21$f21" => $f21, >- f22 => $f22, >- "f22$f22" => $f22, >- ); >- output_html_with_http_headers $input, $cookie, $template->output; >+ my ($input) = @_; >+ my $index = $input->param('index'); >+ my $result = $input->param('result'); >+ >+ my $dbh = C4::Context->dbh; >+ >+ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( >+ { template_name => "cataloguing/value_builder/marc21_field_007.tt", >+ query => $input, >+ type => "intranet", >+ authnotrequired => 0, >+ flagsrequired => { editcatalogue => '*' }, >+ debug => 1, >+ } >+ ); >+ $result = "ta" unless $result; >+ my $f0 = substr( $result, 0, 1 ); >+ my $f1 = substr( $result, 1, 1 ); >+ >+ #added new parameters to allow for all material types >+ my $f2 = substr( $result, 2, 1 ); >+ my $f3 = substr( $result, 3, 1 ); >+ my $f4 = substr( $result, 4, 1 ); >+ my $f5 = substr( $result, 5, 1 ); >+ my $f6 = substr( $result, 6, 1 ); >+ my $f7 = substr( $result, 7, 1 ); >+ my $f8 = substr( $result, 8, 1 ); >+ my $f9 = substr( $result, 9, 1 ); >+ my $f10 = substr( $result, 10, 1 ); >+ my $f11 = substr( $result, 11, 1 ); >+ my $f12 = substr( $result, 12, 1 ); >+ my $f13 = substr( $result, 13, 1 ); >+ my $f14 = substr( $result, 14, 1 ); >+ my $f15 = substr( $result, 15, 1 ); >+ my $f16 = substr( $result, 16, 1 ); >+ my $f17 = substr( $result, 17, 1 ); >+ my $f18 = substr( $result, 18, 1 ); >+ my $f19 = substr( $result, 19, 1 ); >+ my $f20 = substr( $result, 20, 1 ); >+ my $f21 = substr( $result, 21, 1 ); >+ my $f22 = substr( $result, 22, 1 ); >+ >+ #FIXME: There is probably a more-elegant way to do this! >+ #FIXME: Two of the material types treat position 06, 07, and 08 as a single >+ #three-char field. This script works fine for creating values and sending them >+ #back to the MARC, but if there is already a value in the 007, it won't send >+ #it properly to the value builder for those two instances. Not sure how to solve. >+ $template->param( >+ index => $index, >+ f0 => $f0, >+ "f0$f0" => $f0, >+ f1 => $f1, >+ "f1$f1" => $f1, >+ f2 => $f2, >+ "f2$f2" => $f2, >+ f3 => $f3, >+ "f3$f3" => $f3, >+ f4 => $f4, >+ "f4$f4" => $f4, >+ f5 => $f5, >+ "f5$f5" => $f5, >+ f6 => $f6, >+ "f6$f6" => $f6, >+ f7 => $f7, >+ "f7$f7" => $f7, >+ f8 => $f8, >+ "f8$f8" => $f8, >+ f9 => $f9, >+ "f9$f9" => $f9, >+ f10 => $f10, >+ "f10$f10" => $f10, >+ f11 => $f11, >+ "f11$f11" => $f11, >+ f12 => $f12, >+ "f12$f12" => $f12, >+ f13 => $f13, >+ "f13$f13" => $f13, >+ f14 => $f14, >+ "f14$f14" => $f14, >+ f15 => $f15, >+ "f15$f15" => $f15, >+ f16 => $f16, >+ "f16$f16" => $f16, >+ f17 => $f17, >+ "f17$f17" => $f17, >+ f18 => $f18, >+ "f18$f18" => $f18, >+ f19 => $f19, >+ "f19$f19" => $f19, >+ f20 => $f20, >+ "f20$f20" => $f20, >+ f21 => $f21, >+ "f21$f21" => $f21, >+ f22 => $f22, >+ "f22$f22" => $f22, >+ ); >+ output_html_with_http_headers $input, $cookie, $template->output; > } >diff --git a/cataloguing/value_builder/marc21_leader.pl b/cataloguing/value_builder/marc21_leader.pl >index 58c849e..4b49ae0 100755 >--- a/cataloguing/value_builder/marc21_leader.pl >+++ b/cataloguing/value_builder/marc21_leader.pl >@@ -1,6 +1,5 @@ > #!/usr/bin/perl > >- > # Copyright 2000-2002 Katipo Communications > # > # This file is part of Koha. >@@ -19,6 +18,7 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use strict; >+ > #use warnings; FIXME - Bug 2505 > use C4::Auth; > use CGI qw ( -utf8 ); >@@ -28,9 +28,9 @@ use C4::Search; > use C4::Output; > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >-my $function_name= $field_number; >-my $res=" >+ my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_; >+ my $function_name = $field_number; >+ my $res = " > <script type=\"text/javascript\"> > //<![CDATA[ > >@@ -50,42 +50,44 @@ function Clic$function_name(i) { > </script> > "; > >-return ($function_name,$res); >+ return ( $function_name, $res ); > } >-sub plugin { >-my ($input) = @_; >- my $index= $input->param('index'); >- my $result= $input->param('result'); > >+sub plugin { >+ my ($input) = @_; >+ my $index = $input->param('index'); >+ my $result = $input->param('result'); > >- my $dbh = C4::Context->dbh; >+ my $dbh = C4::Context->dbh; > >-my ($template, $loggedinuser, $cookie) >- = get_template_and_user({template_name => "cataloguing/value_builder/marc21_leader.tt", >- query => $input, >- type => "intranet", >- authnotrequired => 0, >- flagsrequired => {editcatalogue => '*'}, >- debug => 1, >- }); >- $result = " nam a22 7a 4500" unless $result; >- my $f5 = substr($result,5,1); >- my $f6 = substr($result,6,1); >- my $f7 = substr($result,7,1); >- my $f8 = substr($result,8,1); >- my $f17 = substr($result,17,1); >- my $f18 = substr($result,18,1); >- my $f19 = substr($result,19,1); >- my $f2023 = substr($result,20,4); >- $template->param(index => $index, >- "f5$f5" => 1, >- "f6$f6" => 1, >- "f7$f7" => 1, >- "f8$f8" => 1, >- "f17$f17" => 1, >- "f18$f18" => 1, >- "f19$f19" => 1, >- "f2023" => $f2023, >- ); >- output_html_with_http_headers $input, $cookie, $template->output; >+ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( >+ { template_name => "cataloguing/value_builder/marc21_leader.tt", >+ query => $input, >+ type => "intranet", >+ authnotrequired => 0, >+ flagsrequired => { editcatalogue => '*' }, >+ debug => 1, >+ } >+ ); >+ $result = " nam a22 7a 4500" unless $result; >+ my $f5 = substr( $result, 5, 1 ); >+ my $f6 = substr( $result, 6, 1 ); >+ my $f7 = substr( $result, 7, 1 ); >+ my $f8 = substr( $result, 8, 1 ); >+ my $f17 = substr( $result, 17, 1 ); >+ my $f18 = substr( $result, 18, 1 ); >+ my $f19 = substr( $result, 19, 1 ); >+ my $f2023 = substr( $result, 20, 4 ); >+ $template->param( >+ index => $index, >+ "f5$f5" => 1, >+ "f6$f6" => 1, >+ "f7$f7" => 1, >+ "f8$f8" => 1, >+ "f17$f17" => 1, >+ "f18$f18" => 1, >+ "f19$f19" => 1, >+ "f2023" => $f2023, >+ ); >+ output_html_with_http_headers $input, $cookie, $template->output; > } >diff --git a/cataloguing/value_builder/marc21_leader_authorities.pl b/cataloguing/value_builder/marc21_leader_authorities.pl >index 57c1d93..15e31ff 100755 >--- a/cataloguing/value_builder/marc21_leader_authorities.pl >+++ b/cataloguing/value_builder/marc21_leader_authorities.pl >@@ -1,6 +1,5 @@ > #!/usr/bin/perl > >- > # Copyright 2000-2002 Katipo Communications > # > # This file is part of Koha. >@@ -19,6 +18,7 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use strict; >+ > #use warnings; FIXME - Bug 2505 > use C4::Auth; > use CGI qw ( -utf8 ); >@@ -28,9 +28,9 @@ use C4::Search; > use C4::Output; > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >-my $function_name= $field_number; >-my $res=" >+ my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_; >+ my $function_name = $field_number; >+ my $res = " > <script type=\"text/javascript\"> > //<![CDATA[ > >@@ -50,40 +50,42 @@ function Clic$function_name(i) { > </script> > "; > >-return ($function_name,$res); >+ return ( $function_name, $res ); > } >-sub plugin { >-my ($input) = @_; >- my $index= $input->param('index'); >- my $result= $input->param('result'); > >+sub plugin { >+ my ($input) = @_; >+ my $index = $input->param('index'); >+ my $result = $input->param('result'); > >- my $dbh = C4::Context->dbh; >+ my $dbh = C4::Context->dbh; > >-my ($template, $loggedinuser, $cookie) >- = get_template_and_user({template_name => "cataloguing/value_builder/marc21_leader_authorities.tt", >- query => $input, >- type => "intranet", >- authnotrequired => 0, >- flagsrequired => {editcatalogue => '*'}, >- debug => 1, >- }); >- $result = " nz a22 n 4500" unless $result; >- my $f5 = substr($result,5,1); >- my $f6 = substr($result,6,1); >- my $f7 = substr($result,7,1); >- my $f8 = substr($result,8,1); >- my $f9 = substr($result,9,1); >- my $f17 = substr($result,17,1); >- my $f2023 = substr($result,20,4); >- $template->param(index => $index, >- "f5$f5" => 1, >- "f6$f6" => 1, >- "f7$f7" => 1, >- "f8$f8" => 1, >- "f9$f9" => 1, >- "f17$f17" => 1, >- "f2023" => $f2023, >- ); >- output_html_with_http_headers $input, $cookie, $template->output; >+ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( >+ { template_name => "cataloguing/value_builder/marc21_leader_authorities.tt", >+ query => $input, >+ type => "intranet", >+ authnotrequired => 0, >+ flagsrequired => { editcatalogue => '*' }, >+ debug => 1, >+ } >+ ); >+ $result = " nz a22 n 4500" unless $result; >+ my $f5 = substr( $result, 5, 1 ); >+ my $f6 = substr( $result, 6, 1 ); >+ my $f7 = substr( $result, 7, 1 ); >+ my $f8 = substr( $result, 8, 1 ); >+ my $f9 = substr( $result, 9, 1 ); >+ my $f17 = substr( $result, 17, 1 ); >+ my $f2023 = substr( $result, 20, 4 ); >+ $template->param( >+ index => $index, >+ "f5$f5" => 1, >+ "f6$f6" => 1, >+ "f7$f7" => 1, >+ "f8$f8" => 1, >+ "f9$f9" => 1, >+ "f17$f17" => 1, >+ "f2023" => $f2023, >+ ); >+ output_html_with_http_headers $input, $cookie, $template->output; > } >diff --git a/cataloguing/value_builder/marc21_leader_book.pl b/cataloguing/value_builder/marc21_leader_book.pl >index 477fc95..45aeb70 100755 >--- a/cataloguing/value_builder/marc21_leader_book.pl >+++ b/cataloguing/value_builder/marc21_leader_book.pl >@@ -1,6 +1,5 @@ > #!/usr/bin/perl > >- > # Copyright 2000-2002 Katipo Communications > # > # This file is part of Koha. >@@ -19,6 +18,7 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use strict; >+ > #use warnings; FIXME - Bug 2505 > use C4::Auth; > use CGI qw ( -utf8 ); >@@ -28,9 +28,9 @@ use C4::Search; > use C4::Output; > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >-my $function_name= $field_number; >-my $res=" >+ my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_; >+ my $function_name = $field_number; >+ my $res = " > <script type=\"text/javascript\"> > //<![CDATA[ > >@@ -43,43 +43,45 @@ function Clic$function_name(i) { > </script> > "; > >-return ($function_name,$res); >+ return ( $function_name, $res ); > } >-sub plugin { >-my ($input) = @_; >- my $index= $input->param('index'); >- my $result= $input->param('result'); > >+sub plugin { >+ my ($input) = @_; >+ my $index = $input->param('index'); >+ my $result = $input->param('result'); > >- my $dbh = C4::Context->dbh; >+ my $dbh = C4::Context->dbh; > >-my ($template, $loggedinuser, $cookie) >- = get_template_and_user({template_name => "cataloguing/value_builder/marc21_leader.tt", >- query => $input, >- type => "intranet", >- authnotrequired => 0, >- flagsrequired => {editcatalogue => '*'}, >- debug => 1, >- }); >- $result = " nam 7a " unless $result; >- my $f5 = substr($result,5,1); >- my $f6 = substr($result,6,1); >- my $f7 = substr($result,7,1); >- my $f8 = substr($result,8,1); >- my $f9 = substr($result,9,1); >- my $f17 = substr($result,17,1); >- my $f18 = substr($result,18,1); >- my $f19 = substr($result,19,1); >+ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( >+ { template_name => "cataloguing/value_builder/marc21_leader.tt", >+ query => $input, >+ type => "intranet", >+ authnotrequired => 0, >+ flagsrequired => { editcatalogue => '*' }, >+ debug => 1, >+ } >+ ); >+ $result = " nam 7a " unless $result; >+ my $f5 = substr( $result, 5, 1 ); >+ my $f6 = substr( $result, 6, 1 ); >+ my $f7 = substr( $result, 7, 1 ); >+ my $f8 = substr( $result, 8, 1 ); >+ my $f9 = substr( $result, 9, 1 ); >+ my $f17 = substr( $result, 17, 1 ); >+ my $f18 = substr( $result, 18, 1 ); >+ my $f19 = substr( $result, 19, 1 ); > >- $template->param(index => $index, >- "f5$f5" => 1, >- "f6$f6" => 1, >- "f7$f7" => 1, >- "f8$f8" => 1, >- "f9$f9" => 1, >- "f17$f17" => 1, >- "f18$f18" => 1, >- "f19$f19" => 1, >- ); >- output_html_with_http_headers $input, $cookie, $template->output; >+ $template->param( >+ index => $index, >+ "f5$f5" => 1, >+ "f6$f6" => 1, >+ "f7$f7" => 1, >+ "f8$f8" => 1, >+ "f9$f9" => 1, >+ "f17$f17" => 1, >+ "f18$f18" => 1, >+ "f19$f19" => 1, >+ ); >+ output_html_with_http_headers $input, $cookie, $template->output; > } >diff --git a/cataloguing/value_builder/marc21_leader_computerfile.pl b/cataloguing/value_builder/marc21_leader_computerfile.pl >index f49debe..9dc90c7 100755 >--- a/cataloguing/value_builder/marc21_leader_computerfile.pl >+++ b/cataloguing/value_builder/marc21_leader_computerfile.pl >@@ -1,6 +1,5 @@ > #!/usr/bin/perl > >- > # Copyright 2000-2002 Katipo Communications > # > # This file is part of Koha. >@@ -19,6 +18,7 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use strict; >+ > #use warnings; FIXME - Bug 2505 > use C4::Auth; > use CGI qw ( -utf8 ); >@@ -28,9 +28,9 @@ use C4::Search; > use C4::Output; > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >-my $function_name= $field_number; >-my $res=" >+ my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_; >+ my $function_name = $field_number; >+ my $res = " > <script type=\"text/javascript\"> > //<![CDATA[ > >@@ -43,43 +43,45 @@ function Clic$function_name(i) { > </script> > "; > >-return ($function_name,$res); >+ return ( $function_name, $res ); > } >-sub plugin { >-my ($input) = @_; >- my $index= $input->param('index'); >- my $result= $input->param('result'); > >+sub plugin { >+ my ($input) = @_; >+ my $index = $input->param('index'); >+ my $result = $input->param('result'); > >- my $dbh = C4::Context->dbh; >+ my $dbh = C4::Context->dbh; > >-my ($template, $loggedinuser, $cookie) >- = get_template_and_user({template_name => "cataloguing/value_builder/marc21_leader_computerfile.tt", >- query => $input, >- type => "intranet", >- authnotrequired => 0, >- flagsrequired => {editcatalogue => '*'}, >- debug => 1, >- }); >- $result = " nmm 7a " unless $result; >- my $f5 = substr($result,5,1); >- my $f6 = substr($result,6,1); >- my $f7 = substr($result,7,1); >- my $f8 = substr($result,8,1); >- my $f9 = substr($result,9,1); >- my $f17 = substr($result,17,1); >- my $f18 = substr($result,18,1); >- my $f19 = substr($result,19,1); >+ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( >+ { template_name => "cataloguing/value_builder/marc21_leader_computerfile.tt", >+ query => $input, >+ type => "intranet", >+ authnotrequired => 0, >+ flagsrequired => { editcatalogue => '*' }, >+ debug => 1, >+ } >+ ); >+ $result = " nmm 7a " unless $result; >+ my $f5 = substr( $result, 5, 1 ); >+ my $f6 = substr( $result, 6, 1 ); >+ my $f7 = substr( $result, 7, 1 ); >+ my $f8 = substr( $result, 8, 1 ); >+ my $f9 = substr( $result, 9, 1 ); >+ my $f17 = substr( $result, 17, 1 ); >+ my $f18 = substr( $result, 18, 1 ); >+ my $f19 = substr( $result, 19, 1 ); > >- $template->param(index => $index, >- "f5$f5" => 1, >- "f6$f6" => 1, >- "f7$f7" => 1, >- "f8$f8" => 1, >- "f9$f9" => 1, >- "f17$f17" => 1, >- "f18$f18" => 1, >- "f19$f19" => 1, >- ); >- output_html_with_http_headers $input, $cookie, $template->output; >+ $template->param( >+ index => $index, >+ "f5$f5" => 1, >+ "f6$f6" => 1, >+ "f7$f7" => 1, >+ "f8$f8" => 1, >+ "f9$f9" => 1, >+ "f17$f17" => 1, >+ "f18$f18" => 1, >+ "f19$f19" => 1, >+ ); >+ output_html_with_http_headers $input, $cookie, $template->output; > } >diff --git a/cataloguing/value_builder/marc21_leader_video.pl b/cataloguing/value_builder/marc21_leader_video.pl >index 7c761aa..7edc5f6 100755 >--- a/cataloguing/value_builder/marc21_leader_video.pl >+++ b/cataloguing/value_builder/marc21_leader_video.pl >@@ -1,6 +1,5 @@ > #!/usr/bin/perl > >- > # Copyright 2000-2002 Katipo Communications > # > # This file is part of Koha. >@@ -19,6 +18,7 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use strict; >+ > #use warnings; FIXME - Bug 2505 > use C4::Auth; > use CGI qw ( -utf8 ); >@@ -28,9 +28,9 @@ use C4::Search; > use C4::Output; > > sub plugin_javascript { >-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; >-my $function_name= $field_number; >-my $res=" >+ my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_; >+ my $function_name = $field_number; >+ my $res = " > <script type=\"text/javascript\"> > //<![CDATA[ > >@@ -43,43 +43,45 @@ function Clic$function_name(i) { > </script> > "; > >-return ($function_name,$res); >+ return ( $function_name, $res ); > } >-sub plugin { >-my ($input) = @_; >- my $index= $input->param('index'); >- my $result= $input->param('result'); > >+sub plugin { >+ my ($input) = @_; >+ my $index = $input->param('index'); >+ my $result = $input->param('result'); > >- my $dbh = C4::Context->dbh; >+ my $dbh = C4::Context->dbh; > >-my ($template, $loggedinuser, $cookie) >- = get_template_and_user({template_name => "cataloguing/value_builder/marc21_leader.tt", >- query => $input, >- type => "intranet", >- authnotrequired => 0, >- flagsrequired => {editcatalogue => '*'}, >- debug => 1, >- }); >- $result = " ngm 7a " unless $result; >- my $f5 = substr($result,5,1); >- my $f6 = substr($result,6,1); >- my $f7 = substr($result,7,1); >- my $f8 = substr($result,8,1); >- my $f9 = substr($result,9,1); >- my $f17 = substr($result,17,1); >- my $f18 = substr($result,18,1); >- my $f19 = substr($result,19,1); >+ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( >+ { template_name => "cataloguing/value_builder/marc21_leader.tt", >+ query => $input, >+ type => "intranet", >+ authnotrequired => 0, >+ flagsrequired => { editcatalogue => '*' }, >+ debug => 1, >+ } >+ ); >+ $result = " ngm 7a " unless $result; >+ my $f5 = substr( $result, 5, 1 ); >+ my $f6 = substr( $result, 6, 1 ); >+ my $f7 = substr( $result, 7, 1 ); >+ my $f8 = substr( $result, 8, 1 ); >+ my $f9 = substr( $result, 9, 1 ); >+ my $f17 = substr( $result, 17, 1 ); >+ my $f18 = substr( $result, 18, 1 ); >+ my $f19 = substr( $result, 19, 1 ); > >- $template->param(index => $index, >- "f5$f5" => 1, >- "f6$f6" => 1, >- "f7$f7" => 1, >- "f8$f8" => 1, >- "f9$f9" => 1, >- "f17$f17" => 1, >- "f18$f18" => 1, >- "f19$f19" => 1, >- ); >- output_html_with_http_headers $input, $cookie, $template->output; >+ $template->param( >+ index => $index, >+ "f5$f5" => 1, >+ "f6$f6" => 1, >+ "f7$f7" => 1, >+ "f8$f8" => 1, >+ "f9$f9" => 1, >+ "f17$f17" => 1, >+ "f18$f18" => 1, >+ "f19$f19" => 1, >+ ); >+ output_html_with_http_headers $input, $cookie, $template->output; > } >diff --git a/cataloguing/value_builder/marc21_linking_section.pl b/cataloguing/value_builder/marc21_linking_section.pl >index 8407ace..723840f 100644 >--- a/cataloguing/value_builder/marc21_linking_section.pl >+++ b/cataloguing/value_builder/marc21_linking_section.pl >@@ -34,9 +34,9 @@ use C4::Branch; > use C4::ItemType; > > sub plugin_javascript { >- my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_; >- my $function_name = $field_number; >- my $res = " >+ my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_; >+ my $function_name = $field_number; >+ my $res = " > <script type='text/javascript'> > function Clic$function_name(i) { > defaultvalue=document.getElementById(\"$field_number\").value; >@@ -60,275 +60,260 @@ sub plugin_javascript { > sub plugin { > my ($input) = @_; > my $dbh = C4::Context->dbh; >- my $query = new CGI; >- my $op = $query->param('op'); >- my $type = $query->param('type'); >- my $startfrom = $query->param('startfrom'); >+ my $query = new CGI; >+ my $op = $query->param('op'); >+ my $type = $query->param('type'); >+ my $startfrom = $query->param('startfrom'); > $startfrom = 0 if ( !defined $startfrom ); >- my ( $template, $loggedinuser, $cookie ); >- my $resultsperpage; >+ my ( $template, $loggedinuser, $cookie ); >+ my $resultsperpage; > my $searchdesc; > >- if ( $op eq "fillinput" ) { >- my $biblionumber = $query->param('biblionumber'); >- my $index = $query->param('index'); >- my $marcrecord; >- >- # open template >- ( $template, $loggedinuser, $cookie ) = get_template_and_user( >- { >- template_name => >- "cataloguing/value_builder/marc21_linking_section.tt", >- query => $query, >- type => "intranet", >- authnotrequired => 0, >- flagsrequired => { editcatalogue => '*' }, >- debug => 1, >- } >- ); >- >- #get marc record >- $marcrecord = GetMarcBiblio($biblionumber); >- >- my $subfield_value_9 = $biblionumber; >- my $subfield_value_0 = $biblionumber; >- >- #my $subfield_value_0; >- #$subfield_value_0 = $marcrecord->field('001')->data >- # if $marcrecord->field('001'); >- my $subfield_value_w; >- if ( $marcrecord->field('001') ) { >- $subfield_value_w = $marcrecord->field('001')->data; >- } >- else { >- $subfield_value_w = $biblionumber; >- } >- >- my $subfield_value_a; >- my $subfield_value_c; >- my $subfield_value_d; >- my $subfield_value_e; >- >- my $subfield_value_h; >- >- my $subfield_value_i; >- >- my $subfield_value_p; >- >- my $subfield_value_t; >- if ( $marcrecord->field('245') ) { >- $subfield_value_t = $marcrecord->title(); >- } >- >- my $subfield_value_u; >- my $subfield_value_v; >- my $subfield_value_x; >- my $subfield_value_y; >- my $subfield_value_z; >- >- $subfield_value_x = $marcrecord->field('022')->subfield("a") >- if ( $marcrecord->field('022') ); >- $subfield_value_z = $marcrecord->field('020')->subfield("a") >- if ( $marcrecord->field('020') ); >- >- # escape the 's >- $subfield_value_9 =~ s/'/\\'/g; >- $subfield_value_0 =~ s/'/\\'/g; >- $subfield_value_a =~ s/'/\\'/g; >- $subfield_value_c =~ s/'/\\'/g; >- $subfield_value_d =~ s/'/\\'/g; >- $subfield_value_e =~ s/'/\\'/g; >- $subfield_value_h =~ s/'/\\'/g; >- $subfield_value_i =~ s/'/\\'/g; >- $subfield_value_p =~ s/'/\\'/g; >- $subfield_value_t =~ s/'/\\'/g; >- $subfield_value_u =~ s/'/\\'/g; >- $subfield_value_v =~ s/'/\\'/g; >- $subfield_value_w =~ s/'/\\'/g; >- $subfield_value_x =~ s/'/\\'/g; >- $subfield_value_y =~ s/'/\\'/g; >- $subfield_value_z =~ s/'/\\'/g; >- $template->param( >- fillinput => 1, >- index => $query->param('index') . "", >- biblionumber => $biblionumber ? $biblionumber : "", >- subfield_value_9 => "$subfield_value_9", >- subfield_value_0 => "$subfield_value_0", >- subfield_value_a => "$subfield_value_a", >- subfield_value_c => "$subfield_value_c", >- subfield_value_d => "$subfield_value_d", >- subfield_value_e => "$subfield_value_e", >- subfield_value_h => "$subfield_value_h", >- subfield_value_i => "$subfield_value_i", >- subfield_value_p => "$subfield_value_p", >- subfield_value_t => "$subfield_value_t", >- subfield_value_u => "$subfield_value_u", >- subfield_value_v => "$subfield_value_v", >- subfield_value_w => "$subfield_value_w", >- subfield_value_x => "$subfield_value_x", >- subfield_value_y => "$subfield_value_y", >- subfield_value_z => "$subfield_value_z", >- ); >+ if ( $op eq "fillinput" ) { >+ my $biblionumber = $query->param('biblionumber'); >+ my $index = $query->param('index'); >+ my $marcrecord; >+ >+ # open template >+ ( $template, $loggedinuser, $cookie ) = get_template_and_user( >+ { template_name => "cataloguing/value_builder/marc21_linking_section.tt", >+ query => $query, >+ type => "intranet", >+ authnotrequired => 0, >+ flagsrequired => { editcatalogue => '*' }, >+ debug => 1, >+ } >+ ); >+ >+ #get marc record >+ $marcrecord = GetMarcBiblio($biblionumber); >+ >+ my $subfield_value_9 = $biblionumber; >+ my $subfield_value_0 = $biblionumber; >+ >+ #my $subfield_value_0; >+ #$subfield_value_0 = $marcrecord->field('001')->data >+ # if $marcrecord->field('001'); >+ my $subfield_value_w; >+ if ( $marcrecord->field('001') ) { >+ $subfield_value_w = $marcrecord->field('001')->data; >+ } else { >+ $subfield_value_w = $biblionumber; >+ } >+ >+ my $subfield_value_a; >+ my $subfield_value_c; >+ my $subfield_value_d; >+ my $subfield_value_e; >+ >+ my $subfield_value_h; >+ >+ my $subfield_value_i; >+ >+ my $subfield_value_p; >+ >+ my $subfield_value_t; >+ if ( $marcrecord->field('245') ) { >+ $subfield_value_t = $marcrecord->title(); >+ } >+ >+ my $subfield_value_u; >+ my $subfield_value_v; >+ my $subfield_value_x; >+ my $subfield_value_y; >+ my $subfield_value_z; >+ >+ $subfield_value_x = $marcrecord->field('022')->subfield("a") >+ if ( $marcrecord->field('022') ); >+ $subfield_value_z = $marcrecord->field('020')->subfield("a") >+ if ( $marcrecord->field('020') ); >+ >+ # escape the 's >+ $subfield_value_9 =~ s/'/\\'/g; >+ $subfield_value_0 =~ s/'/\\'/g; >+ $subfield_value_a =~ s/'/\\'/g; >+ $subfield_value_c =~ s/'/\\'/g; >+ $subfield_value_d =~ s/'/\\'/g; >+ $subfield_value_e =~ s/'/\\'/g; >+ $subfield_value_h =~ s/'/\\'/g; >+ $subfield_value_i =~ s/'/\\'/g; >+ $subfield_value_p =~ s/'/\\'/g; >+ $subfield_value_t =~ s/'/\\'/g; >+ $subfield_value_u =~ s/'/\\'/g; >+ $subfield_value_v =~ s/'/\\'/g; >+ $subfield_value_w =~ s/'/\\'/g; >+ $subfield_value_x =~ s/'/\\'/g; >+ $subfield_value_y =~ s/'/\\'/g; >+ $subfield_value_z =~ s/'/\\'/g; >+ $template->param( >+ fillinput => 1, >+ index => $query->param('index') . "", >+ biblionumber => $biblionumber ? $biblionumber : "", >+ subfield_value_9 => "$subfield_value_9", >+ subfield_value_0 => "$subfield_value_0", >+ subfield_value_a => "$subfield_value_a", >+ subfield_value_c => "$subfield_value_c", >+ subfield_value_d => "$subfield_value_d", >+ subfield_value_e => "$subfield_value_e", >+ subfield_value_h => "$subfield_value_h", >+ subfield_value_i => "$subfield_value_i", >+ subfield_value_p => "$subfield_value_p", >+ subfield_value_t => "$subfield_value_t", >+ subfield_value_u => "$subfield_value_u", >+ subfield_value_v => "$subfield_value_v", >+ subfield_value_w => "$subfield_value_w", >+ subfield_value_x => "$subfield_value_x", >+ subfield_value_y => "$subfield_value_y", >+ subfield_value_z => "$subfield_value_z", >+ ); > ############################################################### >- } >- elsif ( $op eq "do_search" ) { >- my $search = $query->param('search'); >- my $itype = $query->param('itype'); >- my $startfrom = $query->param('startfrom'); >- my $resultsperpage = $query->param('resultsperpage') || 20; >- my $orderby; >- my $QParser; >- $QParser = C4::Context->queryparser if (C4::Context->preference('UseQueryParser')); >- my $op; >- if ($QParser) { >- $op = '&&'; >- } else { >- $op = 'and'; >+ } elsif ( $op eq "do_search" ) { >+ my $search = $query->param('search'); >+ my $itype = $query->param('itype'); >+ my $startfrom = $query->param('startfrom'); >+ my $resultsperpage = $query->param('resultsperpage') || 20; >+ my $orderby; >+ my $QParser; >+ $QParser = C4::Context->queryparser if ( C4::Context->preference('UseQueryParser') ); >+ my $op; >+ >+ if ($QParser) { >+ $op = '&&'; >+ } else { >+ $op = 'and'; >+ } >+ $search = 'kw:' . $search . " $op mc-itemtype:" . $itype if $itype; >+ my ( $errors, $results, $total_hits ) = SimpleSearch( $search, $startfrom * $resultsperpage, $resultsperpage ); >+ if ( defined $errors ) { >+ $results = []; >+ } >+ my $total = @{$results}; >+ >+ # warn " biblio count : ".$total; >+ >+ ( $template, $loggedinuser, $cookie ) = get_template_and_user( >+ { template_name => "cataloguing/value_builder/marc21_linking_section.tt", >+ query => $query, >+ type => 'intranet', >+ authnotrequired => 0, >+ debug => 1, > } >- $search = 'kw:' . $search . " $op mc-itemtype:" . $itype if $itype; >- my ( $errors, $results, $total_hits ) = >- SimpleSearch( $search, $startfrom * $resultsperpage, >- $resultsperpage ); >- if ( defined $errors ) { >- $results = []; >- } >- my $total = @{$results}; >- >- # warn " biblio count : ".$total; >- >- ( $template, $loggedinuser, $cookie ) = get_template_and_user( >- { >- template_name => >- "cataloguing/value_builder/marc21_linking_section.tt", >- query => $query, >- type => 'intranet', >- authnotrequired => 0, >- debug => 1, >- } >- ); >- >- # multi page display gestion >- my $displaynext = 0; >- my $displayprev = $startfrom; >- >- if ( ( $total_hits - ( ( $startfrom + 1 ) * ($resultsperpage) ) ) > 0 ) >- { >- $displaynext = 1; >- } >- my @arrayresults; >- my @field_data = ($search); >- for ( my $i = 0 ; $i < $resultsperpage ; $i++ ) { >- my $record = C4::Search::new_record_from_zebra( 'biblioserver', $results->[$i] ); >- my $rechash = TransformMarcToKoha( $dbh, $record ); >- my $pos; >- my $countitems = $rechash->{itembumber} ? 1 : 0; >- while ( index( $rechash->{itemnumber}, '|', $pos ) > 0 ) { >- $countitems += 1; >- $pos = index( $rechash->{itemnumber}, '|', $pos ) + 1; >- } >- $rechash->{totitem} = $countitems; >- my @holdingbranches = split /\|/, $rechash->{holdingbranch}; >- my @itemcallnumbers = split /\|/, $rechash->{itemcallnumber}; >- my $CN; >- for ( my $i = 0 ; $i < @holdingbranches ; $i++ ) { >- $CN .= >- $holdingbranches[$i] . " ( " . $itemcallnumbers[$i] . " ) |"; >- } >- $CN =~ s/ \|$//; >- $rechash->{CN} = $CN; >- push @arrayresults, $rechash; >- } >- >- # for(my $i = 0 ; $i <= $#marclist ; $i++) >- # { >- # push @field_data, { term => "marclist", val=>$marclist[$i] }; >- # push @field_data, { term => "and_or", val=>$and_or[$i] }; >- # push @field_data, { term => "excluding", val=>$excluding[$i] }; >- # push @field_data, { term => "operator", val=>$operator[$i] }; >- # push @field_data, { term => "value", val=>$value[$i] }; >- # } >- >- my @numbers = (); >- >- if ( $total > $resultsperpage ) { >- for ( my $i = 1 ; $i < $total / $resultsperpage + 1 ; $i++ ) { >- if ( $i < 16 ) { >- my $highlight = 0; >- ( $startfrom == ( $i - 1 ) ) && ( $highlight = 1 ); >- push @numbers, >- { >- number => $i, >- highlight => $highlight, >- searchdata => \@field_data, >- startfrom => ( $i - 1 ) >- }; >- } >- } >- } >- >- my $from = $startfrom * $resultsperpage + 1; >- my $to; >- >- if ( $total_hits < $from + $resultsperpage ) { >- $to = $total_hits; >- } >- else { >- $to = $from + $resultsperpage; >- } >- my $defaultview = >- 'BiblioDefaultView' . C4::Context->preference('BiblioDefaultView'); >- >-# my $link="/cgi-bin/koha/cataloguing/value_builder/unimarc4XX.pl?op=do_search&q=$search_desc&resultsperpage=$resultsperpage&startfrom=$startfrom&search=$search"; >-# foreach my $sort (@sort_by){ >-# $link.="&sort_by=".$sort."&"; >-# } >-# $template->param( >-# pagination_bar => pagination_bar( >-# $link, >-# getnbpages($hits, $results_per_page), >-# $page, >-# 'page' >-# ), >-# ); >- $template->param( >- result => \@arrayresults, >- index => $query->param('index') . "", >- startfrom => $startfrom, >- displaynext => $displaynext, >- displayprev => $displayprev, >- resultsperpage => $resultsperpage, >- orderby => $orderby, >- startfromnext => $startfrom + 1, >- startfromprev => $startfrom - 1, >- searchdata => \@field_data, >- total => $total_hits, >- from => $from, >- to => $to, >- numbers => \@numbers, >- search => $search, >- $defaultview => 1, >- Search => 0 >- ); >+ ); >+ >+ # multi page display gestion >+ my $displaynext = 0; >+ my $displayprev = $startfrom; >+ >+ if ( ( $total_hits - ( ( $startfrom + 1 ) * ($resultsperpage) ) ) > 0 ) { >+ $displaynext = 1; >+ } >+ my @arrayresults; >+ my @field_data = ($search); >+ for ( my $i = 0 ; $i < $resultsperpage ; $i++ ) { >+ my $record = C4::Search::new_record_from_zebra( 'biblioserver', $results->[$i] ); >+ my $rechash = TransformMarcToKoha( $dbh, $record ); >+ my $pos; >+ my $countitems = $rechash->{itembumber} ? 1 : 0; >+ while ( index( $rechash->{itemnumber}, '|', $pos ) > 0 ) { >+ $countitems += 1; >+ $pos = index( $rechash->{itemnumber}, '|', $pos ) + 1; >+ } >+ $rechash->{totitem} = $countitems; >+ my @holdingbranches = split /\|/, $rechash->{holdingbranch}; >+ my @itemcallnumbers = split /\|/, $rechash->{itemcallnumber}; >+ my $CN; >+ for ( my $i = 0 ; $i < @holdingbranches ; $i++ ) { >+ $CN .= $holdingbranches[$i] . " ( " . $itemcallnumbers[$i] . " ) |"; >+ } >+ $CN =~ s/ \|$//; >+ $rechash->{CN} = $CN; >+ push @arrayresults, $rechash; >+ } >+ >+ # for(my $i = 0 ; $i <= $#marclist ; $i++) >+ # { >+ # push @field_data, { term => "marclist", val=>$marclist[$i] }; >+ # push @field_data, { term => "and_or", val=>$and_or[$i] }; >+ # push @field_data, { term => "excluding", val=>$excluding[$i] }; >+ # push @field_data, { term => "operator", val=>$operator[$i] }; >+ # push @field_data, { term => "value", val=>$value[$i] }; >+ # } >+ >+ my @numbers = (); >+ >+ if ( $total > $resultsperpage ) { >+ for ( my $i = 1 ; $i < $total / $resultsperpage + 1 ; $i++ ) { >+ if ( $i < 16 ) { >+ my $highlight = 0; >+ ( $startfrom == ( $i - 1 ) ) && ( $highlight = 1 ); >+ push @numbers, >+ { number => $i, >+ highlight => $highlight, >+ searchdata => \@field_data, >+ startfrom => ( $i - 1 ) >+ }; >+ } >+ } >+ } >+ >+ my $from = $startfrom * $resultsperpage + 1; >+ my $to; >+ >+ if ( $total_hits < $from + $resultsperpage ) { >+ $to = $total_hits; >+ } else { >+ $to = $from + $resultsperpage; >+ } >+ my $defaultview = 'BiblioDefaultView' . C4::Context->preference('BiblioDefaultView'); >+ >+ # my $link="/cgi-bin/koha/cataloguing/value_builder/unimarc4XX.pl?op=do_search&q=$search_desc&resultsperpage=$resultsperpage&startfrom=$startfrom&search=$search"; >+ # foreach my $sort (@sort_by){ >+ # $link.="&sort_by=".$sort."&"; >+ # } >+ # $template->param( >+ # pagination_bar => pagination_bar( >+ # $link, >+ # getnbpages($hits, $results_per_page), >+ # $page, >+ # 'page' >+ # ), >+ # ); >+ $template->param( >+ result => \@arrayresults, >+ index => $query->param('index') . "", >+ startfrom => $startfrom, >+ displaynext => $displaynext, >+ displayprev => $displayprev, >+ resultsperpage => $resultsperpage, >+ orderby => $orderby, >+ startfromnext => $startfrom + 1, >+ startfromprev => $startfrom - 1, >+ searchdata => \@field_data, >+ total => $total_hits, >+ from => $from, >+ to => $to, >+ numbers => \@numbers, >+ search => $search, >+ $defaultview => 1, >+ Search => 0 >+ ); >+ >+ } else { >+ ( $template, $loggedinuser, $cookie ) = get_template_and_user( >+ { template_name => "cataloguing/value_builder/marc21_linking_section.tt", >+ query => $query, >+ type => "intranet", >+ authnotrequired => 0, >+ } >+ ); >+ >+ my @itemtypes = C4::ItemType->all; > >+ $template->param( >+ itypeloop => \@itemtypes, >+ index => $query->param('index'), >+ Search => 1, >+ ); > } >- else { >- ( $template, $loggedinuser, $cookie ) = get_template_and_user( >- { >- template_name => >- "cataloguing/value_builder/marc21_linking_section.tt", >- query => $query, >- type => "intranet", >- authnotrequired => 0, >- } >- ); >- >- my @itemtypes = C4::ItemType->all; >- >- $template->param( >- itypeloop => \@itemtypes, >- index => $query->param('index'), >- Search => 1, >- ); >- } >- output_html_with_http_headers $query, $cookie, $template->output; >+ output_html_with_http_headers $query, $cookie, $template->output; > } >-- >1.7.9.5
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=39371">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13437
:
39093
|
39095
|
39140
|
39141
|
39142
|
39177
|
39184
|
39193
|
39194
|
39195
|
39196
|
39371
|
39372
|
39373
|
39374
|
39375
|
39949
|
39950
|
39951
|
39952
|
39953