Attachment 39397 Details for Bug 6679 – [PASSED QA] Bug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm

[patch] [PASSED QA] Bug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm

PASSED-QA-Bug-6679-follow-up-fix-9-perlcritic-viol.patch (text/plain), 1.86 KB, created by Kyle M Hall (khall) on 2015-05-22 12:26:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2015-05-22 12:26:19 UTC

Size: 1.86 KB

patch

obsolete

>From 98fc56d75590981ce0e1b415c7a17a80999a1b97 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Tue, 9 Dec 2014 09:48:58 +0100
>Subject: [PATCH] [PASSED QA] Bug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/TmplToken.pm     |    2 +-
> C4/TmplTokenType.pm |   18 +++++++++---------
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
>diff --git a/C4/TmplToken.pm b/C4/TmplToken.pm
>index 05648ce..9bd959d 100644
>--- a/C4/TmplToken.pm
>+++ b/C4/TmplToken.pm
>@@ -92,7 +92,7 @@ sub set_children {
> # FIXME: DIRECTIVE is not necessarily TMPL_VAR !!
> sub parameters_and_fields {
>     my $this = shift;
>-    return map { $_->type == C4::TmplTokenType::DIRECTIVE? $_:
>+    return map { $_->type == C4::TmplTokenType::DIRECTIVE() ? $_:
> 		($_->type == C4::TmplTokenType::TAG
> 			&& $_->string =~ /^<input\b/is)? $_: ()}
> 	    @{$this->{'_kids'}};
>diff --git a/C4/TmplTokenType.pm b/C4/TmplTokenType.pm
>index a08c718..aaae86d 100644
>--- a/C4/TmplTokenType.pm
>+++ b/C4/TmplTokenType.pm
>@@ -83,15 +83,15 @@ sub to_string {
>     return $this->{'name'}
> }
> 
>-sub TEXT		 { $_text }
>-sub TEXT_PARAMETRIZED	 { $_text_parametrized }
>-sub CDATA		 { $_cdata }
>-sub TAG			 { $_tag }
>-sub DECL		 { $_decl }
>-sub PI			 { $_pi }
>-sub DIRECTIVE		 { $_directive }
>-sub COMMENT		 { $_comment }
>-sub UNKNOWN		 { $_unknown }
>+sub TEXT              { $_text }
>+sub TEXT_PARAMETRIZED { $_text_parametrized }
>+sub CDATA             { $_cdata }
>+sub TAG               { $_tag }
>+sub DECL              { $_decl }
>+sub PI                { $_pi }
>+sub DIRECTIVE         { $_directive }
>+sub COMMENT           { $_comment }
>+sub UNKNOWN           { $_unknown }
> 
> ###############################################################################
> 
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 6679: 4883 | 4884 | 4885 | 4886 | 4887 | 4888 | 5445 | 5446 | 5483 | 5487 | 6121 | 6122 | 6123 | 6139 | 6140 | 6141 | 6142 | 6143 | 6144 | 6270 | 6271 | 6663 | 6670 | 6675 | 6676 | 6677 | 6678 | 8542 | 8897 | 8898 | 8899 | 8950 | 8951 | 9746 | 9747 | 9748 | 9749 | 9750 | 10050 | 10051 | 10052 | 10053 | 10054 | 10075 | 10076 | 10077 | 10078 | 10079 | 10484 | 10485 | 10486 | 10487 | 10488 | 10489 | 10491 | 10492 | 10493 | 10494 | 10495 | 10496 | 10497 | 10499 | 10500 | 10501 | 10502 | 10503 | 10504 | 10505 | 10506 | 10507 | 10508 | 10509 | 10510 | 10512 | 10513 | 10514 | 10515 | 10517 | 10521 | 10522 | 10523 | 10524 | 10525 | 10526 | 10527 | 10935 | 10936 | 10938 | 10940 | 10944 | 10945 | 10946 | 10947 | 10948 | 10949 | 10950 | 10952 | 10953 | 10955 | 10957 | 10958 | 10959 | 10960 | 10961 | 10962 | 10963 | 10964 | 10965 | 10966 | 10967 | 10972 | 10976 | 10979 | 10980 | 10981 | 12224 | 12363 | 12490 | 12491 | 12492 | 34191 | 34192 | 34193 | 34194 | 34195 | 34196 | 34197 | 39100 | 39101 | 39102 | 39392 | 39393 | 39394 | 39395 | 39396 | 39397 | 39398 | 42770 | 47086 | 47087 | 47088 | 47089 | 47090 | 47178 | 47179 | 47180 | 47181 | 47205 | 47206 | 47207 | 47208