Bugzilla – Attachment 39399 Details for
Bug 14186
Noisy warns in opac-reserve.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 14186: Undefined $reservedfor causes warn in opac-reserve.pl
PASSED-QA-Bug-14186-Undefined-reservedfor-causes-w.patch (text/plain), 1.66 KB, created by
Kyle M Hall (khall)
on 2015-05-22 12:30:08 UTC
(
hide
)
Description:
[PASSED QA] Bug 14186: Undefined $reservedfor causes warn in opac-reserve.pl
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-05-22 12:30:08 UTC
Size:
1.66 KB
patch
obsolete
>From 2cd8e53c38f34e6fdba7d13d1d287eb193fa9810 Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Tue, 12 May 2015 03:30:46 +0000 >Subject: [PATCH] [PASSED QA] Bug 14186: Undefined $reservedfor causes warn in opac-reserve.pl > >This patch sets $reservedfor to an empty string. > >Test plan >========= > >1/ in a terminal, run `tail -f ` on your instance's opac-error.log >2/ go to the opac and search from an item that exists on the Koha > instance. >3/ Select the title (if more than one title is returned) and click on > 'Place hold' link to go to opac-reserve.pl >4/ notice the warning - "opac-reserve.pl: Use of uninitialized value > $reservedfor" appear in the `tail`ed opac-error.log >5/ apply the patch >6/ reload the page (opac-reserve.pl) >7/ page works but the warning in step #4 is no longer thrown up >8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error > >Remarks: The QA test failed - "forbidden pattern: tab char (line 470)". > > Marking this as 'FAILED QA' > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > opac/opac-reserve.pl | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > >diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl >index 920916e..9e9a4a0 100755 >--- a/opac/opac-reserve.pl >+++ b/opac/opac-reserve.pl >@@ -466,7 +466,8 @@ foreach my $biblioNum (@biblionumbers) { > my $ItemBorrowerReserveInfo = GetMemberDetails( $reservedfor, 0); > > # the item could be reserved for this borrower vi a host record, flag this >- if ($reservedfor eq $borrowernumber){ >+ $reservedfor //= ''; >+ if ($reservedfor eq $borrowernumber){ > $itemLoopIter->{already_reserved} = 1; > } > >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14186
:
39057
|
39175
|
39176
|
39399
|
39400
|
39401
|
39402