Bugzilla – Attachment 39403 Details for
Bug 14185
Noisy warns in opac-readingrecord.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 14185: Undefined $limit causes warn in opac/opac-readingrecord.pl
PASSED-QA-Bug-14185-Undefined-limit-causes-warn-in.patch (text/plain), 1.52 KB, created by
Kyle M Hall (khall)
on 2015-05-22 12:33:11 UTC
(
hide
)
Description:
[PASSED QA] Bug 14185: Undefined $limit causes warn in opac/opac-readingrecord.pl
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-05-22 12:33:11 UTC
Size:
1.52 KB
patch
obsolete
>From 5d8edba56034d765863df89e0129fa19c82ee1eb Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Tue, 12 May 2015 03:01:35 +0000 >Subject: [PATCH] [PASSED QA] Bug 14185: Undefined $limit causes warn in opac/opac-readingrecord.pl > >This patch sets $limit to be an empty string. > >Test plan >========= > >1/ login into the opac using your user account credentials >2/ in a terminal, run a `tail -f ` on your instance's opac-error.log >3/ go back to the opac, click on 'your reading history' tab to go to > opac-readingrecord.pl >4/ notice the warning - "opac-readingrecord.pl: Use of uninitialized > value $limit" appear in the `tail`ed opac-error.log >5/ apply the patch >6/ reload the page (opac-readingrecord.pl) >7/ page works but the warning in step #4 is no longer logged >8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error > >Remarks: Testing result match expected test plan output. The QA tests > pass with "OK" for the commit. > >Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > opac/opac-readingrecord.pl | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > >diff --git a/opac/opac-readingrecord.pl b/opac/opac-readingrecord.pl >index 4a1ac78..795e90c 100755 >--- a/opac/opac-readingrecord.pl >+++ b/opac/opac-readingrecord.pl >@@ -73,6 +73,7 @@ else { > > > my $limit = $query->param('limit'); >+$limit //= ''; > $limit = ( $limit eq 'full' ) ? 0 : 50; > > my $issues = GetAllIssues( $borrowernumber, $order, $limit ); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14185
:
39056
|
39111
| 39403