Attachment 39407 Details for Bug 14135 – Bug 14135 [ENH] Adds 'Free' to variabletypes in systempreferences.tt The 'Local Use' system preference addition/modification template provides the following options against "Variable Type" - Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Uplo

[patch] Bug 14135 [ENH] Adds 'Free' to variabletypes in systempreferences.tt The 'Local Use' system preference addition/modification template provides the following options against "Variable Type" - Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Uplo

Bug-14135-ENH-Adds-Free-to-variabletypes-in-system.patch (text/plain), 3.63 KB, created by Jonathan Druart on 2015-05-22 13:35:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-05-22 13:35:33 UTC

Size: 3.63 KB

patch

obsolete

>From 0c63c05141ae00582309d0f956f30a7a12d67f59 Mon Sep 17 00:00:00 2001
>From: Indranil Das Gupta <indradg@l2c2.co.in>
>Date: Mon, 4 May 2015 18:55:15 +0530
>Subject: [PATCH] Bug 14135 [ENH] Adds 'Free' to variabletypes in
> systempreferences.tt The 'Local Use' system preference addition/modification
> template provides the following options against "Variable Type" - Choice,
> YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSource.
>
>There is no option presented for "Free" which seems to be the most
>used variable type out-of-the-box (i.e. INTRAdidyoumean,
>OPACdidyoumean, UsageStatsID and UsageStatsLastUpdateTime)
>
>This trivial patch proposes to modify the systempreferences.tt
>and add the option 'Free' to the list offered to users.
>
>Test Plan
>=========
>
>1/ Go to Home > Administration > System preferences > Local use
>2/ Click on 'New preference'.
>3/ In the fieldset 'Koha Internal', the variable types offered
>   are Choice, YesNo, Integer, Textarea, Float, Themes,
>   Languages, Upload or ClassSources.
>4/ Clicking on 'Choice' should set the 'preftype' field as
>   'Choice'.
>5/ Apply this patch.
>6/ Refresh the page.
>7/ The variable types list should read - "Free, Choice, YesNo,
>   Integer, Textarea, Float, Themes, Languages, Upload or
>   ClassSources".
>8/ Clicking on 'Free' should set the 'preftype' field as 'Free'.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>
>NOTE: Discovered that there is no validation on the type field.
>      However, that is beyond the scope of this bug.
>
>Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt
>index dba6c08..e699041 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt
>@@ -200,7 +200,7 @@
>         <div class="hint">Note: you should have no reasons to modify the following default values</div>
>         <ol>
>         <li><label for="preftype">Variable type:</label>
>-        <div class="hint"> (<span class="variabletype" id="Choice">Choice</span>, <span class="variabletype" id="YesNo">YesNo</span>, <span class="variabletype" id="Integer">Integer</span>, <span class="variabletype" id="Textarea">Textarea</span>, <span class="variabletype" id="Float">Float</span>, <span class="variabletype" id="Themes">Themes</span>, <span class="variabletype" id="Languages">Languages</span>, <span class="variabletype" id="Upload">Upload</span> or <span class="variabletype" id="ClassSources">ClassSources</span>)</div>
>+        <div class="hint"> (<span class="variabletype" id="Free">Free</span>, <span class="variabletype" id="Choice">Choice</span>, <span class="variabletype" id="YesNo">YesNo</span>, <span class="variabletype" id="Integer">Integer</span>, <span class="variabletype" id="Textarea">Textarea</span>, <span class="variabletype" id="Float">Float</span>, <span class="variabletype" id="Themes">Themes</span>, <span class="variabletype" id="Languages">Languages</span>, <span class="variabletype" id="Upload">Upload</span> or <span class="variabletype" id="ClassSources">ClassSources</span>)</div>
>         <input type="text" name="preftype" id="preftype" value="[% preftype %]" size="40" maxlength="40" /></li>
>         <li><label for="prefoptions">Variable options:</label>
>         <div class="hint">(a choice list for choice (separated by |) or cols|rows for texarea)</div>
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 14135: 38816 | 38903 | 39206 | 39407 | 39408