Bugzilla – Attachment 39449 Details for
Bug 14252
Make the OPAC language switcher available in the masthead navbar, footer, or both.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14252: (followup) fix lang chooser for sublanguages
Bug-14252-followup-fix-lang-chooser-for-sublanguag.patch (text/plain), 5.22 KB, created by
Indranil Das Gupta
on 2015-05-23 20:01:40 UTC
(
hide
)
Description:
Bug 14252: (followup) fix lang chooser for sublanguages
Filename:
MIME Type:
Creator:
Indranil Das Gupta
Created:
2015-05-23 20:01:40 UTC
Size:
5.22 KB
patch
obsolete
>From ba097ab099c1a17f792bc6f06c999986f8ba80e8 Mon Sep 17 00:00:00 2001 >From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Date: Sat, 23 May 2015 14:40:52 -0300 >Subject: [PATCH] Bug 14252: (followup) fix lang chooser for sublanguages > >This quick fix disables sublanguages dropdown, >show all sublanguages on same level. > >To test: >1) Apply both patches >2) Translate to have sublanguages (en-NZ, de-DE, de-CH) >3) Go to opac, confirm you can select any lang/sublang >4) Check on movil device > >4th version. >Removed rfc4646 subtag on sublanguages, think it's cleaner. >Currently on master all translated languages/regions have >valid description ('en' at least) >Added language sort using rfc4646 subtag > >Signed-off-by: Indranil Das Gupta <indradg@gmail.com> >Followup fixes the issue with lang group dropdowns. Works well >across standard desktop as well as mobile device with small screens >(checked on 4.3" / 4.7" / 5") >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >index 39b156c..a434304 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >@@ -77,23 +77,18 @@ > <li class="dropdown"> > <a href="#" title="Switch languages" class="dropdown-toggle" id="langmenu" data-toggle="dropdown" role="button"><i class="icon-flag icon-white"></i> <span class="langlabel">Languages</span> <b class="caret"></b></a> > <ul aria-labelledby="langmenu" role="menu" class="dropdown-menu"> >- [% FOREACH languages_loo IN languages_loop %] >+ [% FOREACH languages_loo IN languages_loop.sort('rfc4646_subtag') %] > [% IF ( languages_loo.group_enabled ) %] > [% IF ( languages_loo.plural ) %] >- <li class="dropdown"> >- <a data-toggle="dropdown" class="dropdown-toggle sublangs" id="show[% languages_loo.rfc4646_subtag %]" href="#">[% IF ( languages_loo.native_description ) %][% languages_loo.native_description %][% ELSE %][% languages_loo.rfc4646_subtag %][% END %] <b class="caret"></b></a> >- <ul id="sub[% languages_loo.rfc4646_subtag %]" class="dropdown-menu"> > [% FOREACH sublanguages_loo IN languages_loo.sublanguages_loop %] > [% IF ( sublanguages_loo.enabled ) %] > [% IF ( sublanguages_loo.sublanguage_current ) %] >- <li role="presentation"> <a href="#" tabindex="-1" class="menu-inactive" role="menuitem">[% sublanguages_loo.native_description %] [% sublanguages_loo.script_description %] [% sublanguages_loo.region_description %] [% sublanguages_loo.variant_description %] ([% sublanguages_loo.rfc4646_subtag %]) <i class="icon-ok"></i></a></li> >+ <li role="presentation"> <a href="#" tabindex="-1" class="menu-inactive" role="menuitem">[% sublanguages_loo.native_description %] [% sublanguages_loo.script_description %] [% sublanguages_loo.region_description %] [% sublanguages_loo.variant_description %] <i class="icon-ok"></i></a></li> > [% ELSE %] >- <li role="presentation"><a href="/cgi-bin/koha/opac-changelanguage.pl?language=[% sublanguages_loo.rfc4646_subtag %]" tabindex="-1" role="menuitem" class="listmenulink"> [% sublanguages_loo.native_description %] [% sublanguages_loo.script_description %] [% sublanguages_loo.region_description %] [% sublanguages_loo.variant_description %] ([% sublanguages_loo.rfc4646_subtag %])</a></li> >+ <li role="presentation"><a href="/cgi-bin/koha/opac-changelanguage.pl?language=[% sublanguages_loo.rfc4646_subtag %]" tabindex="-1" role="menuitem" class="listmenulink"> [% sublanguages_loo.native_description %] [% sublanguages_loo.script_description %] [% sublanguages_loo.region_description %] [% sublanguages_loo.variant_description %]</a></li> > [% END %] > [% END # / IF sublanguages_loo.enabled %] > [% END # / FOREACH sublanguages_loo %] >- </ul> <!-- languages_loo.rfc4646_subtag --> >- </li> <!-- / .more --> > [% ELSE %] > [% IF ( languages_loo.group_enabled ) %] > [% IF ( languages_loo.current ) %] >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14252
:
39369
|
39433
|
39434
|
39436
|
39443
|
39444
|
39445
|
39446
|
39447
|
39448
|
39449
|
39622
|
39650
|
39706
|
39707
|
39724
|
39725
|
39726
|
39727
|
39728
|
39729
|
39730
|
39731
|
39732
|
39733
|
39734
|
39746
|
39749
|
39857
|
39858
|
39859
|
39860
|
39861
|
39862
|
39863
|
39864