Attachment 39469 Details for Bug 12357 – Bug 12357: Fix comma issues related to additional fields.

[patch] Bug 12357: Fix comma issues related to additional fields.

Bug-12357-Fix-comma-issues-related-to-additional-f.patch (text/plain), 1.06 KB, created by Mark Tompsett on 2015-05-25 04:09:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2015-05-25 04:09:18 UTC

Size: 1.06 KB

patch

obsolete

>From 476a2904bc5acea1ed253a36eb63b4f3891a99cd Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Mon, 25 May 2015 00:06:24 -0400
>Subject: [PATCH] Bug 12357: Fix comma issues related to additional fields.
>
>TEST PLAN
>---------
>1) Apply patches, except this one.
>2) prove t/db_dependent/Record.t
>   -- fails like comment #38
>3) Apply this patch
>4) prove t/db_dependent/Record.t
>   -- now it passes.
>5) koha qa test tools.
>---
> C4/Record.pm | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/C4/Record.pm b/C4/Record.pm
>index 2e6ed98..a3bc860 100644
>--- a/C4/Record.pm
>+++ b/C4/Record.pm
>@@ -782,9 +782,9 @@ sub marc2bibtex {
>         push @elt, qq|\t$bh[$i] = {$bh[$i+1]}|;
>     }
>     $tex .= join(",\n", $id, @elt);
>-    $tex .= "\n";
> 
>     if ($additional_fields) {
>+        $tex .= ",\n";
>         foreach my $bibtex_tag ( keys %$additional_fields ) {
>             next if $bibtex_tag eq '@';
> 
>@@ -802,6 +802,9 @@ sub marc2bibtex {
>             }
>         }
>     }
>+    else {
>+        $tex .= "\n";
>+    }
> 
>     $tex .= "}\n";
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 12357: 28646 | 28647 | 28648 | 28649 | 28650 | 29291 | 29292 | 29293 | 29294 | 29295 | 29296 | 29297 | 31677 | 31678 | 31679 | 31680 | 33123 | 33124 | 33125 | 33126 | 35485 | 35487 | 35489 | 35826 | 35827 | 35828 | 38602 | 38604 | 39469 | 39471 | 39773 | 39774 | 39775 | 39776 | 39803 | 39804 | 39805 | 39806