Bugzilla – Attachment 39484 Details for
Bug 14268
Change Localsyspref type entry to dropdown
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14268 - Dropdown to select 'preftype'
Bug-14268---Dropdown-to-select-preftype.patch (text/plain), 2.93 KB, created by
Indranil Das Gupta
on 2015-05-25 11:18:08 UTC
(
hide
)
Description:
Bug 14268 - Dropdown to select 'preftype'
Filename:
MIME Type:
Creator:
Indranil Das Gupta
Created:
2015-05-25 11:18:08 UTC
Size:
2.93 KB
patch
obsolete
>From 06b08bf92df475a40719c2e276a587d4aca8de0c Mon Sep 17 00:00:00 2001 >From: Indranil Das Gupta <indradg@gmail.com> >Date: Mon, 25 May 2015 16:14:15 +0530 >Subject: [PATCH] Bug 14268 - Dropdown to select 'preftype' > >'preftype' for Local Use sysprefs is presently set by free form >input box (no UI level validation that leaves the user free to >enter arbitrary values). This patch addresses that in part by >changing it to a dropdown. > >The patch depends on patch at Bug 14135 > >Test plan >========= > >1/ apply patch available against 14135 (attachment 39408) >2/ apply this patch >3/ visit admin/systempreferences.pl?op=add_form > note the dropdown against 'Variable type' for fieldset 'Koha > internals'. By default, the type 'Free' would be selected. >--- > .../prog/en/modules/admin/systempreferences.tt | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt >index e699041..953ac79 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt >@@ -200,8 +200,18 @@ > <div class="hint">Note: you should have no reasons to modify the following default values</div> > <ol> > <li><label for="preftype">Variable type:</label> >- <div class="hint"> (<span class="variabletype" id="Free">Free</span>, <span class="variabletype" id="Choice">Choice</span>, <span class="variabletype" id="YesNo">YesNo</span>, <span class="variabletype" id="Integer">Integer</span>, <span class="variabletype" id="Textarea">Textarea</span>, <span class="variabletype" id="Float">Float</span>, <span class="variabletype" id="Themes">Themes</span>, <span class="variabletype" id="Languages">Languages</span>, <span class="variabletype" id="Upload">Upload</span> or <span class="variabletype" id="ClassSources">ClassSources</span>)</div> >- <input type="text" name="preftype" id="preftype" value="[% preftype %]" size="40" maxlength="40" /></li> >+ <select name="preftype" id="preftype"> >+ <option value="Choice">Choice</option> >+ <option value="ClassSources">ClassSources</option> >+ <option value="Float">Float</option> >+ <option value="Free" selected>Free</option> >+ <option value="Integer">Integer</option> >+ <option value="Languages">Languages</option> >+ <option value="Textarea">Textarea</option> >+ <option value="Themes">Themes</option> >+ <option value="Upload">Upload</option> >+ <option value="YesNo">YesNo</option> >+ </select> > <li><label for="prefoptions">Variable options:</label> > <div class="hint">(a choice list for choice (separated by |) or cols|rows for texarea)</div> > <input type="text" name="prefoptions" id="prefoptions" value="[% prefoptions %]" size="60" maxlength="80" /></li> >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14268
:
39484
|
39493
|
39494
|
39495
|
39496
|
39580
|
39581
|
39589
|
39590