Attachment 39497 Details for Bug 14266 – Replace trim() with $.trim() in opac-shareshelf.tt

[patch] Replace trim() with $.trim() in opac-shareshelf.tt

Replace-trim-with-trim-in-opac-shareshelftt.patch (text/plain), 1.88 KB, created by Indranil Das Gupta on 2015-05-25 23:45:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Indranil Das Gupta

Created: 2015-05-25 23:45:06 UTC

Size: 1.88 KB

patch

obsolete

>From 36f625822fe12b9f2fe05e28d4365ae1ea1fab71 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Mon, 25 May 2015 14:07:27 +1000
>Subject: [PATCH] Replace trim() with $.trim() in opac-shareshelf.tt
>
>This patch replaces trim() with $.trim() which is supported
>in versions of IE older than IE9.
>
>Revised test plan
>=================
>
>Before applying patch:
>
>0) Use IE 8 or Document Mode 8 in a newer IE using F12 Developer Tools
>1) Set OpacAllowSharingPrivateLists to "Allow" in Global System Preferences
>2) Create a private list in the OPAC
>3) Add a record to the private list
>4) Click "Share" or "Share list" on one of the list screens
>5) Type in an email address and click "Send"
>6) Note the error in the console log
>7) The page should submit
>
>Apply the patch:
>
>7) Hold shift + refresh the browser to update any Javascript cache
>8) Try to "Share" the list again
>9) Note that the form submit after clicking "Send" and
>that there are no errors in the console log
>
>http://bugs.koha-community.org/show_bug.cgi?id=14266
>
>Signed-off-by: Indranil Das Gupta <indradg@gmail.com>
>Remarks: Works as per revised test plan
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt
>index a02ebad..f40024f 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt
>@@ -44,7 +44,7 @@
> 
>     [% ELSIF op=='invite' %]
>         <div id="invite">
>-        <form method="post" onsubmit="return $('#invite_address').val().trim()!='';">
>+        <form method="post" onsubmit="return $.trim($('#invite_address').val())!='';">
>         <fieldset class="rows">
>             <ol>
>             <input type="hidden" name="op" value="conf_invite"/>
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14266: 39470 | 39497 | 39509 | 39647 | 39701