Attachment 39507 Details for Bug 10172 – Bug 10172: Hide some uneeded stuffs on printing a record

[patch] Bug 10172: Hide some uneeded stuffs on printing a record

Bug-10172-Hide-some-uneeded-stuffs-on-printing-a-r.patch (text/plain), 9.23 KB, created by Jonathan Druart on 2015-05-26 10:25:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-05-26 10:25:59 UTC

Size: 9.23 KB

patch

obsolete

>From 89afb6475cc1a080c011e4840b6e19c470b539ab Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Wed, 15 Apr 2015 12:39:05 +0200
>Subject: [PATCH] Bug 10172: Hide some uneeded stuffs on printing a record
>
>When printing a record from the OPAC or the staff interface, some
>uneeded blocks are displayed.
>
>OPAC:
>1/ Browse results
>2/ The view tags (Normal, MARC, ISBD)
>
>Intranet:
>1/ Marc view link
>2/ The Please upload one image link
>
>Test plan:
>On a record detail page (staff and OPAC), print the page and confirm
>these blocks no longer appear.
>
>Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/css/print.css               | 6 ++++++
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/css/print.css                 | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/less/print.less               | 5 +++++
> 4 files changed, 13 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/print.css b/koha-tmpl/intranet-tmpl/prog/en/css/print.css
>index e0e346e..c71c62b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/css/print.css
>+++ b/koha-tmpl/intranet-tmpl/prog/en/css/print.css
>@@ -323,3 +323,9 @@ fieldset {
> #cataloguing_additem_itemlist {
> 	overflow : visible !important;
> }
>+
>+#catalogue_detail_marc_preview,
>+p#upload_image
>+{
>+    display: none;
>+}
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index b782616..3ecbb0f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -86,7 +86,7 @@ function verify_images() {
>         var please_upload = _("Please %supload%s one.").format(
>             "<a href='/cgi-bin/koha/tools/upload-cover-image.pl?biblionumber=[% biblionumber %]&amp;filetype=image'>",
>             "</a>");
>-        no_images_msg += "<p>" + please_upload + '</p>';
>+        no_images_msg += "<p id='upload_image'>" + please_upload + '</p>';
>     [% END %]
> 
>         $('#images').html(no_images_msg);
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/print.css b/koha-tmpl/opac-tmpl/bootstrap/css/print.css
>index 5d9b744..95913f6 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/css/print.css
>+++ b/koha-tmpl/opac-tmpl/bootstrap/css/print.css
>@@ -1 +1 @@
>-.noprint{display:none}a:link{color:#006;text-decoration:none}a:visited{color:#006;text-decoration:none}a:hover{color:#930;text-decoration:none}a[href]:after{display:none}body{background-color:#fff;color:#333;font-family:arial,geneva,sans-serif;font-size:14px;margin:0 0 0 0;word-wrap:break-word}caption{color:#006;font-size:18px;font-weight:bold;margin-top:5px;text-align:left}div.table{width:100%}form{margin:0;padding:0}h1{color:#006;font-size:22px;font-weight:bold;margin-bottom:3px;margin-top:3px}h2{color:#006;font-size:20px;font-weight:bold;margin-bottom:3px;margin-top:3px}h3{color:#006;font-size:18px;font-weight:bold;margin-bottom:3px;margin-top:3px}h4{color:#006;font-size:16px;font-weight:bold;margin-bottom:3px;margin-top:3px}h5{color:#006;font-size:15px;font-weight:bold;margin-bottom:1px;margin-top:1px}h6{color:#006;font-size:14px;font-weight:bold;margin-bottom:1px;margin-top:1px}p{margin-top:0}table{background-color:#fff;border-bottom:0 solid #ccc;border-collapse:collapse;border-left:0 solid #ccc;margin:3px 0 5px 0;padding:0;width:99%}td{background-color:#fff;border-bottom:1px solid #ccc;border-right:1px solid #ccc;padding:5px 5px 5px 5px;vertical-align:top}td:last-child{background-color:#fff;border-bottom:1px solid #ccc;border-right:0 solid #ccc;padding:5px 5px 5px 5px;vertical-align:top}th{background-color:#e9e9e9;border-bottom:1px solid #ccc;border-right:1px solid #ccc;font-weight:bold;padding:5px 5px 5px 5px}th:last-child{background-color:#e9e9e9;border-bottom:1px solid #ccc;border-right:0 solid #ccc;font-weight:bold;padding:5px 5px 5px 5px}tr.highlight{background-color:#e9e9e9}body#basket tr.highlight{background-color:transparent}body#basket a{font-weight:bold}body#basket table{border-top:1px solid #eee;border-left:1px solid #eee}body#basket td,body#basket th{background-color:transparent;padding:2px}body#basket th{background-color:#eee}body#basket th,body#basket th[scope=col]{text-align:center;vertical-align:middle}body#basket th[scope=row]{font-size:89%;text-align:right;vertical-align:top;width:10%}body#basket p{font-size:85%;margin:.2em 0;text-indent:.5em}.error{font-weight:bold}.ex{font-family:"Courier New",Courier,monospace}.inline{display:inline}.screen{display:none}#bookcover{float:left;margin:0;padding:0}#members,#opac-main-search,#opac-user-views .ui-tabs-nav,input,h2 span.hint,td.resultscontrol,.pages,.suggestion,.views,#action,#export,#bibliodescriptions .ui-tabs-nav,#addshelf,fieldset.action,.list-actions,.ft,#facetcontainer,.results_summary.actions,.koha_url,.yui-b{display:none}#userresults{position:absolute;right:0;word-wrap:break-word;display:block}div#userupdate input,div#userupdate textarea{display:inline;border:0}#yui-main,#yui-main .yui-b,.yui-t1 #yui-main .yui-b{display:block !important;margin:0 !important;padding:0 !important;width:auto !important;float:none !important}.navbar,#navigation,.pages,.actions,#toolbar,#selections-toolbar,#remove-selected,.breadcrumb,#members,#opac-main-search,#opac-user-views .ui-tabs-nav,input,h2 span.hint,td.resultscontrol,.pages,.suggestion,.views,#action,#export,#bibliodescriptions .ui-tabs-nav,#addshelf,fieldset.action,.list-actions,.ft,#facetcontainer,.results_summary.actions,.koha_url,.yui-b{display:none}.row-fluid{margin-top:30px}
>\ No newline at end of file
>+.noprint{display:none}a:link{color:#006;text-decoration:none}a:visited{color:#006;text-decoration:none}a:hover{color:#930;text-decoration:none}a[href]:after{display:none}body{background-color:#fff;color:#333;font-family:arial,geneva,sans-serif;font-size:14px;margin:0 0 0 0;word-wrap:break-word}caption{color:#006;font-size:18px;font-weight:bold;margin-top:5px;text-align:left}div.table{width:100%}form{margin:0;padding:0}h1{color:#006;font-size:22px;font-weight:bold;margin-bottom:3px;margin-top:3px}h2{color:#006;font-size:20px;font-weight:bold;margin-bottom:3px;margin-top:3px}h3{color:#006;font-size:18px;font-weight:bold;margin-bottom:3px;margin-top:3px}h4{color:#006;font-size:16px;font-weight:bold;margin-bottom:3px;margin-top:3px}h5{color:#006;font-size:15px;font-weight:bold;margin-bottom:1px;margin-top:1px}h6{color:#006;font-size:14px;font-weight:bold;margin-bottom:1px;margin-top:1px}p{margin-top:0}table{background-color:#fff;border-bottom:0 solid #ccc;border-collapse:collapse;border-left:0 solid #ccc;margin:3px 0 5px 0;padding:0;width:99%}td{background-color:#fff;border-bottom:1px solid #ccc;border-right:1px solid #ccc;padding:5px 5px 5px 5px;vertical-align:top}td:last-child{background-color:#fff;border-bottom:1px solid #ccc;border-right:0 solid #ccc;padding:5px 5px 5px 5px;vertical-align:top}th{background-color:#e9e9e9;border-bottom:1px solid #ccc;border-right:1px solid #ccc;font-weight:bold;padding:5px 5px 5px 5px}th:last-child{background-color:#e9e9e9;border-bottom:1px solid #ccc;border-right:0 solid #ccc;font-weight:bold;padding:5px 5px 5px 5px}tr.highlight{background-color:#e9e9e9}body#basket tr.highlight{background-color:transparent}body#basket a{font-weight:bold}body#basket table{border-top:1px solid #eee;border-left:1px solid #eee}body#basket td,body#basket th{background-color:transparent;padding:2px}body#basket th{background-color:#eee}body#basket th,body#basket th[scope=col]{text-align:center;vertical-align:middle}body#basket th[scope=row]{font-size:89%;text-align:right;vertical-align:top;width:10%}body#basket p{font-size:85%;margin:.2em 0;text-indent:.5em}.error{font-weight:bold}.ex{font-family:"Courier New",Courier,monospace}.inline{display:inline}.screen{display:none}#bookcover{float:left;margin:0;padding:0}#members,#opac-main-search,#opac-user-views .ui-tabs-nav,input,h2 span.hint,td.resultscontrol,.pages,.suggestion,.views,#action,#export,#bibliodescriptions .ui-tabs-nav,#addshelf,fieldset.action,.list-actions,.ft,#facetcontainer,.results_summary.actions,.koha_url,.yui-b{display:none}#userresults{position:absolute;right:0;word-wrap:break-word;display:block}div#userupdate input,div#userupdate textarea{display:inline;border:0}#yui-main,#yui-main .yui-b,.yui-t1 #yui-main .yui-b{display:block !important;margin:0 !important;padding:0 !important;width:auto !important;float:none !important}.navbar,#navigation,.pages,.actions,#toolbar,#selections-toolbar,#remove-selected,.breadcrumb,#members,#opac-main-search,#opac-user-views .ui-tabs-nav,input,h2 span.hint,td.resultscontrol,.pages,.suggestion,.views,#action,#export,#bibliodescriptions .ui-tabs-nav,#addshelf,fieldset.action,.list-actions,.ft,#facetcontainer,.results_summary.actions,.koha_url,.yui-b{display:none}.row-fluid{margin-top:30px}#views,#ulactioncontainer{display:none}
>\ No newline at end of file
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/less/print.less b/koha-tmpl/opac-tmpl/bootstrap/less/print.less
>index d6ff894..92153cc 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/less/print.less
>+++ b/koha-tmpl/opac-tmpl/bootstrap/less/print.less
>@@ -238,3 +238,8 @@ div#userupdate input,div#userupdate textarea {
> .row-fluid {
>     margin-top: 30px;
> }
>+
>+#views,
>+#ulactioncontainer {
>+    display: none;
>+}
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 10172: 37899 | 37990 | 38231 | 39507