Bugzilla – Attachment 39535 Details for
Bug 13993
Set correct orderstatus when order is transferred from one vendor to another
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13993 - (1) Add tests to confirm 'new' and 'cancelled'
Bug-13993---1-Add-tests-to-confirm-new-and-cancell.patch (text/plain), 1.96 KB, created by
Jonathan Druart
on 2015-05-26 16:12:54 UTC
(
hide
)
Description:
Bug 13993 - (1) Add tests to confirm 'new' and 'cancelled'
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-05-26 16:12:54 UTC
Size:
1.96 KB
patch
obsolete
>From 69d0b27a38ca21337ae1af6393fef31813a4b747 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Thu, 16 Apr 2015 08:54:30 -0400 >Subject: [PATCH] Bug 13993 - (1) Add tests to confirm 'new' and 'cancelled' > >This adds 2 tests to t/db_dependent/Acquisition/TransferOrder.t >in order to confirm the order's status is properly marked. > >TEST PLAN >--------- >1) Log into staff client >2) Acquisitions >3) Create a basket for two differing vendors. >4) Place an order in one of the baskets. >5) Transfer the order from one vendor's basket to the others. >6) Apply this patch (1) only >7) prove -v t/db_dependent/Acquisition/TransferOrder.t > -- should fail one test: not marked as 'cancelled'. > >Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> >--- > t/db_dependent/Acquisition/TransferOrder.t | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Acquisition/TransferOrder.t b/t/db_dependent/Acquisition/TransferOrder.t >index d868240..2a1d6f2 100644 >--- a/t/db_dependent/Acquisition/TransferOrder.t >+++ b/t/db_dependent/Acquisition/TransferOrder.t >@@ -2,7 +2,7 @@ > > use Modern::Perl; > >-use Test::More tests => 11; >+use Test::More tests => 13; > use C4::Context; > use C4::Acquisition; > use C4::Biblio; >@@ -76,6 +76,12 @@ is(scalar GetOrders($basketno2), 0, "0 order in basket2"); > my $newordernumber = TransferOrder($ordernumber, $basketno2); > is(scalar GetOrders($basketno1), 0, "0 order in basket1"); > is(scalar GetOrders($basketno2), 1, "1 order in basket2"); >+ >+# Determine if the transfer marked things cancelled properly. >+is($order->{orderstatus},'new','Order marked as new as expected'); >+($order) = GetOrders($basketno1, { 'cancelled' => 1 }); >+is($order->{orderstatus},'cancelled','Order marked as cancelled as expected'); >+ > ($order) = GetOrders($basketno2); > is(scalar GetItemnumbersFromOrder($order->{ordernumber}), 1, "1 item in basket2's order"); > >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13993
:
37797
|
37798
|
37957
|
37958
|
37959
|
37977
|
37978
|
37979
|
38668
|
38669
|
38670
|
38674
|
38675
|
38676
|
39017
|
39018
|
39019
| 39535 |
39536
|
39537
|
39538