Attachment 39593 Details for Bug 14265 – Bug 14265 - Use $.trim instead of trim() in admin/categorie.tt

[patch] Bug 14265 - Use $.trim instead of trim() in admin/categorie.tt

Bug-14265---Use-trim-instead-of-trim-in-admincateg.patch (text/plain), 1.92 KB, created by Jonathan Druart on 2015-05-27 15:31:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-05-27 15:31:33 UTC

Size: 1.92 KB

patch

obsolete

>From 26f43668ea3470b151a26fac09b78680651a97d7 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Mon, 25 May 2015 14:01:09 +1000
>Subject: [PATCH] Bug 14265 - Use $.trim instead of trim() in
> admin/categorie.tt
>
>This patch replaces trim() with $.trim() in admin/categorie.tt, as
>$.trim() is more cross-platform (ie it is supported in "< IE9").
>
>_TEST PLAN_
>
>Before applying patch:
>
>0) Use IE 8 or use Document Mode 8 in a newer IE using F12 Developer Tools
>1) Go to Administration > Patron categories
>2) Click "Edit" next to a category
>3) Click "Save" at the bottom
>4) Note the form doesn't submit (you can also notice the error in the
>console log)
>
>Apply the patch:
>
>5) Hold down shift + refresh the page
>6) Click "Save" at the bottom"
>7) Note that the form does submit and there are no errors reported
>
>Signed-off-by: Indranil Das Gupta <indradg@gmail.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
>No regression found using iceweasel.
>I did not know the staff interface was IE compatible.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt
>index 769a0bc..92a6a28 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt
>@@ -47,7 +47,7 @@
> 	    var ok=0;
> 		var _alertString=_("Form not submitted because of the following problem(s)");
> 		_alertString +="\n-------------------------------------------------------------------\n\n";
>-                ff.categorycode.value = ff.categorycode.value.trim();
>+                ff.categorycode.value = $.trim(ff.categorycode.value);
>                 if (ff.categorycode.value.length==0) {
>                    ok=1;
>                    _alertString += _("- categorycode missing") + "\n";
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 14265: 39468 | 39486 | 39593