Bugzilla – Attachment 39688 Details for
Bug 14299
Today's checkouts not always sorting correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14299 - Today's checkouts not always sorting correctly
Bug-14299---Todays-checkouts-not-always-sorting-co.patch (text/plain), 1.16 KB, created by
Kyle M Hall (khall)
on 2015-05-29 13:39:16 UTC
(
hide
)
Description:
Bug 14299 - Today's checkouts not always sorting correctly
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-05-29 13:39:16 UTC
Size:
1.16 KB
patch
obsolete
>From fed23258104217bc4980433fa1425b77dbf08ea3 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 29 May 2015 09:36:34 -0400 >Subject: [PATCH] Bug 14299 - Today's checkouts not always sorting correctly > >Sometimes the today's checkouts do not sort correctly. This is due to a >simple typo in the comparison line where the bad key 'timstamp' is >compared against the correct key 'timestamp'. > >Test Plan: >1) Check out a decent number of items in a row ( 5+ ) >2) Hopefully you will see they are sorted incorrectly >3) Apply this patch >4) Reload the page >5) Note they are now sorted correctly >--- > svc/checkouts | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/svc/checkouts b/svc/checkouts >index d2eb8ee..cc703ae 100755 >--- a/svc/checkouts >+++ b/svc/checkouts >@@ -210,7 +210,7 @@ while ( my $c = $sth->fetchrow_hashref() ) { > } > > >-@checkouts_today = sort { $a->{timstamp} cmp $b->{timestamp} } @checkouts_today; >+@checkouts_today = sort { $a->{timestamp} cmp $b->{timestamp} } @checkouts_today; > @checkouts_today = reverse(@checkouts_today) > unless ( C4::Context->preference('todaysIssuesDefaultSortOrder') eq 'desc' ); > >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14299
:
39687
|
39688
|
39743
|
39810