Bugzilla – Attachment 3970 Details for
Bug 6237
Recent changes leave compile time warnings in additem.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed Patch
0001-Bug-6237-Remove-redeclarations-of-global-vars-in-sam.patch (text/plain), 1.33 KB, created by
Colin Campbell
on 2011-04-21 15:14:57 UTC
(
hide
)
Description:
Proposed Patch
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2011-04-21 15:14:57 UTC
Size:
1.33 KB
patch
obsolete
>From 7d70ca21cfbacfdb683e0d59e65450f79920e7c2 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Thu, 21 Apr 2011 16:05:44 +0100 >Subject: [PATCH 1/2] Bug 6237: Remove redeclarations of global vars in same > scope >Content-Type: text/plain; charset="utf-8" > >Scripts should be able to compile without warnings as a minimal test >a couple of variables are redeclared in the same scope generating >warnings. Remove the redeclations >--- > cataloguing/additem.pl | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > >diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl >index 43fb19f..faa9a0a 100755 >--- a/cataloguing/additem.pl >+++ b/cataloguing/additem.pl >@@ -262,7 +262,6 @@ sub generate_subfield_form { > > > my $input = new CGI; >-my $dbh = C4::Context->dbh; > my $error = $input->param('error'); > my $biblionumber = $input->param('biblionumber'); > my $itemnumber = $input->param('itemnumber'); >@@ -574,7 +573,7 @@ my $onlymine = C4::Context->preference('IndependantBranches') && > my $branches = GetBranchesLoop(C4::Context->userenv->{branch},$onlymine); # build once ahead of time, instead of multiple times later. > > # We generate form, from actuel record >-my @fields; >+@fields = (); > if($itemrecord){ > foreach my $field ($itemrecord->fields()){ > my $tag = $field->{_tag}; >-- >1.7.4.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6237
: 3970 |
3971