Bugzilla – Attachment 39767 Details for
Bug 14313
OPAC: Adding a comment makes result browser disappear
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 14313: OPAC - Adding a comment makes result browser disappear
SIGNED-OFF-Bug-14313-OPAC---Adding-a-comment-makes.patch (text/plain), 2.19 KB, created by
Bernardo Gonzalez Kriegel
on 2015-06-02 12:22:28 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 14313: OPAC - Adding a comment makes result browser disappear
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2015-06-02 12:22:28 UTC
Size:
2.19 KB
patch
obsolete
>From 0e2882ccad199af2a4ed7b0387d174d98b1b3d35 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Tue, 2 Jun 2015 09:54:15 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 14313: OPAC - Adding a comment makes result > browser disappear > >To reproduce: > >- Allow commenting in OPAC (Syspref reviewson) >- Log in to OPAC >- Do a search with many results >- Click on a biblio in result list >- Verify that you can browse the results in detail view ("Browse results") >- Repeat teh search above >- Click on the same biblio as above >- Add a comment (Tab "Comments") >- Close commenting window >- Click on "Next" in result browser > >Result: The next biblio is displayed, but result browser has disappeared. > >To test: > >- Apply patch >- Try to reproduce issue above, verify that result browser does no longer disappear > >AMended to remove whitespace chars. / MV > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Bug & solution checked, works well. No koha-qa errors >--- > C4/Auth.pm | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index d816332..96c5418 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -433,12 +433,15 @@ sub get_template_and_user { > $LibraryNameTitle =~ s/<(?:\/?)(?:br|p)\s*(?:\/?)>/ /sgi; > $LibraryNameTitle =~ s/<(?:[^<>'"]|'(?:[^']*)'|"(?:[^"]*)")*>//sg; > >- # clean up the busc param in the session if the page is not opac-detail and not the "add to list" page >+ # clean up the busc param in the session >+ # if the page is not opac-detail and not the "add to list" page >+ # and not the "edit comments" page > if ( C4::Context->preference("OpacBrowseResults") > && $in->{'template_name'} =~ /opac-(.+)\.(?:tt|tmpl)$/ ) { > my $pagename = $1; > unless ( $pagename =~ /^(?:MARC|ISBD)?detail$/ >- or $pagename =~ /^addbybiblionumber$/ ) { >+ or $pagename =~ /^addbybiblionumber$/ >+ or $pagename =~ /^review$/ ) { > my $sessionSearch = get_session( $sessionID || $in->{'query'}->cookie("CGISESSID") ); > $sessionSearch->clear( ["busc"] ) if ( $sessionSearch->param("busc") ); > } >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14313
:
39760
|
39761
|
39767
|
39801