Attachment 39772 Details for Bug 13904 – [SIGNED-OFF] Bug 13904: Make unimarc_field_4XX displays usefull 200 subfield data

[patch] [SIGNED-OFF] Bug 13904: Make unimarc_field_4XX displays usefull 200 subfield data

SIGNED-OFF-Bug-13904-Make-unimarcfield4XX-displays.patch (text/plain), 5.14 KB, created by Bernardo Gonzalez Kriegel on 2015-06-02 15:05:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bernardo Gonzalez Kriegel

Created: 2015-06-02 15:05:22 UTC

Size: 5.14 KB

patch

obsolete

>From 11d3f9b906a771180dfc56f87e01876fd8ece2c1 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr>
>Date: Tue, 26 May 2015 18:23:11 +0200
>Subject: [PATCH] [SIGNED-OFF] Bug 13904: Make unimarc_field_4XX displays
> usefull 200 subfield data
>
>When searching for multivolumes titles, UNIMARC 4xx field plugin
>displays the title of the biblios (200$a), without giving info about
>volumes (200 $h $i). It neither doesn't display $e (subtitle) info which
>could greatly help to disambiguate search result.
>
>The displayed title is supposed to link to a biblio record view (MARC /
>normal). It doesn't work.
>
>TO TEST:
>
>- On a UNIMARC Koha, add a new biblio record
>- Call the 4XX plugin from 461/463 field
>- Search for a biblio record which contains 200$e, and/or 200$h and/or
>  200$i subfields.
>- You get a result list, with two issues:
>  1. $a, $h & $i aren't displayed
>  2. Biblio title is not a link
>- Apply the patch, and repeat previous steps.
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>I got a link on fulltitle, but in 'ahie' order (not aehi)
>Fixed some tabs.
>---
> cataloguing/value_builder/unimarc_field_4XX.pl     |    8 ++++++++
> .../cataloguing/value_builder/unimarc_field_4XX.tt |   16 ++++++++--------
> 2 files changed, 16 insertions(+), 8 deletions(-)
>
>diff --git a/cataloguing/value_builder/unimarc_field_4XX.pl b/cataloguing/value_builder/unimarc_field_4XX.pl
>index 5ab5bf1..56b5e14 100755
>--- a/cataloguing/value_builder/unimarc_field_4XX.pl
>+++ b/cataloguing/value_builder/unimarc_field_4XX.pl
>@@ -378,7 +378,15 @@ sub plugin {
>            )
>          {
>             my $record = C4::Search::new_record_from_zebra( 'biblioserver', $results->[$i] );
>+            next unless $record;
>             my $rechash = TransformMarcToKoha( $dbh, $record );
>+            if ( my $f = $record->field('200') ) {
>+                $rechash->{fulltitle} =
>+                    join(', ', map { $_->[1] } grep { $_->[0] =~ /[aehi]/ } $f->subfields() );
>+            }
>+            else {
>+                $rechash->{fulltitle} = $rechash->{title};
>+            }
>             my $pos;
>             my $countitems;
>             if ( $rechash->{itemnumber} ) {
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt
>index 66d5223..7c03a31 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt
>@@ -167,15 +167,15 @@
>                                     [% IF ( resul.even ) %]<td class="hilighted">
>                                     [% ELSE %]<td>[% END %]
>                                                             [% IF ( resul.MARC_ON ) %]
>-                                                                    <a_class="transparent resultlist" href="/cgi-bin/koha/MARCdetail.pl?biblionumber=[% resul.biblionumber |uri %]">[% resul.title |html %]</a>
>+                                                                    <a class="transparent resultlist" href="/cgi-bin/koha/MARCdetail.pl?biblionumber=[% resul.biblionumber |url %]">[% resul.title |html %]</a>
>                                                             [% ELSE %]
>-                                                                    <a_class="transparent resultlist" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% resul.biblionumber |uri %]">[% resul.title |html %]</a>   [% END %]
>-                                                    <p>[% resul.author |html %]
>-                                                    [% IF ( resul.publishercode ) %]- [% resul.publishercode |html %][% END %]
>-                                                    [% IF ( resul.place ) %] ; [% resul.place |html %][% END %]
>-                                                    [% IF ( resul.pages ) %] - [% resul.pages |html %][% END %]
>-                                                    [% IF ( resul.notes ) %] : [% resul.notes |html %][% END %]
>-                                                    [% IF ( resul.item('size') ) %] ; [% resul.item('size') |html %][% END %]
>+                                                                    <a class="transparent resultlist" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% resul.biblionumber |url %]">[% resul.fulltitle |html %]</a>[% END %]
>+                                                    <p>[% resul.author %]
>+                                                    [% IF ( resul.publishercode ) %]- [% resul.publishercode %][% END %]
>+                                                    [% IF ( resul.place ) %] ; [% resul.place %][% END %]
>+                                                    [% IF ( resul.pages ) %] - [% resul.pages %][% END %]
>+                                                    [% IF ( resul.notes ) %] : [% resul.notes %][% END %]
>+                                                    [% IF ( resul.size ) %] ; [% resul.size %][% END %]
>                                             </p>
> 					</td>
>                     [% IF ( resul.even ) %]<td align="center" class="hilighted">
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 13904: 37212 | 39241 | 39539 | 39772 | 40269 | 40313