Bugzilla – Attachment 39782 Details for
Bug 13219
Add graphs to guided reports
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13219: (followup) remove tabs and console messages
Bug-13219-followup-remove-tabs-and-console-message.patch (text/plain), 3.68 KB, created by
Bernardo Gonzalez Kriegel
on 2015-06-02 17:07:49 UTC
(
hide
)
Description:
Bug 13219: (followup) remove tabs and console messages
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2015-06-02 17:07:49 UTC
Size:
3.68 KB
patch
obsolete
>From 54e23a612bcf2e100d6c4247831628b49883332a Mon Sep 17 00:00:00 2001 >From: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Date: Tue, 2 Jun 2015 12:21:01 -0300 >Subject: [PATCH] Bug 13219: (followup) remove tabs and console messages > >To make koha-qa happy > >Tested, nice graphics. >Nice feature to play with :) >--- > .../prog/en/modules/reports/catalogue_stats.tt | 6 ++---- > .../prog/en/modules/reports/issues_stats.tt | 2 -- > reports/catalogue_stats.pl | 2 +- > reports/issues_stats.pl | 2 +- > 4 files changed, 4 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt >index ca72d92..b2ab248 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt >@@ -52,9 +52,9 @@ > [% IF ( do_it ) %] > [% FOREACH mainloo IN mainloop %] > <h1>Catalog statistics</h1> >- <canvas id="catChart" width="1000" height="400"></canvas> >+ <canvas id="catChart" width="1000" height="400"></canvas> > <div id="toolbar" class="btn-toolbar"><div class="btn-group"><a id="updateChart" class="btn" href="#">Click to change to <span id="chartType">Line</span> Chart</a></div></div> >- [% IF ( mainloo.loopfilter ) %] >+ [% IF ( mainloo.loopfilter ) %] > <p>Filtered on:</p> > [% FOREACH loopfilte IN mainloo.loopfilter %] > <p>[% loopfilte.crit %] =[% loopfilte.filter %]</p> >@@ -298,8 +298,6 @@ > var catChart = new Chart(ctx).Bar( chartData, {}); > > $("#updateChart").click(function() { >- console.log("Updating Chart: "); >- > // Replace the chart canvas element > $('#catChart').replaceWith('<canvas id="catChart" width="1000" height="400"></canvas>'); > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >index c5428f6..4a70675 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >@@ -320,8 +320,6 @@ > var circChart = new Chart(ctx).Bar( chartData, {}); > > $("#updateChart").click(function() { >- console.log("Updating Chart: "); >- > // Replace the chart canvas element > $('#circChart').replaceWith('<canvas id="circChart" width="1000" height="400"></canvas>'); > >diff --git a/reports/catalogue_stats.pl b/reports/catalogue_stats.pl >index fe1c1e1..5dd6d9d 100755 >--- a/reports/catalogue_stats.pl >+++ b/reports/catalogue_stats.pl >@@ -507,7 +507,7 @@ if($barcodefilter){ > push @looprow,{ 'rowtitle' => ($row eq "zzEMPTY")?"NULL":$row, > 'loopcell' => \@loopcell, > 'hilighted' => ($hilighted *= -1 > 0), >- 'totalrow' => $table{$row}->{totalrow}, >+ 'totalrow' => $table{$row}->{totalrow}, > 'fill' => ${$colors}[$loopcount]->{fill}, > 'stroke' => ${$colors}[$loopcount]->{stroke}, > 'point' => ${$colors}[$loopcount]->{point}, >diff --git a/reports/issues_stats.pl b/reports/issues_stats.pl >index 42e81b7..03d8757 100755 >--- a/reports/issues_stats.pl >+++ b/reports/issues_stats.pl >@@ -486,7 +486,7 @@ sub calculate { > 'rowtitle_display' => $row->{rowtitle_display}, > 'rowtitle' => $rowtitle, > 'loopcell' => \@loopcell, >- 'totalrow' => $table{$rowtitle}->{totalrow}, >+ 'totalrow' => $table{$rowtitle}->{totalrow}, > 'fill' => ${$colors}[$loopcount]->{fill}, > 'stroke' => ${$colors}[$loopcount]->{stroke}, > 'point' => ${$colors}[$loopcount]->{point}, >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13219
:
33368
|
33369
|
33370
|
33371
|
33372
|
39777
|
39778
|
39779
|
39780
|
39781
| 39782