Attachment 39809 Details for Bug 14142 – Bug 14142 - Holds queue viewer only displays first subtitle from marc keyword mappings

[patch] Bug 14142 - Holds queue viewer only displays first subtitle from marc keyword mappings

Bug-14142---Holds-queue-viewer-only-displays-first.patch (text/plain), 2.73 KB, created by Melissa Lefebvre on 2015-06-03 15:24:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Melissa Lefebvre

Created: 2015-06-03 15:24:12 UTC

Size: 2.73 KB

patch

obsolete

>From dab9af222032ca50a192019299153ba105dc78cc Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 4 May 2015 12:50:28 -0400
>Subject: [PATCH] Bug 14142 - Holds queue viewer only displays first subtitle from marc keyword mappings
>
>Despite the point of the Keyword to MARC Mappings being to simplify the
>handling and display of repeated values from multiple subfields, the
>holds queue viewer will only display the first value found. What it
>should be doing instead is displaying all fields that match the subtitle
>keyword.
>
>Test Plan:
>1) Apply this patch
>2) Define multiple Keyword to MARC mappings for the subtitle keyword
>3) Place a hold on a record using those subtitle fields
>4) View the hold in the holds queue viewer
>5) Note that all the subtitles now appear
>
>Signed-off-by:Heather Braum <hbraum@nekls.org>
>
>---
> C4/HoldsQueue.pm                                   |    2 +-
> .../prog/en/modules/circ/view_holdsqueue.tt        |    2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm
>index 4e7f3e0..653b065 100755
>--- a/C4/HoldsQueue.pm
>+++ b/C4/HoldsQueue.pm
>@@ -137,7 +137,7 @@ sub GetHoldsQueueItems {
>     while ( my $row = $sth->fetchrow_hashref ){
>         my $record = GetMarcBiblio($row->{biblionumber});
>         if ($record){
>-            $row->{subtitle} = GetRecordValue('subtitle',$record,'')->[0]->{subfield};
>+            $row->{subtitle} = [ map { $_->{subfield} } @{ GetRecordValue( 'subtitle', $record, '' ) } ];
>             $row->{parts} = GetRecordValue('parts',$record,'')->[0]->{subfield};
>             $row->{numbers} = GetRecordValue('numbers',$record,'')->[0]->{subfield};
>         }
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>index 549a91a..e419bcd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>@@ -68,7 +68,7 @@ $(document).ready(function() {
>      <tbody>[% FOREACH itemsloo IN itemsloop %]
>         <tr>
>             <td class="hq-title">
>-                <p><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% itemsloo.biblionumber %]"><strong>[% itemsloo.title | html %]</strong> [% IF ( itemsloo.subtitle ) %][% itemsloo.subtitle %][% END %]</a></p>
>+                <p><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% itemsloo.biblionumber %]"><strong>[% itemsloo.title | html %]</strong> [% FOREACH s IN itemsloo.subtitle %] [% s %][% END %]</a></p>
>                 <p>
>                     <div class="hq-biblionumber content_hidden">[% itemsloo.biblionumber %]</div>
>                     <div class="hq-author">[% itemsloo.author %]</div>
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 14142: 38825 | 39809 | 39845