Attachment 39844 Details for Bug 14330 – Bug 14330: Remove unused email_sender from sendbasket/sendshelf

[patch] Bug 14330: Remove unused email_sender from sendbasket/sendshelf

Bug-14330-Remove-unused-emailsender-from-sendbaske.patch (text/plain), 2.89 KB, created by Marcel de Rooy on 2015-06-04 10:50:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2015-06-04 10:50:03 UTC

Size: 2.89 KB

patch

obsolete

>From 918ea10b6706283b482eade6fdf4ce2e8272e593 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 4 Jun 2015 12:47:13 +0200
>Subject: [PATCH] Bug 14330: Remove unused email_sender from
> sendbasket/sendshelf
>Content-Type: text/plain; charset=utf-8
>
>The sendbasket/sendshelf scripts and templates do not use email_sender
>as a cgi parameter or as a template var. Probably a leftover from previous
>changes.
>Let's make Koha cleaner :)
>
>Test plan:
>[1] Send your cart from opac or staff.
>[2] Send a shelf from opac or staff.
>[3] Git grep email_sender. No results.
>---
> basket/sendbasket.pl        |    2 --
> opac/opac-sendbasket.pl     |    2 --
> opac/opac-sendshelf.pl      |    1 -
> virtualshelves/sendshelf.pl |    1 -
> 4 files changed, 6 deletions(-)
>
>diff --git a/basket/sendbasket.pl b/basket/sendbasket.pl
>index 71516a4..673842e 100755
>--- a/basket/sendbasket.pl
>+++ b/basket/sendbasket.pl
>@@ -46,7 +46,6 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user (
> 
> my $bib_list     = $query->param('bib_list');
> my $email_add    = $query->param('email_add');
>-my $email_sender = $query->param('email_sender');
> 
> my $dbh          = C4::Context->dbh;
> 
>@@ -101,7 +100,6 @@ if ( $email_add ) {
>     my $resultsarray = \@results;
>     $template2->param(
>         BIBLIO_RESULTS => $resultsarray,
>-        email_sender   => $email_sender,
>         comment        => $comment
>     );
> 
>diff --git a/opac/opac-sendbasket.pl b/opac/opac-sendbasket.pl
>index a451866..e035326 100755
>--- a/opac/opac-sendbasket.pl
>+++ b/opac/opac-sendbasket.pl
>@@ -49,7 +49,6 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user (
> 
> my $bib_list     = $query->param('bib_list');
> my $email_add    = $query->param('email_add');
>-my $email_sender = $query->param('email_sender');
> 
> my $dbh          = C4::Context->dbh;
> 
>@@ -117,7 +116,6 @@ if ( $email_add ) {
>     
>     $template2->param(
>         BIBLIO_RESULTS => $resultsarray,
>-        email_sender   => $email_sender,
>         comment        => $comment,
>         firstname      => $user->{firstname},
>         surname        => $user->{surname},
>diff --git a/opac/opac-sendshelf.pl b/opac/opac-sendshelf.pl
>index ed9858b..ae3d6af 100755
>--- a/opac/opac-sendshelf.pl
>+++ b/opac/opac-sendshelf.pl
>@@ -111,7 +111,6 @@ if ( $email ) {
> 
>     $template2->param(
>         BIBLIO_RESULTS => \@results,
>-        email_sender   => $mail{'from'},
>         comment        => $comment,
>         shelfname      => $shelf[1],
>         firstname      => $user->{firstname},
>diff --git a/virtualshelves/sendshelf.pl b/virtualshelves/sendshelf.pl
>index 3696ba1..17a7ae7 100755
>--- a/virtualshelves/sendshelf.pl
>+++ b/virtualshelves/sendshelf.pl
>@@ -108,7 +108,6 @@ if ($email) {
> 
>     $template2->param(
>         BIBLIO_RESULTS => \@results,
>-        email_sender   => $mail{'from'},
>         comment        => $comment,
>         shelfname      => $shelf[1],
>     );
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 14330: 39844 | 39867 | 39941