Bugzilla – Attachment 39869 Details for
Bug 14029
Provide link to clear reports search filters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed-off] Bug 14029: Provide 'clear' link to empty reports search filters
Signed-off-Bug-14029-Provide-clear-link-to-empty-r.patch (text/plain), 2.29 KB, created by
Marc Véron
on 2015-06-04 14:37:41 UTC
(
hide
)
Description:
[Signed-off] Bug 14029: Provide 'clear' link to empty reports search filters
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2015-06-04 14:37:41 UTC
Size:
2.29 KB
patch
obsolete
>From c6b2165623655f5a5c1a2a1ab1e69a6d3b893b88 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@koha-community.org> >Date: Thu, 4 Jun 2015 16:28:08 +0200 >Subject: [PATCH] [Signed-off] Bug 14029: Provide 'clear' link to empty > reports search filters >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Patch adds a 'clear' link next to the 'Apply filters' button to >empty out the form fields. > >To test: >- go to the reports module >- make sure you have some saved reports >- search your saved reports using the author, keyword and date filters >- verify searching works as expected >- verify the new 'clear' link works as expected > >Tested couner patch, followed test plan, works as expected. QA tools ok. >Signed-off-by: Marc Véron <veron@veron.ch> >--- > .../intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt | 5 ++++- > reports/guided_reports.pl | 2 +- > 2 files changed, 5 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index e769af2..283a1cf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -1045,7 +1045,10 @@ Sub report:<select name="subreport"> > <li><label for="filter_keyword">Keyword:</label> <input type="text" id="filter_keyword" name="filter_keyword" value="[% filters.keyword %]" /></li> > </ol> > </fieldset> >- <fieldset class="action"><input type="submit" value="Apply filter" /></fieldset> >+ <fieldset class="action"> >+ <input type="submit" value="Apply filter" /> >+ <a id="resetReportsFilter" href="?phase=Use saved&clear_filters=1">Clear</a> >+ </fieldset> > </form> > </div> > [% END %] >diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl >index 0fb773f..9cfa8ce 100755 >--- a/reports/guided_reports.pl >+++ b/reports/guided_reports.pl >@@ -77,7 +77,7 @@ if ( $input->param("filter_set") ) { > $session->param('report_filter', $filter) if $session; > $template->param( 'filter_set' => 1 ); > } >-elsif ($session) { >+elsif ($session and not $input->param('clear_filters')) { > $filter = $session->param('report_filter'); > } > >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14029
:
39474
|
39708
|
39736
|
39856
|
39866
|
39868
|
39869
|
39933