Attachment 39880 Details for Bug 14334 – Bug 14334: t/db_dependent/Borrower.t AutoCommit fix

[patch] Bug 14334: t/db_dependent/Borrower.t AutoCommit fix

Bug-14334-tdbdependentBorrowert-AutoCommit-fix.patch (text/plain), 1.36 KB, created by Mark Tompsett on 2015-06-05 04:36:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2015-06-05 04:36:28 UTC

Size: 1.36 KB

patch

obsolete

>From 15c6b69063c12c9a6a6e54b4f32cc7c6c1119128 Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Fri, 5 Jun 2015 00:22:10 -0400
>Subject: [PATCH] Bug 14334: t/db_dependent/Borrower.t AutoCommit fix
>
>There is no easy way to trigger an obvious problem.
>
>TEST PLAN
>---------
>1) apply patch
>2) git diff origin/master
>   -- Are the additions/subtractions similar to
>      http://paste.lisp.org/display/149194?
>   -- I added explicit rollback, since I do not know the
>      default behaviour of DBIx.
>3) run koha qa test tools
>---
> t/db_dependent/Borrower.t | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Borrower.t b/t/db_dependent/Borrower.t
>index 8290cab..a17891d 100755
>--- a/t/db_dependent/Borrower.t
>+++ b/t/db_dependent/Borrower.t
>@@ -30,7 +30,9 @@ BEGIN {
> 
> # Start transaction
> my $dbh = C4::Context->dbh;
>-$dbh->{AutoCommit} = 0;
>+my $database = Koha::Database->new();
>+my $schema = $database->schema();
>+$schema->storage->txn_begin();
> $dbh->{RaiseError} = 1;
> 
> my $categorycode = Koha::Database->new()->schema()->resultset('Category')->first()->categorycode();
>@@ -71,4 +73,5 @@ $borrower = Koha::Database->new()->schema()->resultset('Borrower')->find( $borro
> ok( ! $borrower, "Object no longer found in database" );
> is( $object->in_storage, 0, "Object is not in storage" );
> 
>+$schema->storage->txn_rollback();
> 1;
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 14334: 39871 | 39872 | 39873 | 39874 | 39875 | 39876 | 39877 | 39879 | 39880 | 39881 | 39882 | 39883 | 39884 | 39885 | 40080 | 40086 | 40184 | 82989 | 83129 | 83201