Bugzilla – Attachment 39885 Details for
Bug 14334
DBI fighting DBIx over Autocommit in tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14334: t/db_dependent/Branch.t AutoCommit fix
Bug-14334-tdbdependentBrancht-AutoCommit-fix.patch (text/plain), 1.27 KB, created by
Mark Tompsett
on 2015-06-05 05:16:15 UTC
(
hide
)
Description:
Bug 14334: t/db_dependent/Branch.t AutoCommit fix
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2015-06-05 05:16:15 UTC
Size:
1.27 KB
patch
obsolete
>From ce244980c3ce1a556a41e65cc723b4882019ed56 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Fri, 5 Jun 2015 01:14:34 -0400 >Subject: [PATCH] Bug 14334: t/db_dependent/Branch.t AutoCommit fix > >There is no easy way to trigger an obvious problem. > >TEST PLAN >--------- >1) apply patch >2) git diff origin/master > -- Are the additions/subtractions similar to > http://paste.lisp.org/display/149194? >3) run koha qa test tools >--- > t/db_dependent/Branch.t | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Branch.t b/t/db_dependent/Branch.t >index 9ca3f56..3959f17 100644 >--- a/t/db_dependent/Branch.t >+++ b/t/db_dependent/Branch.t >@@ -24,6 +24,7 @@ use Data::Dumper; > use Test::More tests => 36; > > use C4::Branch; >+use Koha::Database; > > BEGIN { > use FindBin; >@@ -56,7 +57,9 @@ can_ok( > > # Start transaction > my $dbh = C4::Context->dbh; >-$dbh->{AutoCommit} = 0; >+my $database = Koha::Database->new(); >+my $schema = $database->schema(); >+$schema->storage->txn_begin(); > $dbh->{RaiseError} = 1; > > # clear the slate >@@ -356,5 +359,5 @@ my $loop = GetBranchesLoop; > is( scalar(@$loop), GetBranchesCount(), 'There is the right number of branches' ); > > # End transaction >-$dbh->rollback; >+$schema->storage->txn_rollback(); > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14334
:
39871
|
39872
|
39873
|
39874
|
39875
|
39876
|
39877
|
39879
|
39880
|
39881
|
39882
|
39883
|
39884
|
39885
|
40080
|
40086
|
40184
|
82989
|
83129
|
83201