Bugzilla – Attachment 39890 Details for
Bug 14167
Add Koha::Logger based on Log4perl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14167 - [DO_NOT_PUSH] Renewal example patch for logging
Bug-14167---DONOTPUSH-Renewal-example-patch-for-lo.patch (text/plain), 2.00 KB, created by
Marcel de Rooy
on 2015-06-05 07:55:18 UTC
(
hide
)
Description:
Bug 14167 - [DO_NOT_PUSH] Renewal example patch for logging
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2015-06-05 07:55:18 UTC
Size:
2.00 KB
patch
obsolete
>From b826e50abe90be463dc6b3b649e50a399112ab3c Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 7 May 2015 11:20:50 -0400 >Subject: [PATCH] Bug 14167 - [DO_NOT_PUSH] Renewal example patch for logging >Content-Type: text/plain; charset=utf-8 > >This patch adds logging to the renewal process to test the first patch. >Note to RM: Do not push this patch. > >Test plan: >See the first patch. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Circulation.pm | 8 +++++++- > svc/renew | 2 ++ > 2 files changed, 9 insertions(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index f991680..8edc4f9 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -50,6 +50,7 @@ use Koha::DateUtils; > use Koha::Calendar; > use Koha::Borrower::Debarments; > use Koha::Database; >+use Koha::Logger; > use Carp; > use List::MoreUtils qw( uniq ); > use Date::Calc qw( >@@ -2787,6 +2788,9 @@ sub AddRenewal { > my $datedue = shift; > my $lastreneweddate = shift || DateTime->now(time_zone => C4::Context->tz)->ymd(); > >+ my $logger = Koha::Logger->get("C4::Circulation::AddRenewal"); >+ $logger->trace( "PARAMS: " . Dumper( { borrowernumber => $borrowernumber, itemnumber => $itemnumber, branch => $branch, datedue => $datedue, lastreneweddate => $lastreneweddate } ) ); >+ > my $item = GetItem($itemnumber) or return; > my $biblio = GetBiblioFromItemNumber($itemnumber) or return; > >@@ -2892,7 +2896,9 @@ sub AddRenewal { > borrowernumber => $borrowernumber, > ccode => $item->{'ccode'}} > ); >- return $datedue; >+ >+ $logger->trace("RETURNING $datedue"); >+ return $datedue; > } > > sub GetRenewCount { >diff --git a/svc/renew b/svc/renew >index fa8475a..7c88f31 100755 >--- a/svc/renew >+++ b/svc/renew >@@ -28,6 +28,8 @@ use C4::Auth qw(check_cookie_auth); > > use Koha::DateUtils qw(output_pref dt_from_string); > >+C4::Context->interface('intranet'); >+ > my $input = new CGI; > > my ( $auth_status, $sessionID ) = >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14167
:
38953
|
38954
|
38980
|
38981
|
38993
|
39103
|
39180
|
39886
|
39887
|
39888
|
39889
|
39890
|
39891
|
39892
|
39893
|
39894
|
39895
|
40200
|
40652
|
40653
|
40657
|
40658
|
40659
|
40660
|
40661
|
40662
|
40663
|
40664
|
41109
|
41111
|
41145
|
41146