Bugzilla – Attachment 39919 Details for
Bug 12769
Manage fees for sending notices
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12769 - Follow up to comments 14 & 15
Bug-12769---Follow-up-to-comments-14--15.patch (text/plain), 1.46 KB, created by
Maxime Beaulieu
on 2015-06-05 18:29:12 UTC
(
hide
)
Description:
Bug 12769 - Follow up to comments 14 & 15
Filename:
MIME Type:
Creator:
Maxime Beaulieu
Created:
2015-06-05 18:29:12 UTC
Size:
1.46 KB
patch
obsolete
>From ae768a976203f1cdba0338da7115cd66d546c77e Mon Sep 17 00:00:00 2001 >From: mxbeaulieu <maxime.beaulieu@inlibro.com> >Date: Fri, 5 Jun 2015 14:27:10 -0400 >Subject: [PATCH] Bug 12769 - Follow up to comments 14 & 15 > >Removed useless change in previous patch >--- > misc/cronjobs/advance_notices.pl | 2 +- > misc/cronjobs/overdue_notices.pl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl >index 950bad0..c3e9c7e 100755 >--- a/misc/cronjobs/advance_notices.pl >+++ b/misc/cronjobs/advance_notices.pl >@@ -526,7 +526,7 @@ sub noticefine { > $sendfee = C4::Context->preference('DefaultNoticeFee'); > } > >- if ($sendfee > 0){ >+ if (defined($sendfee) && $sendfee > 0){ > C4::Accounts::manualinvoice($borrowernumber, "", "", "F", $sendfee, C4::Context->preference('NoticeFeeNote')); > } > } >diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl >index 5dc437c..e381598 100755 >--- a/misc/cronjobs/overdue_notices.pl >+++ b/misc/cronjobs/overdue_notices.pl >@@ -600,7 +600,7 @@ END_SQL > $sendfee = C4::Context->preference('DefaultNoticeFee'); > } > >- if ($sendfee > 0){ >+ if (defined($sendfee) && $sendfee > 0){ > C4::Accounts::manualinvoice($borrowernumber, "", "", "F", $sendfee, C4::Context->preference('NoticeFeeNote')); > } > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12769
:
34335
|
36318
|
36351
|
36504
|
39900
|
39918
|
39919
|
40081
|
40082