Attachment 39941 Details for Bug 14330 – [PASSED QA] Bug 14330: Remove unused email_sender from sendbasket/sendshelf

[patch] [PASSED QA] Bug 14330: Remove unused email_sender from sendbasket/sendshelf

PASSED-QA-Bug-14330-Remove-unused-emailsender-from.patch (text/plain), 3.07 KB, created by Katrin Fischer on 2015-06-06 16:46:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-06-06 16:46:07 UTC

Size: 3.07 KB

patch

obsolete

>From 156aebaa4cc2936c0503ccec2a844a373191a06b Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 4 Jun 2015 12:47:13 +0200
>Subject: [PATCH] [PASSED QA] Bug 14330: Remove unused email_sender from
> sendbasket/sendshelf
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>The sendbasket/sendshelf scripts and templates do not use email_sender
>as a cgi parameter or as a template var. Probably a leftover from previous
>changes.
>Let's make Koha cleaner :)
>
>Test plan:
>[1] Send your cart from opac or staff.
>[2] Send a shelf from opac or staff.
>[3] Git grep email_sender. No results.
>
>Followed test plan. Works as expected.
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> basket/sendbasket.pl        | 2 --
> opac/opac-sendbasket.pl     | 2 --
> opac/opac-sendshelf.pl      | 1 -
> virtualshelves/sendshelf.pl | 1 -
> 4 files changed, 6 deletions(-)
>
>diff --git a/basket/sendbasket.pl b/basket/sendbasket.pl
>index 1dd7661..83dab55 100755
>--- a/basket/sendbasket.pl
>+++ b/basket/sendbasket.pl
>@@ -46,7 +46,6 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user (
> 
> my $bib_list     = $query->param('bib_list');
> my $email_add    = $query->param('email_add');
>-my $email_sender = $query->param('email_sender');
> 
> my $dbh          = C4::Context->dbh;
> 
>@@ -101,7 +100,6 @@ if ( $email_add ) {
>     my $resultsarray = \@results;
>     $template2->param(
>         BIBLIO_RESULTS => $resultsarray,
>-        email_sender   => $email_sender,
>         comment        => $comment
>     );
> 
>diff --git a/opac/opac-sendbasket.pl b/opac/opac-sendbasket.pl
>index 82e7d76..6b2d62f 100755
>--- a/opac/opac-sendbasket.pl
>+++ b/opac/opac-sendbasket.pl
>@@ -48,7 +48,6 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user (
> 
> my $bib_list     = $query->param('bib_list');
> my $email_add    = $query->param('email_add');
>-my $email_sender = $query->param('email_sender');
> 
> my $dbh          = C4::Context->dbh;
> 
>@@ -115,7 +114,6 @@ if ( $email_add ) {
>     
>     $template2->param(
>         BIBLIO_RESULTS => $resultsarray,
>-        email_sender   => $email_sender,
>         comment        => $comment,
>         firstname      => $user->{firstname},
>         surname        => $user->{surname},
>diff --git a/opac/opac-sendshelf.pl b/opac/opac-sendshelf.pl
>index f6ce844..8512c65 100755
>--- a/opac/opac-sendshelf.pl
>+++ b/opac/opac-sendshelf.pl
>@@ -109,7 +109,6 @@ if ( $email ) {
> 
>     $template2->param(
>         BIBLIO_RESULTS => \@results,
>-        email_sender   => $mail{'from'},
>         comment        => $comment,
>         shelfname      => $shelf[1],
>         firstname      => $user->{firstname},
>diff --git a/virtualshelves/sendshelf.pl b/virtualshelves/sendshelf.pl
>index b2941e3..16e2ff6 100755
>--- a/virtualshelves/sendshelf.pl
>+++ b/virtualshelves/sendshelf.pl
>@@ -103,7 +103,6 @@ if ($email) {
> 
>     $template2->param(
>         BIBLIO_RESULTS => \@results,
>-        email_sender   => $mail{'from'},
>         comment        => $comment,
>         shelfname      => $shelf[1],
>     );
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14330: 39844 | 39867 | 39941