Bugzilla – Attachment 40067 Details for
Bug 14360
XSS Injection point
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 14360: Unescaped variable causes alert pop-up
PASSED-QA-Bug-14360-Unescaped-variable-causes-aler.patch (text/plain), 2.09 KB, created by
Kyle M Hall (khall)
on 2015-06-10 13:16:21 UTC
(
hide
)
Description:
[PASSED QA] Bug 14360: Unescaped variable causes alert pop-up
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2015-06-10 13:16:21 UTC
Size:
2.09 KB
patch
obsolete
>From 63953ccb78ce2ea1fd7a207af6ebbe6a607da55e Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Tue, 9 Jun 2015 02:02:55 +0000 >Subject: [PATCH] [PASSED QA] Bug 14360: Unescaped variable causes alert pop-up > >To test: > >1) Create a list in the OPAC, name it: <script>alert('Hello');</script> >2) Delete the list >3) Confirm deletion >4) See the alert say 'Hello' >5) Apply patch >6) Recreate list with same name >7) Delete list >8) Confirm deletion and alert no longer pops up > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >index e6b4ab5..eb2c143 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >@@ -130,10 +130,10 @@ > <div class="alert">A record matching barcode <b>[% paramsloo.duplicatebiblio %]</b> has already been added.</div> > [% END %] > [% IF ( paramsloo.delete_ok ) %] >- <div class="alert alert-info">List [% paramsloo.delete_ok %] Deleted.</div> >+ <div class="alert alert-info">List [% paramsloo.delete_ok |html %] Deleted.</div> > [% END %] > [% IF ( paramsloo.delete_fail ) %] >- <div class="alert alert-info">ERROR: Database error. Delete (list number [% paramsloo.delete_fail %]) failed.</div> >+ <div class="alert alert-info">ERROR: Database error. Delete (list number [% paramsloo.delete_fail |html %]) failed.</div> > [% END %] > [% IF ( paramsloo.unrecognized ) %] > <div class="alert alert-info">ERROR: List number [% paramsloo.unrecognized %] unrecognized.</div> >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14360
:
39981
|
40009
|
40045
|
40046
|
40066
| 40067