Attachment 40105 Details for Bug 14345 – Bug 14345: broken isbn logic prevents display of idreambooks image

[patch] Bug 14345: broken isbn logic prevents display of idreambooks image

Bug-14345-broken-isbn-logic-prevents-display-of-id.patch (text/plain), 1.70 KB, created by Nick Clemens (kidclamp) on 2015-06-12 19:20:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2015-06-12 19:20:29 UTC

Size: 1.70 KB

patch

obsolete

>From 5cdedcdb782ab555f994f251b690095474932ab8 Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Fri, 5 Jun 2015 12:24:22 -0400
>Subject: [PATCH] Bug 14345: broken isbn logic prevents display of idreambooks
> image
>
>TEST PLAN
>---------
>1) Ensure you have a book that would pull up an idreambooks image
>   (e.g. The road to character / David Brooks.)
>2) Ensure your system preferences for idreambook stuff is set.
>3) Search for that book in OPAC and go to details.
>   -- There should be a readometer image, but it will be broken.
>4) Apply this patch
>5) Refresh page
>   -- readometer image appears. YAY!
>6) run koha qa test tools
>
>Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index 840f6ec..2e08e10 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -1632,7 +1632,7 @@
>         function parseIDBJSON( json ) {
>             if(json.total_results > 0 && json.book.rating > 0){
>                 var isbn = $(".isbn:last").text().split(" ")[1];
>-                isbn = isbn.replace(/-/, '');
>+                isbn = isbn.replace(/\W+/g, '');
> 
>                 [% IF ( IDreamBooksReadometer ) %]
>                     $(".title").append('<a href="'+json.book.detail_link+'" id="idreambooksreadometer"><img src="https://idreambooks.com/remotereadometer/'+isbn+'.jpg" alt="'+json.book.title+' by '+json.book.author+'" title="Rating based on reviews of '+json.book.title+'"></a>');
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14345: 39913 | 40105 | 40598 | 40760