Attachment 40124 Details for Bug 13663 – (followup) fixes tab char QA test fails

[patch] (followup) fixes tab char QA test fails

followup-fixes-tab-char-QA-test-fails.patch (text/plain), 2.81 KB, created by Indranil Das Gupta on 2015-06-14 09:24:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Indranil Das Gupta

Created: 2015-06-14 09:24:32 UTC

Size: 2.81 KB

patch

obsolete

>From a226e13d23d635e7cbaaa37c5f929ffb0153f3b7 Mon Sep 17 00:00:00 2001
>From: Indranil Das Gupta <indradg@gmail.com>
>Date: Sun, 14 Jun 2015 14:52:04 +0530
>Subject: [PATCH] (followup) fixes tab char QA test fails
>
>Fixes the tab char qa test suite fails in the following files:
>
>1/ tools/upload-file-progress.pl
>2/ tools/upload-file.pl
>
>http://bugs.koha-community.org/show_bug.cgi?id=13663
>---
> tools/upload-file-progress.pl | 12 ++++++------
> tools/upload-file.pl          | 12 ++++++------
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
>diff --git a/tools/upload-file-progress.pl b/tools/upload-file-progress.pl
>index 3f7d2cd..14d8327 100755
>--- a/tools/upload-file-progress.pl
>+++ b/tools/upload-file-progress.pl
>@@ -31,9 +31,9 @@ use CGI::Cookie; # need to check cookies before
>                  # having CGI parse the POST request
> 
> my $flags_required = [
>-		{circulate => 'circulate_remaining_permissions'},
>-		{tools => 'stage_marc_import'},
>-		{tools => 'upload_local_cover_images'}
>+                 {circulate => 'circulate_remaining_permissions'},
>+                 {tools => 'stage_marc_import'},
>+                 {tools => 'upload_local_cover_images'}
> ];
> 
> my %cookies = fetch CGI::Cookie;
>@@ -42,9 +42,9 @@ my ($auth_status, $sessionID) = check_cookie_auth($cookies{'CGISESSID'}->value);
> 
> my $auth_failure = 1;
> foreach my $flag_required (@{ $flags_required}) {
>-		if (my $flags = haspermission(C4::Context->config('user'), $flag_required)) {
>-				$auth_failure = 0 if $auth_status eq 'ok';
>-		}
>+                if (my $flags = haspermission(C4::Context->config('user'), $flag_required)) {
>+                                $auth_failure = 0 if $auth_status eq 'ok';
>+                }
> }
> 
> if ($auth_failure) {
>diff --git a/tools/upload-file.pl b/tools/upload-file.pl
>index 2dd66f0..c2ec514 100755
>--- a/tools/upload-file.pl
>+++ b/tools/upload-file.pl
>@@ -39,9 +39,9 @@ use C4::UploadedFile;
> # have been created.
> 
> my $flags_required = [
>-		{circulate => 'circulate_remaining_permissions'},
>-		{tools => 'stage_marc_import'},
>-		{tools => 'upload_local_cover_images'}
>+                {circulate => 'circulate_remaining_permissions'},
>+                {tools => 'stage_marc_import'},
>+                {tools => 'upload_local_cover_images'}
> ];
> 
> my %cookies = fetch CGI::Cookie;
>@@ -49,9 +49,9 @@ my %cookies = fetch CGI::Cookie;
> my $auth_failure = 1;
> my ($auth_status, $sessionID) = check_cookie_auth($cookies{'CGISESSID'}->value);
> foreach my $flag_required (@{ $flags_required}) {
>-		if (my $flags = haspermission(C4::Context->config('user'), $flag_required)) {
>-				$auth_failure = 0 if $auth_status eq 'ok';
>-		}
>+                if (my $flags = haspermission(C4::Context->config('user'), $flag_required)) {
>+                                $auth_failure = 0 if $auth_status eq 'ok';
>+                }
> }
> 
> if ($auth_failure) {
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 13663: 35661 | 35882 | 40089 | 40123 | 40124 | 41380 | 41381