Attachment 40156 Details for Bug 14389 – Bug 14389 - Editing a syspref in a textarea does not enable the Save button

[patch] Bug 14389 - Editing a syspref in a textarea does not enable the Save button

Bug-14389---Editing-a-syspref-in-a-textarea-does-n.patch (text/plain), 1.51 KB, created by Jesse Weaver on 2015-06-15 21:51:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jesse Weaver

Created: 2015-06-15 21:51:58 UTC

Size: 1.51 KB

patch

obsolete

>From fc66b884e8b6a9ff17a180a73d9ad847045787f2 Mon Sep 17 00:00:00 2001
>From: Jesse Weaver <pianohacker@gmail.com>
>Date: Mon, 15 Jun 2015 17:48:40 -0400
>Subject: [PATCH] Bug 14389 - Editing a syspref in a textarea does not enable
> the Save button
>
>Test plan:
>  1. Navigate to the "opaccredits" syspref (or any other textarea, i.e.,
>     "Click to Edit", syspref) in the system preferences editor.
>  2. Change its contents, by either pasting or typing. The field may not
>     be marked as modified, even after you click outside the box.
>  3. Apply the patch.
>  4. Reload the page and try again; either pasting or typing should mark
>     the field as changed and allow you to save.
>---
> koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js b/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js
>index 04135ef..fbcd132 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js
>+++ b/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js
>@@ -63,7 +63,7 @@ $( document ).ready( function () {
>     }
> 
>     $( '.prefs-tab' )
>-        .find( 'input.preference, textarea.preference' ).on('change', function () {
>+        .find( 'input.preference, textarea.preference' ).on('change keyup paste', function () {
>             if ( this.defaultValue === undefined || this.value != this.defaultValue ) mark_modified.call( this );
>         } ).end()
>         .find( 'select.preference' ).change( mark_modified );
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 14389: 40156 | 40182 | 40344 | 40345 | 40361 | 40772