Attachment 40191 Details for Bug 12352 – Bug 12352: Patron modification request page: Add link to patron record

[patch] Bug 12352: Patron modification request page: Add link to patron record

Bug-12352-Patron-modification-request-page-Add-lin.patch (text/plain), 3.20 KB, created by Jonathan Druart on 2015-06-16 15:56:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-06-16 15:56:22 UTC

Size: 3.20 KB

patch

obsolete

>From ed40c97118daf13687e9ad125595da02efb166c2 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <Katrin.Fischer.83@web.de>
>Date: Wed, 10 Jun 2015 01:43:22 +0200
>Subject: [PATCH] Bug 12352: Patron modification request page: Add link to
> patron record
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>The patron modification request page in the staff client does show
>the name and home library of a patron, but there is no way to
>go to the patron record. This patch adds a link to the patron details.
>
>Extras: changes display of patron name, so a missing firstname won't
>result in an extra , showing.
>
>To test:
>- Make some update requests from different patron accounts in the OPAC
>- Go to the patron modification request page in staff
>- Verify a link 'Patron details' now shows on each entry and
>  works correctly
>
>Followed test plan. Works as expected. QA tools OK.
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
>Not sure the "Patron details" link is at the best place, but I don't
>have something better to suggest.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt
>index 2a094dd..3cabd4d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt
>@@ -79,7 +79,7 @@
>                     <div id="pending_updates">
>                             [% FOREACH pm IN PendingModifications %]
>                                 [% SET borrowernumber = pm.borrowernumber %]
>-                                <h3><a href="#panel_modify_[% pm.borrowernumber %]">[% borrowers.$borrowernumber.surname %], [% borrowers.$borrowernumber.firstname %] ([% Branches.GetName( borrowers.$borrowernumber.branchcode ) %])</a></h3>
>+                                <h3><a href="#panel_modify_[% pm.borrowernumber %]">[% borrowers.$borrowernumber.surname %][% IF ( borrowers.$borrowernumber.firstname ) %], [% borrowers.$borrowernumber.firstname %][% END %] ([% Branches.GetName( borrowers.$borrowernumber.branchcode ) %])</a></h3>
>                                 <div id="panel_modify_[% pm.borrowernumber %]">
>                                     <div style="background-color:#E6F0F2;padding:.5em;margin:.3em 0;">
>                                         <input type="radio" id="approve_modify_[% pm.borrowernumber %]" name="modify_[% pm.borrowernumber %]" value="approve" />
>@@ -90,6 +90,7 @@
> 
>                                         <input type="radio" id="ignore_modify_[% pm.borrowernumber %]" name="modify_[% pm.borrowernumber %]" value="ignore" checked="checked"/>
>                                         <label for="ignore_modify_[% pm.borrowernumber %]">Ignore</label>
>+                                        | <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% pm.borrowernumber %]" >Patron details</a>
>                                     </div>
>                                         <table>
>                                             <tr>
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 12352: 40053 | 40059 | 40191