Attachment 40203 Details for Bug 14376 – (qa fix) fix tt_valid fail on 419

[patch] (qa fix) fix tt_valid fail on 419

qa-fix-fix-ttvalid-fail-on-419.patch (text/plain), 2.70 KB, created by Indranil Das Gupta on 2015-06-16 22:54:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Indranil Das Gupta

Created: 2015-06-16 22:54:43 UTC

Size: 2.70 KB

patch

obsolete

>From df47fd47d2c3753132ce2995df4729718f7b9833 Mon Sep 17 00:00:00 2001
>From: Indranil Das Gupta <indradg@gmail.com>
>Date: Wed, 17 Jun 2015 04:18:30 +0530
>Subject: [PATCH] (qa fix) fix tt_valid fail on 419
>
>Line 419 in attachment 40181 introduced TT code into <input>
>causing tt_valid qa tools fail. this patch fixes the issue.
>
>Test plan
>=========
>
>1/ run koha qa test tools (with the first patch applies)
>   it should fails on suggestion.tt
>
>   FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>   OK	  forbidden patterns
>   FAIL	  tt_valid
>		lines 419
>   OK	  valid_template
>
>2/ apply this qa fix patch
>
>3/ run koha qa tools again, this time the tt_valid test should clear
>
>   OK	koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>   OK	  forbidden patterns
>   OK	  tt_valid
>
>   OK	  valid_template
>
>http://bugs.koha-community.org/show_bug.cgi?id=14376
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>index 9e897a5..5c4ee11 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>@@ -416,7 +416,11 @@ h4.local_collapse a { font-size : 80%; text-decoration: none; } fieldset.brief o
>                 <td><input type="text" id="suggesteddate" name="suggesteddate" size="10" maxlength="10" value="[% suggesteddate | $KohaDates %]"/></td>
>                 <td>
>                   <div class="autocomplete">
>-                    <input autocomplete="on" id="findborrowersuggestion" name="findborrowersuggestion" size="40" class="focus" type="text" [% IF ( suggestedby_borrowernumber ) %] value="[% suggestedby_surname %], [% suggestedby_firstname %] [% Branches.GetName( suggestedby_branchcode ) %] ([% suggestedby_description %])" [% END %] />
>+                  [% IF ( suggestedby_borrowernumber ) %]
>+                      <input autocomplete="on" id="findborrowersuggestion" name="findborrowersuggestion" size="40" class="focus" type="text" value="[% suggestedby_surname %], [% suggestedby_firstname %] [% Branches.GetName( suggestedby_branchcode ) %] ([% suggestedby_description %])" />
>+                  [% ELSE %]
>+                      <input autocomplete="on" id="findborrowersuggestion" name="findborrowersuggestion" size="40" class="focus" type="text" value="" />
>+                  [% END %]
>                     <input name="branch" value="[% Branches.GetLoggedInBranchcode() %]" type="hidden" />
>                     <input name="printer" value="" type="hidden" />
>                   </div>
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 14376: 40095 | 40131 | 40181 | 40202 | 40203 | 40514