Attachment 40259 Details for Bug 14403 – Bug 14403 - Remove warn in Koha::NorwegianPatronDB

[patch] Bug 14403 - Remove warn in Koha::NorwegianPatronDB

Bug-14403---Remove-warn-in-KohaNorwegianPatronDB.patch (text/plain), 1.24 KB, created by Jonathan Druart on 2015-06-18 08:56:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-06-18 08:56:36 UTC

Size: 1.24 KB

patch

obsolete

>From 93b851222998adf9baadab10d8e5858918bf9dfa Mon Sep 17 00:00:00 2001
>From: Magnus Enger <magnus@libriotech.no>
>Date: Wed, 17 Jun 2015 14:36:44 +0200
>Subject: [PATCH] Bug 14403 - Remove warn in Koha::NorwegianPatronDB
>
>Line 99 has an unconditional warn, left over from development:
>
>warn "$combined_username => $combined_password";
>
>This patch deletes the line i question.
>
>To test:
>No testing needed, just have a look at the diff and see that
>it makes sense to delete the warn.
>
>Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
>---
> Koha/NorwegianPatronDB.pm | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/Koha/NorwegianPatronDB.pm b/Koha/NorwegianPatronDB.pm
>index 03afc21..585dfd2 100644
>--- a/Koha/NorwegianPatronDB.pm
>+++ b/Koha/NorwegianPatronDB.pm
>@@ -96,7 +96,6 @@ sub SOAP::Transport::HTTP::Client::get_basic_credentials {
>     # Combine usernames and passwords, and encrypt with SHA256
>     my $combined_username = "$vendor_username-$library_username";
>     my $combined_password = sha256_hex( "$library_password-$vendor_password" );
>-    warn "$combined_username => $combined_password";
>     return $combined_username => $combined_password;
> }
> 
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 14403: 40233 | 40236 | 40259