Bugzilla – Attachment 40298 Details for
Bug 14383
Typos in various Koha files
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14383: C4: Fix some typos (mostly in comments and documentation)
Bug-14383-C4-Fix-some-typos-mostly-in-comments-and.patch (text/plain), 42.44 KB, created by
Jonathan Druart
on 2015-06-18 14:20:18 UTC
(
hide
)
Description:
Bug 14383: C4: Fix some typos (mostly in comments and documentation)
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-06-18 14:20:18 UTC
Size:
42.44 KB
patch
obsolete
>From 25f376d61f4e1cdca4bae86ac8155d7b5d663195 Mon Sep 17 00:00:00 2001 >From: Stefan Weil <sw@weilnetz.de> >Date: Mon, 15 Jun 2015 07:47:18 +0200 >Subject: [PATCH] Bug 14383: C4: Fix some typos (mostly in comments and > documentation) > >Most of them were found and fixed using codespell. >Fix also some related grammar issues. > >In C4/Serials.pm a variable was renamed to make future codespelling >checks easier. > >Signed-off-by: Stefan Weil <sw@weilnetz.de> > >http://bugs.koha-community.org/show_bug.cgi?id=14383 >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> >--- > C4/Acquisition.pm | 8 ++++---- > C4/Auth.pm | 8 ++++---- > C4/AuthoritiesMarc.pm | 2 +- > C4/Barcodes.pm | 2 +- > C4/Barcodes/hbyymmincr.pm | 2 +- > C4/Biblio.pm | 6 +++--- > C4/Branch.pm | 4 ++-- > C4/Calendar.pm | 2 +- > C4/Circulation.pm | 10 +++++----- > C4/ClassSortRoutine.pm | 2 +- > C4/Context.pm | 4 ++-- > C4/Creators/Batch.pm | 4 ++-- > C4/Creators/Layout.pm | 6 +++--- > C4/Creators/PDF.pm | 2 +- > C4/Creators/Profile.pm | 4 ++-- > C4/Creators/Template.pm | 6 +++--- > C4/Dates.pm | 4 ++-- > C4/Installer.pm | 2 +- > C4/Items.pm | 6 +++--- > C4/Koha.pm | 4 ++-- > C4/Labels/Label.pm | 2 +- > C4/Patroncards/Lib.pm | 4 ++-- > C4/Ratings.pm | 2 +- > C4/Reports/Guided.pm | 6 +++--- > C4/Reserves.pm | 16 ++++++++-------- > C4/Ris.pm | 4 ++-- > C4/RotatingCollections.pm | 16 ++++++++-------- > C4/SIP/ILS/Patron.pod | 4 ++-- > C4/SIP/Sip.pm | 2 +- > C4/SIP/Sip/MsgType.pm | 8 ++++---- > C4/Search.pm | 4 ++-- > C4/Serials.pm | 6 +++--- > C4/Serials/Frequency.pm | 2 +- > C4/Serials/Numberpattern.pm | 2 +- > C4/ShelfBrowser.pm | 2 +- > C4/TTParser.pm | 8 ++++---- > C4/Tags.pm | 4 ++-- > C4/UploadedFile.pm | 2 +- > C4/Utils/DataTables/ColumnsSettings.pm | 2 +- > C4/Utils/DataTables/Members.pm | 2 +- > C4/XSLT.pm | 2 +- > 41 files changed, 94 insertions(+), 94 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index 01b815a..d201b2c 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -1692,7 +1692,7 @@ sub SearchOrders { > LEFT JOIN biblioitems ON biblioitems.biblionumber=biblio.biblionumber > }; > >- # If we search on ordernumber, we retrieve the transfered order if a transfer has been done. >+ # If we search on ordernumber, we retrieve the transferred order if a transfer has been done. > $query .= q{ > LEFT JOIN aqorders_transfers ON aqorders_transfers.ordernumber_to = aqorders.ordernumber > } if $ordernumber; >@@ -1838,11 +1838,11 @@ sub DelOrder { > my $newordernumber = TransferOrder($ordernumber, $basketno); > > Transfer an order line to a basket. >-Mark $ordernumber as cancelled with an internal note 'Cancelled and transfered >+Mark $ordernumber as cancelled with an internal note 'Cancelled and transferred > to BOOKSELLER on DATE' and create new order with internal note >-'Transfered from BOOKSELLER on DATE'. >+'Transferred from BOOKSELLER on DATE'. > Move all attached items to the new order. >-Received orders cannot be transfered. >+Received orders cannot be transferred. > Return the ordernumber of created order. > > =cut >diff --git a/C4/Auth.pm b/C4/Auth.pm >index 0d21575..901f341 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -320,7 +320,7 @@ sub get_template_and_user { > else { # if this is an anonymous session, setup to display public lists... > > # If shibboleth is enabled, and we're in an anonymous session, we should allow >- # the user to attemp login via shibboleth. >+ # the user to attempt login via shibboleth. > if ($shib) { > $template->param( shibbolethAuthentication => $shib, > shibbolethLoginUrl => login_shib_url( $in->{'query'} ), >@@ -637,7 +637,7 @@ sub _version_check { > my $query = shift; > my $version; > >- # If Version syspref is unavailable, it means Koha is beeing installed, >+ # If version syspref is unavailable, it means Koha is being installed, > # and so we must redirect to OPAC maintenance page or to the WebInstaller > # also, if OpacMaintenance is ON, OPAC should redirect to maintenance > if ( C4::Context->preference('OpacMaintenance') && $type eq 'opac' ) { >@@ -746,7 +746,7 @@ sub checkauth { > } > elsif ($persona) { > >- # we dont want to set a session because we are being called by a persona callback >+ # we don't want to set a session because we are being called by a persona callback > } > elsif ( $sessionID = $query->cookie("CGISESSID") ) > { # assignment, not comparison >@@ -902,7 +902,7 @@ sub checkauth { > $info{'invalidShibLogin'} = 1 unless ($return); > } > >- # If shib login and match were successfull, skip further login methods >+ # If shib login and match were successful, skip further login methods > unless ($shibSuccess) { > if ( $cas && $query->param('ticket') ) { > my $retuserid; >diff --git a/C4/AuthoritiesMarc.pm b/C4/AuthoritiesMarc.pm >index c311fb2..f617437 100644 >--- a/C4/AuthoritiesMarc.pm >+++ b/C4/AuthoritiesMarc.pm >@@ -888,7 +888,7 @@ sub FindDuplicateAuthority { > > Returns a hashref with a summary of the specified record. > >-Comment : authtypecode can be infered from both record and authid. >+Comment : authtypecode can be inferred from both record and authid. > Moreover, authid can also be inferred from $record. > Would it be interesting to delete those things. > >diff --git a/C4/Barcodes.pm b/C4/Barcodes.pm >index 271586b..0872056 100644 >--- a/C4/Barcodes.pm >+++ b/C4/Barcodes.pm >@@ -133,7 +133,7 @@ sub next_value { > } > my $x = length($incr); # number of digits > $incr =~ /^9+$/ and $x++; # if they're all 9's, we need an extra. >- # Note, this enlargement might be undesireable for some barcode formats. >+ # Note, this enlargement might be undesirable for some barcode formats. > # Those should override next_value() to work accordingly. > $incr++; > >diff --git a/C4/Barcodes/hbyymmincr.pm b/C4/Barcodes/hbyymmincr.pm >index 208b14b..c2a6d38 100644 >--- a/C4/Barcodes/hbyymmincr.pm >+++ b/C4/Barcodes/hbyymmincr.pm >@@ -129,7 +129,7 @@ __END__ > > This format is deprecated and SHOULD NOT BE USED. > >-It is fairly clear the originator of the format did not intend to accomodate >+It is fairly clear the originator of the format did not intend to accommodate > multiple branch libraries, given that the format caps the available namespace to > 10,000 barcodes per year TOTAL. > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index d3d2bf9..7e0aa1f 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -126,8 +126,8 @@ BEGIN { > > # Internal functions > # those functions are exported but should not be used >- # they are usefull is few circumstances, so are exported. >- # but don't use them unless you're a core developer ;-) >+ # they are useful in a few circumstances, so they are exported, >+ # but don't use them unless you are a core developer ;-) > push @EXPORT, qw( > &ModBiblioMarc > ); >@@ -1519,7 +1519,7 @@ sub MungeMarcPrice { > ( # start of capturing parenthesis > (?: > (?:[\p{Sc}\p{L}\/.]){1,4} # any character from Currency signs or Letter Unicode categories or slash or dot within 1 to 4 occurrences : call this whole block 'symbol block' >- |(?:\d+[\p{P}\s]?){1,4} # or else at least one digit followed or not by a punctuation sign or whitespace, all theese within 1 to 4 occurrences : call this whole block 'digits block' >+ |(?:\d+[\p{P}\s]?){1,4} # or else at least one digit followed or not by a punctuation sign or whitespace, all these within 1 to 4 occurrences : call this whole block 'digits block' > ) > \s?\p{Sc}?\s? # followed or not by a whitespace. \p{Sc}?\s? are for cases like '25$ USD' > (?: >diff --git a/C4/Branch.pm b/C4/Branch.pm >index a78bef6..56b96fb 100644 >--- a/C4/Branch.pm >+++ b/C4/Branch.pm >@@ -186,9 +186,9 @@ sub GetBranchName { > > $error = &ModBranch($newvalue); > >-This function modify an existing branch >+This function modifies an existing branch > >-C<$newvalue> is a ref to an array wich is containt all the column from branches table. >+C<$newvalue> is a ref to an array which contains all the columns from branches table. > > =cut > >diff --git a/C4/Calendar.pm b/C4/Calendar.pm >index dfee6b3..6783f97 100644 >--- a/C4/Calendar.pm >+++ b/C4/Calendar.pm >@@ -165,7 +165,7 @@ sub get_exception_holidays { > $single_holidays = $calendar->get_single_holidays(); > > Returns a hash reference to single holidays. This kind of holidays are those which >-happend just one time. >+happened just one time. > > =cut > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index d825d81..aa4c9fc 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -837,7 +837,7 @@ sub CanBookBeIssued { > } > > # >- # JB34 CHECKS IF BORROWERS DONT HAVE ISSUE TOO MANY BOOKS >+ # JB34 CHECKS IF BORROWERS DON'T HAVE ISSUE TOO MANY BOOKS > # > my ($current_loan_count, $max_loans_allowed) = TooMany( $borrower, $item->{biblionumber}, $item ); > # if TooMany max_loans_allowed returns 0 the user doesn't have permission to check out this book >@@ -1293,7 +1293,7 @@ sub AddIssue { > UpdateTotalIssues($item->{'biblionumber'}, 1); > } > >- ## If item was lost, it has now been found, reverse any list item charges if neccessary. >+ ## If item was lost, it has now been found, reverse any list item charges if necessary. > if ( $item->{'itemlost'} ) { > if ( C4::Context->preference('RefundLostItemFeeOnReturn' ) ) { > _FixAccountForLostAndReturned( $item->{'itemnumber'}, undef, $item->{'barcode'} ); >@@ -1767,7 +1767,7 @@ sub AddReturn { > my $issue = GetItemIssue($itemnumber); > if ($issue and $issue->{borrowernumber}) { > $borrower = C4::Members::GetMemberDetails($issue->{borrowernumber}) >- or die "Data inconsistency: barcode $barcode (itemnumber:$itemnumber) claims to be issued to non-existant borrowernumber '$issue->{borrowernumber}'\n" >+ or die "Data inconsistency: barcode $barcode (itemnumber:$itemnumber) claims to be issued to non-existent borrowernumber '$issue->{borrowernumber}'\n" > . Dumper($issue) . "\n"; > } else { > $messages->{'NotIssued'} = $barcode; >@@ -3419,7 +3419,7 @@ sub CalcDateDue { > } > } > >- # if Hard Due Dates are used, retreive them and apply as necessary >+ # if Hard Due Dates are used, retrieve them and apply as necessary > my ( $hardduedate, $hardduedatecompare ) = > GetHardDueDate( $borrower->{'categorycode'}, $itemtype, $branch ); > if ($hardduedate) { # hardduedates are currently dates >@@ -3877,7 +3877,7 @@ sub GetAgeRestriction { > my @values = split ' ', uc($record_restrictions); > return unless @values; > >- # Search first occurence of one of the markers >+ # Search first occurrence of one of the markers > my @markers = split /\|/, uc($markers); > return unless @markers; > >diff --git a/C4/ClassSortRoutine.pm b/C4/ClassSortRoutine.pm >index f5ea779..2c345ba 100644 >--- a/C4/ClassSortRoutine.pm >+++ b/C4/ClassSortRoutine.pm >@@ -48,7 +48,7 @@ use C4::ClassSortRoutine; > &GetClassSortKey > ); > >-# intialization code >+# initialization code > my %loaded_routines = (); > my @sort_routines = GetSortRoutineNames(); > foreach my $sort_routine (@sort_routines) { >diff --git a/C4/Context.pm b/C4/Context.pm >index 3e3f00c..3561a4f 100644 >--- a/C4/Context.pm >+++ b/C4/Context.pm >@@ -288,7 +288,7 @@ sub import { > # the first time the module is called > # (a config file can be optionaly passed) > >- # default context allready exists? >+ # default context already exists? > return if $context; > > # no ? so load it! >@@ -350,7 +350,7 @@ sub new { > } > > if ($ismemcached) { >- # retreive from memcached >+ # retrieve from memcached > $self = $memcached->get('kohaconf'); > if (not defined $self) { > # not in memcached yet >diff --git a/C4/Creators/Batch.pm b/C4/Creators/Batch.pm >index 13fc436..4fcf3c4 100644 >--- a/C4/Creators/Batch.pm >+++ b/C4/Creators/Batch.pm >@@ -105,8 +105,8 @@ sub remove_item { > } > > # FIXME: This method is effectively useless the way the current add_item method is written. Ideally, the items should be added to the object >-# and then the save method called. This does not work well in practice due to the inability to pass objects accross cgi script calls. >-# I'm leaving it here because it should be here and for consistency's sake and once memcached support is fully implimented this should be as well. -cnighswonger >+# and then the save method called. This does not work well in practice due to the inability to pass objects across cgi script calls. >+# I'm leaving it here because it should be here and for consistency's sake and once memcached support is fully implemented this should be as well. -cnighswonger > # > #=head2 $batch->save() > # >diff --git a/C4/Creators/Layout.pm b/C4/Creators/Layout.pm >index a12532f..a660ef6 100644 >--- a/C4/Creators/Layout.pm >+++ b/C4/Creators/Layout.pm >@@ -129,8 +129,8 @@ sub delete { > push @params, $opts{'layout_id'}, $opts{'creator'}; > } > if (scalar(@params) < 2) { # If there is no layout id or creator type then we cannot delete it >- warn sprintf('%s : Cannot delete layout as the profile id is invalid or non-existant.', $call_type) if !$params[0]; >- warn sprintf('%s : Cannot delete layout as the creator type is invalid or non-existant.', $call_type) if !$params[1]; >+ warn sprintf('%s : Cannot delete layout as the profile id is invalid or non-existent.', $call_type) if !$params[0]; >+ warn sprintf('%s : Cannot delete layout as the creator type is invalid or non-existent.', $call_type) if !$params[1]; > return -1; > } > my $query = "DELETE FROM creator_layouts WHERE layout_id = ? AND creator = ?"; >@@ -267,7 +267,7 @@ This module provides methods for creating, retrieving, and otherwise manipulatin > CODE39MOD10 = Code 3 of 9 with modulo 10 checksum > > =item . >- COOP2OF5 = A varient of 2 of 5 barcode based on NEC's "Process 8000" code >+ COOP2OF5 = A variant of 2 of 5 barcode based on NEC's "Process 8000" code > > =item . > INDUSTRIAL2OF5 = The standard 2 of 5 barcode (a binary level bar code developed by Identicon Corp. and Computer Identics Corp. in 1970) >diff --git a/C4/Creators/PDF.pm b/C4/Creators/PDF.pm >index 7dde9ee..dd0d3f6 100644 >--- a/C4/Creators/PDF.pm >+++ b/C4/Creators/PDF.pm >@@ -323,7 +323,7 @@ __END__ > > =head1 NAME > >-C4::Creators::PDF - A class wrapper for PDF::Reuse and PDF::Reuse::Barcode to allow usage as a psuedo-object. For usage see >+C4::Creators::PDF - A class wrapper for PDF::Reuse and PDF::Reuse::Barcode to allow usage as a pseudo-object. For usage see > PDF::Reuse documentation and C4::Creators::PDF code. > > =cut >diff --git a/C4/Creators/Profile.pm b/C4/Creators/Profile.pm >index a063aaf..54151d1 100644 >--- a/C4/Creators/Profile.pm >+++ b/C4/Creators/Profile.pm >@@ -110,8 +110,8 @@ sub delete { > push @params, $opts{'profile_id'}, $opts{'creator'}; > } > if (scalar(@params) < 2) { # If there is no profile id or creator type then we cannot delete it >- warn sprintf('%s : Cannot delete profile as the profile id is invalid or non-existant.', $call_type) if !$params[0]; >- warn sprintf('%s : Cannot delete profile as the creator type is invalid or non-existant.', $call_type) if !$params[1]; >+ warn sprintf('%s : Cannot delete profile as the profile id is invalid or non-existent.', $call_type) if !$params[0]; >+ warn sprintf('%s : Cannot delete profile as the creator type is invalid or non-existent.', $call_type) if !$params[1]; > return -1; > } > my $query = "DELETE FROM printers_profile WHERE profile_id = ? AND creator = ?"; >diff --git a/C4/Creators/Template.pm b/C4/Creators/Template.pm >index b0b7da0..ccf3d57 100644 >--- a/C4/Creators/Template.pm >+++ b/C4/Creators/Template.pm >@@ -150,8 +150,8 @@ sub delete { > push @query_params, $opts{'template_id'}, $opts{'creator'}; > } > if (scalar(@query_params) < 2) { # If there is no template id or creator type then we cannot delete it >- warn sprintf('%s : Cannot delete template as the template id is invalid or non-existant.', $call_type) if !$query_params[0]; >- warn sprintf('%s : Cannot delete template as the creator type is invalid or non-existant.', $call_type) if !$query_params[1]; >+ warn sprintf('%s : Cannot delete template as the template id is invalid or non-existent.', $call_type) if !$query_params[0]; >+ warn sprintf('%s : Cannot delete template as the creator type is invalid or non-existent.', $call_type) if !$query_params[1]; > return -1; > } > my $query = "DELETE FROM creator_templates WHERE template_id = ? AND creator = ?"; >@@ -344,7 +344,7 @@ CM = SI Centimeters (28.3464567 points per) > my $template = C4::Labels::Template->new(profile_id => 1, page_width => 8.5, page_height => 11.0, units => 'INCH'); # Creates and returns a new template object using > the supplied values to override the defaults > >- B<NOTE:> This template is I<not> written to the database untill save() is invoked. You have been warned! >+ B<NOTE:> This template is I<not> written to the database until save() is invoked. You have been warned! > > =head2 retrieve(template_id => $template_id) > >diff --git a/C4/Dates.pm b/C4/Dates.pm >index aaf188c..9fe801a 100644 >--- a/C4/Dates.pm >+++ b/C4/Dates.pm >@@ -279,7 +279,7 @@ date format unless otherwise instructed. > With no argument, format returns the object's current date_format. Otherwise it attempts to > set the object format to the supplied value. > >-Some previously desireable functions are now unnecessary. For example, you might want a >+Some previously desirable functions are now unnecessary. For example, you might want a > method/function to tell you whether or not a Dates.pm object is of the 'iso' type. But you > can see by this example that such a test is trivial to accomplish, and not necessary to > include in the module: >@@ -315,7 +315,7 @@ Or even: > > Perhaps you want to force data obtained in a known format to display according to the user's system > preference, without necessarily knowing what that preference is. For this purpose, you can use the >-psuedo-format argument "syspref". >+pseudo-format argument "syspref". > > For example, to print an ISO date (from the database) in the <systempreference> format: > >diff --git a/C4/Installer.pm b/C4/Installer.pm >index d15be1f..a4f63a2 100644 >--- a/C4/Installer.pm >+++ b/C4/Installer.pm >@@ -458,7 +458,7 @@ sub load_sql { > $error = qx($strcmd -f $filename 2>&1 1>/dev/null); > # Be sure to set 'client_min_messages = error' in postgresql.conf > # so that only true errors are returned to stderr or else the installer will >- # report the import a failure although it really succeded -fbcit >+ # report the import as a failure although it really succeeded -fbcit > } > # errors thrown while loading installer data should be logged > if($error) { >diff --git a/C4/Items.pm b/C4/Items.pm >index d1a866b..55bb4bd 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -432,7 +432,7 @@ other purposes, C<ModItem> should be used. > > This function uses the hash %default_values_for_mod_from_marc, > which contains default values for item fields to >-apply when modifying an item. This is needed beccause >+apply when modifying an item. This is needed because > if an item field's value is cleared, TransformMarcToKoha > does not include the column in the > hash that's passed to ModItem, which without >@@ -791,7 +791,7 @@ C<items.notforloan> field. > NOTE: does B<not> return an individual item's > status. > >-Can be MARC dependant. >+Can be MARC dependent. > fwkcode is optional. > But basically could be can be loan or not > Create a status selector with the following code >@@ -2310,7 +2310,7 @@ sub DelItemCheck { > $error = "not_same_branch"; > } > else{ >- # check it doesnt have a waiting reserve >+ # check it doesn't have a waiting reserve > $sth = $dbh->prepare(q{ > SELECT COUNT(*) FROM reserves > WHERE (found = 'W' OR found = 'T') >diff --git a/C4/Koha.pm b/C4/Koha.pm >index 4f54a3b..bca12d6 100644 >--- a/C4/Koha.pm >+++ b/C4/Koha.pm >@@ -1741,7 +1741,7 @@ sub NormalizeISBN { > > my @isbns = GetVariationsOfISBN( $isbn ); > >- Returns a list of varations of the given isbn in >+ Returns a list of variations of the given isbn in > both ISBN-10 and ISBN-13 formats, with and without > hyphens. > >@@ -1773,7 +1773,7 @@ sub GetVariationsOfISBN { > > my @isbns = GetVariationsOfISBNs( @isbns ); > >- Returns a list of varations of the given isbns in >+ Returns a list of variations of the given isbns in > both ISBN-10 and ISBN-13 formats, with and without > hyphens. > >diff --git a/C4/Labels/Label.pm b/C4/Labels/Label.pm >index 3b4318a..271c6bc 100644 >--- a/C4/Labels/Label.pm >+++ b/C4/Labels/Label.pm >@@ -636,7 +636,7 @@ This module provides methods for creating, and otherwise manipulating single lab > CODE39MOD10 = Code 3 of 9 with modulo 10 checksum > > =item . >- COOP2OF5 = A varient of 2 of 5 barcode based on NEC's "Process 8000" code >+ COOP2OF5 = A variant of 2 of 5 barcode based on NEC's "Process 8000" code > > =item . > INDUSTRIAL2OF5 = The standard 2 of 5 barcode (a binary level bar code developed by Identicon Corp. and Computer Identics Corp. in 1970) >diff --git a/C4/Patroncards/Lib.pm b/C4/Patroncards/Lib.pm >index db88943..46e9f29 100644 >--- a/C4/Patroncards/Lib.pm >+++ b/C4/Patroncards/Lib.pm >@@ -198,7 +198,7 @@ This library provides functions used by various sections of the Patroncard Creat > > =head2 C4::Patroncards::Lib::unpack_UTF8() > >- This function returns a reference to an array of hex values equivelant to the utf8 values of the string passed in. This assumes, of course, that the string is >+ This function returns a reference to an array of hex values equivalent to the utf8 values of the string passed in. This assumes, of course, that the string is > indeed utf8. > > example: >@@ -235,7 +235,7 @@ This library provides functions used by various sections of the Patroncard Creat > > =head2 C4::Patroncards::Lib::leading() > >- This function accepts a single parameter, font postscript point size, and returns the ammount of leading to be added. >+ This function accepts a single parameter, font postscript point size, and returns the amount of leading to be added. > > example: > >diff --git a/C4/Ratings.pm b/C4/Ratings.pm >index b5ab11d..38e3521 100644 >--- a/C4/Ratings.pm >+++ b/C4/Ratings.pm >@@ -72,7 +72,7 @@ Delete a rating for a bib > > All subroutines in Ratings.pm return a hashref which contain 4 keys > >-for example, after executing this statment below... >+for example, after executing this statement below... > > my $rating_hashref = GetRating ( $biblionumber, $borrowernumber ) ; > >diff --git a/C4/Reports/Guided.pm b/C4/Reports/Guided.pm >index a440ebe..c714213 100644 >--- a/C4/Reports/Guided.pm >+++ b/C4/Reports/Guided.pm >@@ -185,7 +185,7 @@ This will return a list of all columns for a report area > > sub get_columns { > >- # this calls the internal fucntion _get_columns >+ # this calls the internal function _get_columns > my ( $area, $cgi ) = @_; > my %table_areas = get_table_areas; > my $tables = $table_areas{$area} >@@ -440,7 +440,7 @@ for the query. > C<$offset>, and C<$limit> are required parameters. > > C<\@sql_params> is an optional list of parameter values to paste in. >-The caller is reponsible for making sure that C<$sql> has placeholders >+The caller is responsible for making sure that C<$sql> has placeholders > and that the number placeholders matches the number of parameters. > > =cut >@@ -783,7 +783,7 @@ sub get_column_type { > my $catalog; > my $schema; > >- # mysql doesnt support a column selection, set column to % >+ # mysql doesn't support a column selection, set column to % > my $tempcolumn='%'; > my $sth = $dbh->column_info( $catalog, $schema, $table, $tempcolumn ) || die $dbh->errstr; > while (my $info = $sth->fetchrow_hashref()){ >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 9c760b6..6252b86 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -61,7 +61,7 @@ This modules provides somes functions to deal with reservations. > The following columns contains important values : > - priority >0 : then the reserve is at 1st stage, and not yet affected to any item. > =0 : then the reserve is being dealed >- - found : NULL : means the patron requested the 1st available, and we haven't choosen the item >+ - found : NULL : means the patron requested the 1st available, and we haven't chosen the item > T(ransit) : the reserve is linked to an item but is in transit to the pickup branch > W(aiting) : the reserve is linked to an item, is at the pickup branch, and is waiting on the hold shelf > F(inished) : the reserve has been completed, and is done >@@ -74,7 +74,7 @@ This modules provides somes functions to deal with reservations. > if there is no transfer to do, the reserve waiting > patron can pick it up P =0, F=W, I=filled > if there is a transfer to do, write in branchtransfer P =0, F=T, I=filled >- The pickup library recieve the book, it check in P =0, F=W, I=filled >+ The pickup library receive the book, it check in P =0, F=W, I=filled > The patron borrow the book P =0, F=F, I=filled > > ==== 2nd use case ==== >@@ -660,7 +660,7 @@ sub GetReserveCount { > > ($messages,$nextreservinfo)=$GetOtherReserves(itemnumber); > >-Check queued list of this document and check if this document must be transfered >+Check queued list of this document and check if this document must be transferred > > =cut > >@@ -1386,7 +1386,7 @@ sub ModReserveAffect { > my $request = GetReserveInfo($reserve_id); > my $already_on_shelf = ($request && $request->{found} eq 'W') ? 1 : 0; > >- # If we affect a reserve that has to be transfered, don't set to Waiting >+ # If we affect a reserve that has to be transferred, don't set to Waiting > my $query; > if ($transferToDo) { > $query = " >@@ -1591,7 +1591,7 @@ sub _get_itype { > > my $itype; > if (C4::Context->preference('item-level_itypes')) { >- # We cant trust GetItem to honour the syspref, so safest to do it ourselves >+ # We can't trust GetItem to honour the syspref, so safest to do it ourselves > # When GetItem is fixed, we can remove this > $itype = $item->{itype}; > } >@@ -1920,7 +1920,7 @@ sub _Findgroupreserve { > my $dbh = C4::Context->dbh; > > # TODO: consolidate at least the SELECT portion of the first 2 queries to a common $select var. >- # check for exact targetted match >+ # check for exact targeted match > my $item_level_target_query = qq{ > SELECT reserves.biblionumber AS biblionumber, > reserves.borrowernumber AS borrowernumber, >@@ -1954,7 +1954,7 @@ sub _Findgroupreserve { > } > return @results if @results; > >- # check for title-level targetted match >+ # check for title-level targeted match > my $title_level_target_query = qq{ > SELECT reserves.biblionumber AS biblionumber, > reserves.borrowernumber AS borrowernumber, >@@ -2174,7 +2174,7 @@ sub OPACItemHoldsAllowed { > my $itype; > my $dbh = C4::Context->dbh; > if (C4::Context->preference('item-level_itypes')) { >- # We cant trust GetItem to honour the syspref, so safest to do it ourselves >+ # We can't trust GetItem to honour the syspref, so safest to do it ourselves > # When GetItem is fixed, we can remove this > $itype = $item->{itype}; > } >diff --git a/C4/Ris.pm b/C4/Ris.pm >index 0727bf9..0a0f181 100644 >--- a/C4/Ris.pm >+++ b/C4/Ris.pm >@@ -299,7 +299,7 @@ sub marc2ris { > > ##******************************************************************** > ## print_typetag(): prints the first line of a RIS dataset including >-## the preceeding newline >+## the preceding newline > ## Argument: the leader of a MARC dataset > ## Returns: the value at leader position 06 > ##******************************************************************** >@@ -713,7 +713,7 @@ sub print_pubinfo { > $protoyear =~ s% *[\.;:/]*$%%; > > ## isolate a four-digit year. We discard anything >- ## preceeding the year, but keep everything after >+ ## preceding the year, but keep everything after > ## the year as other info. > $protoyear =~ s%\D*([0-9\-]{4})(.*)%$1///$2%; > >diff --git a/C4/RotatingCollections.pm b/C4/RotatingCollections.pm >index 9980ed9..dd80cdd 100644 >--- a/C4/RotatingCollections.pm >+++ b/C4/RotatingCollections.pm >@@ -88,7 +88,7 @@ sub CreateCollection { > my $schema = Koha::Database->new()->schema(); > my $duplicate_titles = $schema->resultset('Collection')->count({ colTitle => $title }); > >- ## Check for all neccessary parameters >+ ## Check for all necessary parameters > if ( !$title ) { > return ( 0, 1, "NO_TITLE" ); > } elsif ( $duplicate_titles ) { >@@ -136,7 +136,7 @@ sub UpdateCollection { > my $schema = Koha::Database->new()->schema(); > my $duplicate_titles = $schema->resultset('Collection')->count({ colTitle => $title, -not => { colId => $colId } }); > >- ## Check for all neccessary parameters >+ ## Check for all necessary parameters > if ( !$colId ) { > return ( 0, 1, "NO_ID" ); > } >@@ -171,7 +171,7 @@ sub UpdateCollection { > Deletes a collection of the given id > > Input: >- $colId : id of the Archtype to be deleted >+ $colId : id of the Archetype to be deleted > > Output: > $success: 1 if all database operations were successful, 0 otherwise >@@ -183,7 +183,7 @@ sub UpdateCollection { > sub DeleteCollection { > my ($colId) = @_; > >- ## Paramter check >+ ## Parameter check > if ( !$colId ) { > return ( 0, 1, "NO_ID" ); > } >@@ -247,7 +247,7 @@ sub GetCollections { > sub GetItemsInCollection { > my ($colId) = @_; > >- ## Paramter check >+ ## Parameter check > if ( !$colId ) { > return ( 0, 0, 1, "NO_ID" ); > } >@@ -326,7 +326,7 @@ Adds an item to a rotating collection. > sub AddItemToCollection { > my ( $colId, $itemnumber ) = @_; > >- ## Check for all neccessary parameters >+ ## Check for all necessary parameters > if ( !$colId ) { > return ( 0, 1, "NO_ID" ); > } >@@ -376,7 +376,7 @@ Removes an item to a collection > sub RemoveItemFromCollection { > my ( $colId, $itemnumber ) = @_; > >- ## Check for all neccessary parameters >+ ## Check for all necessary parameters > if ( !$itemnumber ) { > return ( 0, 2, "NO_ITEM" ); > } >@@ -417,7 +417,7 @@ Transfers a collection to another branch > sub TransferCollection { > my ( $colId, $colBranchcode ) = @_; > >- ## Check for all neccessary parameters >+ ## Check for all necessary parameters > if ( !$colId ) { > return ( 0, 1, "NO_ID" ); > } >diff --git a/C4/SIP/ILS/Patron.pod b/C4/SIP/ILS/Patron.pod >index 9bc750a..71c167c 100644 >--- a/C4/SIP/ILS/Patron.pod >+++ b/C4/SIP/ILS/Patron.pod >@@ -95,7 +95,7 @@ explication however. > > =head2 C<$str = $patron-E<gt>sip_birthdate;> > >-Returns the patron's birthday formated according to the SIP >+Returns the patron's birthday formatted according to the SIP > specification: > > YYYYMMDD HHMMSS >@@ -112,7 +112,7 @@ based on patron type). > > =head2 C<$str = $patron-E<gt>language;> > >-A three-digit string encoding the patron's prefered language. >+A three-digit string encoding the patron's preferred language. > The full list is defined in the SIP specification, but some of > the important values are: > >diff --git a/C4/SIP/Sip.pm b/C4/SIP/Sip.pm >index ddd08c9..29aa6a2 100644 >--- a/C4/SIP/Sip.pm >+++ b/C4/SIP/Sip.pm >@@ -74,7 +74,7 @@ sub add_field { > $value=~s/\r/ /g; # CR terminates a sip message > # Protect against them in sip text fields > >- # Replace any occurences of the field delimiter in the >+ # Replace any occurrences of the field delimiter in the > # field value with the HTML character entity > $ent = sprintf("&#%d;", ord($field_delimiter)); > >diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm >index 5ef7465..6b387cf 100644 >--- a/C4/SIP/Sip/MsgType.pm >+++ b/C4/SIP/Sip/MsgType.pm >@@ -836,7 +836,7 @@ sub login_core { > # > my $module = $server->{config}->{institutions}->{$inst}->{implementation}; > syslog("LOG_DEBUG", 'login_core: ' . Dumper($module)); >- # Suspect this is always ILS but so we dont break any eccentic install (for now) >+ # Suspect this is always ILS but so we don't break any eccentic install (for now) > if ($module eq 'ILS') { > $module = 'C4::SIP::ILS'; > } >@@ -885,7 +885,7 @@ sub handle_login { > # > # Build the detailed summary information for the Patron > # Information Response message based on the first 'Y' that appears >-# in the 'summary' field of the Patron Information reqest. The >+# in the 'summary' field of the Patron Information request. The > # specification says that only one 'Y' can appear in that field, > # and we're going to believe it. > # >@@ -1343,7 +1343,7 @@ sub handle_renew { > > if ($no_block eq 'Y') { > syslog("LOG_WARNING", >- "handle_renew: recieved 'no block' renewal from terminal '%s'", >+ "handle_renew: received 'no block' renewal from terminal '%s'", > $server->{account}->{id}); > } > >@@ -1391,7 +1391,7 @@ sub handle_renew { > $resp .= '0NUN'; > $resp .= timestamp; > # If we found the patron or the item, the return the ILS >- # information, otherwise echo back the infomation we received >+ # information, otherwise echo back the information we received > # from the terminal > $resp .= add_field(FID_PATRON_ID, $patron ? $patron->id : $patron_id); > $resp .= add_field(FID_ITEM_ID, $item ? $item->id : $item_id ); >diff --git a/C4/Search.pm b/C4/Search.pm >index 990ed39..1389e5b 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -171,7 +171,7 @@ This function provides a simple search API on the bibliographic catalog > > * $query can be a simple keyword or a complete CCL query > * @servers is optional. Defaults to biblioserver as found in koha-conf.xml >- * $offset - If present, represents the number of records at the beggining to omit. Defaults to 0 >+ * $offset - If present, represents the number of records at the beginning to omit. Defaults to 0 > * $max_results - if present, determines the maximum number of records to fetch. undef is All. defaults to undef. > > >@@ -922,7 +922,7 @@ sub _remove_stopwords { > > # remove stopwords from operand : parse all stopwords & remove them (case insensitive) > # we use IsAlpha unicode definition, to deal correctly with diacritics. >-# otherwise, a French word like "leçon" woudl be split into "le" "çon", "le" >+# otherwise, a French word like "leçon" would be split into "le" "çon", "le" > # is a stopword, we'd get "çon" and wouldn't find anything... > # > foreach ( keys %{ C4::Context->stopwords } ) { >diff --git a/C4/Serials.pm b/C4/Serials.pm >index 807306d..3fcc4a3 100644 >--- a/C4/Serials.pm >+++ b/C4/Serials.pm >@@ -2584,7 +2584,7 @@ sub _numeration { > > =head2 is_barcode_in_use > >-Returns number of occurence of the barcode in the items table >+Returns number of occurrences of the barcode in the items table > Can be used as a boolean test of whether the barcode has > been deployed as yet > >@@ -2593,13 +2593,13 @@ been deployed as yet > sub is_barcode_in_use { > my $barcode = shift; > my $dbh = C4::Context->dbh; >- my $occurences = $dbh->selectall_arrayref( >+ my $occurrences = $dbh->selectall_arrayref( > 'SELECT itemnumber from items where barcode = ?', > {}, $barcode > > ); > >- return @{$occurences}; >+ return @{$occurrences}; > } > > =head2 CloseSubscription >diff --git a/C4/Serials/Frequency.pm b/C4/Serials/Frequency.pm >index d71df7a..041e75e 100644 >--- a/C4/Serials/Frequency.pm >+++ b/C4/Serials/Frequency.pm >@@ -287,6 +287,6 @@ __END__ > > =head1 AUTHOR > >-Koha Developement team <info@koha.org> >+Koha Development team <info@koha.org> > > =cut >diff --git a/C4/Serials/Numberpattern.pm b/C4/Serials/Numberpattern.pm >index feca3cd..c7de69a 100644 >--- a/C4/Serials/Numberpattern.pm >+++ b/C4/Serials/Numberpattern.pm >@@ -284,6 +284,6 @@ __END__ > > =head1 AUTHOR > >-Koha Developement team <info@koha.org> >+Koha Development team <info@koha.org> > > =cut >diff --git a/C4/ShelfBrowser.pm b/C4/ShelfBrowser.pm >index 13a0f7f..3af36a5 100644 >--- a/C4/ShelfBrowser.pm >+++ b/C4/ShelfBrowser.pm >@@ -103,7 +103,7 @@ C<ShelfBrowserUsesCcode>. > The option C<$num_each_side> value determines how many items will be fetched > each side of the supplied item. Note that the item itself is the first entry > in the 'next' set, and counts towards this limit (this is to keep the >-behaviour consistant with the code that this is a refactor of.) Default is >+behaviour consistent with the code that this is a refactor of.) Default is > 3. > > This will throw an exception if something went wrong. >diff --git a/C4/TTParser.pm b/C4/TTParser.pm >index a0034b6..4c3a4a0 100644 >--- a/C4/TTParser.pm >+++ b/C4/TTParser.pm >@@ -55,9 +55,9 @@ sub peep_token{ > sub build_tokens{ > my ($self, $filename) = @_; > $self->{filename} = $filename; >- $self->handler(start => "start", "self, line, tagname, attr, text"); #signature is start( self, linenumber, tagname, hash of attributes, origional text ) >- $self->handler(text => "text", "self, line, text, is_cdata"); #signature is text( self, linenumber, origional text, is_cdata ) >- $self->handler(end => "end", "self, line, tag, attr, text"); #signature is end( self, linenumber, tagename, origional text ) >+ $self->handler(start => "start", "self, line, tagname, attr, text"); #signature is start( self, linenumber, tagname, hash of attributes, original text ) >+ $self->handler(text => "text", "self, line, text, is_cdata"); #signature is text( self, linenumber, original text, is_cdata ) >+ $self->handler(end => "end", "self, line, tag, attr, text"); #signature is end( self, linenumber, tagename, original text ) > $self->handler(declaration => "declaration", "self, line, text, is_cdata"); # declaration > $self->handler(comment => "comment", "self, line, text, is_cdata"); # comments > # $self->handler(default => "default", "self, line, text, is_cdata"); # anything else >@@ -132,7 +132,7 @@ sub start{ > my $line = shift; > my $tag = shift; > my $hash = shift; #hash of attr/value pairs >- my $text = shift; #origional text >+ my $text = shift; #original text > my $t = C4::TmplToken->new( $text, C4::TmplTokenType::TAG, $line, $self->{filename}); > my %attr; > # tags seem to be uses in an 'interesting' way elsewhere.. >diff --git a/C4/Tags.pm b/C4/Tags.pm >index 2b47ca7..619c692 100644 >--- a/C4/Tags.pm >+++ b/C4/Tags.pm >@@ -581,7 +581,7 @@ sub add_tag { # biblionumber,term,[borrowernumber,approvernumber] > # ($min, $max) = stratify_tags($strata, $tags); > # $stratum: the number of divisions you want > # $tags: the tags, as provided by get_approval_rows >-# $min: the minumum stratum value >+# $min: the minimum stratum value > # $max: the maximum stratum value. This may be the same as $min if there > # is only one weight. Beware of divide by zeros. > # This will add a field to the tag called "stratum" containing the calculated >@@ -666,7 +666,7 @@ This could be called an "approved terms" table. See above regarding the Externa > approved - Negative, 0 or positive if tag is rejected, pending or approved. > date_approved - date of last action > approved_by - staffer performing the last action >- weight_total - total occurance of term in any biblio by any users >+ weight_total - total occurrence of term in any biblio by any users > > tags_index - This table is for performance, because by far the most common operation will > be fetching tags for a list of search results. We will have a set of biblios, and we will >diff --git a/C4/UploadedFile.pm b/C4/UploadedFile.pm >index ce90628..0c366a0 100644 >--- a/C4/UploadedFile.pm >+++ b/C4/UploadedFile.pm >@@ -63,7 +63,7 @@ to survive beyond the life of the user's session. > This module allows for tracking the progress of the file > currently being uploaded. > >-TODO: implement secure persistant storage of uploaded files. >+TODO: implement secure persistent storage of uploaded files. > > =cut > >diff --git a/C4/Utils/DataTables/ColumnsSettings.pm b/C4/Utils/DataTables/ColumnsSettings.pm >index ed8d9ac..c84f157 100644 >--- a/C4/Utils/DataTables/ColumnsSettings.pm >+++ b/C4/Utils/DataTables/ColumnsSettings.pm >@@ -11,7 +11,7 @@ sub get_yaml { > C4::Context->config('intranetdir') . '/admin/columns_settings.yml'; > my $yaml = eval { YAML::LoadFile($yml_path) }; > warn >-"ERROR: the yaml file for DT::ColumnsSettings is not correctly formated: $@" >+"ERROR: the yaml file for DT::ColumnsSettings is not correctly formatted: $@" > if $@; > return $yaml; > } >diff --git a/C4/Utils/DataTables/Members.pm b/C4/Utils/DataTables/Members.pm >index 6b365c5..bad8e9f 100644 >--- a/C4/Utils/DataTables/Members.pm >+++ b/C4/Utils/DataTables/Members.pm >@@ -22,7 +22,7 @@ sub search { > > my ($iTotalRecords, $iTotalDisplayRecords); > >- # If branches are independant and user is not superlibrarian >+ # If branches are independent and user is not superlibrarian > # The search has to be only on the user branch > if ( C4::Branch::onlymine ) { > my $userenv = C4::Context->userenv; >diff --git a/C4/XSLT.pm b/C4/XSLT.pm >index ea9c7f5..7a94f2c 100644 >--- a/C4/XSLT.pm >+++ b/C4/XSLT.pm >@@ -100,7 +100,7 @@ sub transformMARCXML4XSLT { > > =head2 getAuthorisedValues4MARCSubfields > >-Returns a ref of hash of ref of hash for tag -> letter controled by authorised values >+Returns a ref of hash of ref of hash for tag -> letter controlled by authorised values > Is only used in this module currently. > > =cut >-- >2.1.0
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=40298">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14383
:
40128
|
40129
|
40147
|
40148
|
40149
|
40150
|
40151
|
40152
|
40276
|
40277
|
40278
|
40279
|
40280
|
40281
|
40282
|
40283
|
40296
|
40297
| 40298 |
40299
|
40300
|
40301
|
40302
|
40303
|
40304