Bugzilla – Attachment 40354 Details for
Bug 14416
Stored XSS flaw affects OPAC and Staff interface
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14416 Stored XSS vulnerability
Bug-14416-Stored-XSS-vulnerability.patch (text/plain), 2.45 KB, created by
Jonathan Druart
on 2015-06-19 09:23:03 UTC
(
hide
)
Description:
Bug 14416 Stored XSS vulnerability
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-06-19 09:23:03 UTC
Size:
2.45 KB
patch
obsolete
>From 3399e2030dab65e761019ef73849cb746bc436ce Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chrisc@catalyst.net.nz> >Date: Fri, 19 Jun 2015 11:26:02 +1200 >Subject: [PATCH] Bug 14416 Stored XSS vulnerability > >opac-addbybiblionumber.pl is also vulnerable because it doesn't escape >list names. > >To test >1/ Create a malicious list name >2/ Try to add a biblio to the lists >3/ Notice js is excuted >4/ Apply patch >5/ Test again > >Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-addbybiblionumber.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-addbybiblionumber.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-addbybiblionumber.tt >index cb9bcb6..81edb61 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-addbybiblionumber.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-addbybiblionumber.tt >@@ -30,12 +30,12 @@ > <label for="shelfnumber">Add to list:</label> <select name="shelfnumber" id="shelfnumber"> > [% IF ( privatevirtualshelves ) %]<optgroup label="Private Lists"> > [% FOREACH privatevirtualshelve IN privatevirtualshelves %] >- <option value="[% privatevirtualshelve.shelfnumber %]">[% privatevirtualshelve.shelfname %]</option> >+ <option value="[% privatevirtualshelve.shelfnumber %]">[% privatevirtualshelve.shelfname | html%]</option> > [% END %] > </optgroup>[% END %] > [% IF ( publicvirtualshelves ) %]<optgroup label="Public Lists"> > [% FOREACH publicvirtualshelve IN publicvirtualshelves %] >- <option value="[% publicvirtualshelve.shelfnumber %]">[% publicvirtualshelve.shelfname %]</option> >+ <option value="[% publicvirtualshelve.shelfnumber %]">[% publicvirtualshelve.shelfname |html%]</option> > [% END %] > </optgroup>[% END %] > </select> >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14416
:
40333
|
40340
|
40341
|
40353
|
40354
|
40355
|
40356
|
40370
|
40371
|
40372
|
40373