Attachment 40367 Details for Bug 14418 – [PASSED QA] Bug 14418 : XSS flaw in opac-shelves.pl

[patch] [PASSED QA] Bug 14418 : XSS flaw in opac-shelves.pl

PASSED-QA-Bug-14418--XSS-flaw-in-opac-shelvespl.patch (text/plain), 2.05 KB, created by Katrin Fischer on 2015-06-19 13:11:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2015-06-19 13:11:59 UTC

Size: 2.05 KB

patch

obsolete

>From 81cd8487b261a4b95d0a967d0f772fa679d109e8 Mon Sep 17 00:00:00 2001
>From: Chris Cormack <chrisc@catalyst.net.nz>
>Date: Fri, 19 Jun 2015 11:30:22 +1200
>Subject: [PATCH] [PASSED QA] Bug 14418 : XSS flaw in opac-shelves.pl
>
>To test:
>1/ Create a list and add at least one item to it
>2/ Hit a url like http://192.168.2.18/cgi-bin/koha/opac-shelves.pl?viewshelf=7&sort=author&direction=%22%3E%3Cscript%3Ealert%28%27oh%20noes%27%29%3C/script%3E
>  Where the shelf id is the number of the list you created, notice the js is executed
>3/ Apply the patch
>4/ Reload the page notice the js is now escaped
>
>Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
>Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>index eb2c143..b586ac1 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>@@ -168,7 +168,7 @@
>                                         <span class="sendlist"><a href="/cgi-bin/koha/opac-sendshelf.pl?shelfid=[% shelfnumber | html %]" class="send" onclick="open('/cgi-bin/koha/opac-sendshelf.pl?shelfid=[% shelfnumber | html %]','win_form','scrollbars=no,resizable=no,height=300,width=450,top=50,left=100'); return false; ">Send list</a></span>
>                                     [% END %]
> 
>-                                    <a class="print-small" target="_blank" href="/cgi-bin/koha/opac-shelves.pl?viewshelf=[% shelfnumber %]&sort=[% sort %]&direction=[% direction %]&print=1">Print list</a>
>+                                    <a class="print-small" target="_blank" href="/cgi-bin/koha/opac-shelves.pl?viewshelf=[% shelfnumber %]&sort=[% sort %]&direction=[% direction |uri %]&print=1">Print list</a>
> 
>                                     [% IF ( manageshelf ) %]
>                                         <span class="sep">|</span>
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 14418: 40335 | 40338 | 40342 | 40343 | 40350 | 40351 | 40352 | 40366 | 40367 | 40368