Attachment 40421 Details for Bug 11325 – [SIGNED-OFF] Bug 11325: Focus not on "Add Item" in Lists

[patch] [SIGNED-OFF] Bug 11325: Focus not on "Add Item" in Lists

SIGNED-OFF-Bug-11325-Focus-not-on-Add-Item-in-List.patch (text/plain), 3.63 KB, created by Bernardo Gonzalez Kriegel on 2015-06-19 17:51:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bernardo Gonzalez Kriegel

Created: 2015-06-19 17:51:11 UTC

Size: 3.63 KB

patch

obsolete

>From 9e5a5065e185387ec0a2d034e32b86d56ee2260b Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Tue, 16 Jun 2015 09:40:41 +0200
>Subject: [PATCH] [SIGNED-OFF] Bug 11325: Focus not on "Add Item" in Lists
>
>When viewing a list, the focus/cursor is no longer on the "add items" field below the list.
>
>This patch moves the "Add Item" form at left part of page so that it is always shown (usefull when there are a lot of items). And adds focus to barcode input so you can enter several items with a barcode scanner.
>
>Test instructions:
>1. Create a list
>2. Make sure you have an object with an assigned barcode
>3. Go to the list
>=> The barcode entry interface should be at left and has the focus
>4. Enter the barcode and press enter (or use a scanner)
>=> The item is added to the list
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>I like the new position.
>Works well, focus on input box
>No errors
>---
> .../prog/en/modules/virtualshelves/shelves.tt      |   50 +++++++++++---------
> 1 file changed, 28 insertions(+), 22 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>index 30bd124..066d7fd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>@@ -302,9 +302,11 @@ function placeHold () {
> 
> [% IF ( viewshelf ) %]&rsaquo; Contents of <i>[% shelfname | html %]</i>[% END %][% IF ( shelves ) %] &rsaquo; Create new list[% END %][% IF ( edit ) %] &rsaquo; Edit list <i>[% shelfname | html %]</i>[% END %]</div>
> 
>-<div id="doc2" class="yui-t7">
>- <div id="bd">
>-  <div id="yui-main">
>+<div id="doc3" class="yui-t2">
>+<div id="bd">
>+<div id="yui-main">
>+<div class="yui-b">
>+
>    <div class="yui-g">[% INCLUDE 'virtualshelves-toolbar.inc' %]
>    </div>
> [% IF ( paramsloop ) %]
>@@ -483,25 +485,6 @@ function placeHold () {
>    </div>
> [% END %]
> 
>-[% IF ( allowaddingitem ) %]
>-<div class="yui-g">
>-<form action="/cgi-bin/koha/virtualshelves/shelves.pl" method="post">
>- <fieldset class="brief noprint">
>-    <legend>Add an item to <i>[% shelfname | html %]</i></legend>
>-        <ol>
>-            <li>
>-                <label for="addbarcode">Barcode:</label>
>-                <input name="addbarcode" type="text" id="addbarcode" size="14" />
>-                <input type="hidden" name="viewshelf" value="[% shelfnumber %]" />
>-                <input type="hidden" name="modifyshelfcontents" value="1" />
>-                <input type="submit" value="Add" />
>-            </li>
>-        </ol>
>- </fieldset>
>-</form>
>-</div>
>-[% END %]
>-
> [% IF ( debug ) %]
>   [% IF ( edit ) %]<div>Edit is on ([% shelfname | html %])</div>[% END %]
>   [% IF ( seflag ) %]<div>seflag is on ([% seflag %])</div>[% END %]
>@@ -652,4 +635,27 @@ function placeHold () {
> 
> </div>
> </div>
>+
>+[% IF ( allowaddingitem ) %]
>+<div class="yui-b">
>+  <form action="/cgi-bin/koha/virtualshelves/shelves.pl" method="post">
>+    <fieldset class="brief">
>+      <legend>Add an item</legend>
>+      <ol>
>+        <li>
>+          <label for="addbarcode">Barcode:</label>
>+          <input name="addbarcode" type="text" id="addbarcode" class="focus" />
>+          <input type="hidden" name="viewshelf" value="[% shelfnumber %]" />
>+          <input type="hidden" name="modifyshelfcontents" value="1" />
>+        </li>
>+      </ol>
>+      <fieldset class="action">
>+        <input type="submit" value="Add" />
>+      </fieldset>
>+    </fieldset>
>+  </form>
>+</div>
>+[% END %]
>+
>+</div>
> [% INCLUDE 'intranet-bottom.inc' %]
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 11325: 23921 | 40231 | 40421 | 40475