Attachment 40434 Details for Bug 12137 – Bug 12137: followup sort <select> index by value

[patch] Bug 12137: followup sort <select> index by value

Bug-12137-followup-sort-select-index-by-value.patch (text/plain), 1.95 KB, created by Mark Tompsett on 2015-06-20 17:12:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2015-06-20 17:12:38 UTC

Size: 1.95 KB

patch

obsolete

>From 1a1a3721772243ed344da153f4341cdb4f8d1874 Mon Sep 17 00:00:00 2001
>From: Indranil Das Gupta <indradg@gmail.com>
>Date: Sat, 20 Jun 2015 18:22:32 +0530
>Subject: [PATCH] Bug 12137: followup sort <select> index by value
>
>adds alphabetical sorting to <select> lists displayed by
>preferences.tt. although added for sorting the days of the
>week, this may have larger ramifications. haven't been
>tested thoroughly, but no apparent breakage seems to be
>happening in preferences.
>
>NOTE: Nice tweak. Makes days of week in sensible order.
>      Properly adds sorting based on documentation that
>      is really hard to find.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
>index 913a80e..4466b58 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
>@@ -118,7 +118,7 @@
>                     <input type="[%IF CHUNK.input_type %][% CHUNK.input_type %][% ELSE %]text[% END %]" name="pref_[% CHUNK.name %]" id="pref_[% CHUNK.name %]" class="preference preference-[% CHUNK.class or "short" %]" value="[% CHUNK.value %]" autocomplete="off" /> [% IF ( CHUNK.dateinput ) %]<span class="hint">[% INCLUDE 'date-format.inc' %]</span>[% END %]
>                     [% ELSIF ( CHUNK.type_select ) %]
>                     <select name="pref_[% CHUNK.name %]" id="pref_[% CHUNK.name %]" class="preference preference-[% CHUNK.class or "choice" %]">
>-                        [% FOREACH CHOICE IN CHUNK.CHOICES %]
>+                        [% FOREACH CHOICE IN CHUNK.CHOICES.sort('value') %]
>                         [% IF ( CHOICE.selected ) %]
>                         <option value="[% CHOICE.value %]" selected="selected">
>                         [% ELSE %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 12137: 27560 | 28619 | 33771 | 37017 | 40332 | 40429 | 40430 | 40434 | 40472 | 40473 | 40474