Attachment 40441 Details for Bug 14423 – Bug 14423 : Multiple XSS bugs in suggestion.pl

[patch] Bug 14423 : Multiple XSS bugs in suggestion.pl

Bug-14423--Multiple-XSS-bugs-in-suggestionpl.patch (text/plain), 5.70 KB, created by Chris Cormack on 2015-06-21 09:41:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2015-06-21 09:41:32 UTC

Size: 5.70 KB

patch

obsolete

>From 517f6382ef364fa624aebc9f6693119d24eb35b0 Mon Sep 17 00:00:00 2001
>From: Chris <chris@bigballofwax.co.nz>
>Date: Sun, 21 Jun 2015 09:35:07 +0000
>Subject: [PATCH] Bug 14423 : Multiple XSS bugs in suggestion.pl
>
>To test
>1/ Hit a url like http://localhost:8081/cgi-bin/koha/suggestion/suggestion.pl?author=%22%3E%3Cscript%3Ealert%28%27oh%20noes%27%29%3C/script%3E&accepteddate_to=
>2/ Notice alert box(es)
>3/ Apply patch
>4/ Reload and notice alert is gone
>
>Repeat for
>collection_title
>copyrightdate
>isbn
>manageddate_from
>manageddate_to
>publishercode
>suggesteddate_from
>suggesteddate_to
>---
> .../prog/en/modules/suggestion/suggestion.tt       |   22 ++++++++++----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>index 4bd3908..b3fedc4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>@@ -329,12 +329,12 @@ h4.local_collapse a { font-size : 80%; text-decoration: none; } fieldset.brief o
>             <input type="text" id="title" name="title" size="80" maxlength="255" value="[% title |html %]" required="required" class="required" />
>             <span class="required">Required</span>
>         </li>
>-        <li><label for="author">Author:</label><input type="text" id="author" name="author" size="50" maxlength="80" value="[% author %]"/></li>
>-        <li><label for="copyrightdate">Copyright date:</label><input type="text" id="copyrightdate" name="copyrightdate" size="4" maxlength="4" value="[% copyrightdate %]" /></li>
>-        <li><label for="isbn">ISBN or ISSN or other standard number:</label><input type="text" id="isbn" name="isbn" size="50" maxlength="80" value="[% isbn %]"/></li>
>-        <li><label for="publishercode">Publisher:</label><input type="text" id="publishercode" name="publishercode" size="50" maxlength="80" value="[% publishercode %]"/></li>
>-        <li><label for="place">Publication place:</label><input type="text" id="place" name="place" size="50" maxlength="80" value="[% place %]"/></li>
>-        <li><label for="collectiontitle">Collection title:</label><input type="text" id="collectiontitle" name="collectiontitle" size="50" maxlength="80" value="[% collectiontitle %]"/></li>
>+        <li><label for="author">Author:</label><input type="text" id="author" name="author" size="50" maxlength="80" value="[% author | html %]"/></li>
>+        <li><label for="copyrightdate">Copyright date:</label><input type="text" id="copyrightdate" name="copyrightdate" size="4" maxlength="4" value="[% copyrightdate | html %]" /></li>
>+        <li><label for="isbn">ISBN or ISSN or other standard number:</label><input type="text" id="isbn" name="isbn" size="50" maxlength="80" value="[% isbn | html %]"/></li>
>+        <li><label for="publishercode">Publisher:</label><input type="text" id="publishercode" name="publishercode" size="50" maxlength="80" value="[% publishercode | html %]"/></li>
>+        <li><label for="place">Publication place:</label><input type="text" id="place" name="place" size="50" maxlength="80" value="[% place | html %]"/></li>
>+        <li><label for="collectiontitle">Collection title:</label><input type="text" id="collectiontitle" name="collectiontitle" size="50" maxlength="80" value="[% collectiontitle | html %]"/></li>
>         <li><label for="itemtype">Document type:</label>
>             <select id="itemtype" name="itemtype" >
>             [% FOREACH itemtypeloo IN itemtypeloop %]
>@@ -672,11 +672,11 @@ h4.local_collapse a { font-size : 80%; text-decoration: none; } fieldset.brief o
> 
> 				<fieldset class="brief"><h4 class="local_collapse"><a href="#">Bibliographic information</a></h4>
>                    <ol> <li><label for="title"> Title:</label><input type="text" id="title" name="title" value="[% title |html %]" /></li>
>-                    <li><label for="author"> Author:</label><input type="text" id="author" name="author" value="[% author %]" /></li>
>-                    <li><label for="isbn"> ISBN:</label><input type="text" id="isbn"  name="isbn" value="[% isbn %]" /></li>
>-                    <li><label for="publishercode"> Publisher:</label><input type="text" id="publishercode" name="publishercode" value="[% publishercode %]" /></li>
>-                    <li><label for="copyrightdate_filter"> Copyright date:</label><input type="text" id="copyrightdate_filter" name="copyrightdate" value="[% copyrightdate %]" /></li>
>-                    <li><label for="collectiontitle"> Collection title:</label><input type="text" id="collectiontitle" name="collectiontitle" value="[% collectiontitle %]" /></li><li><input type="submit" value="Go" /></li></ol>
>+                    <li><label for="author"> Author:</label><input type="text" id="author" name="author" value="[% author | html %]" /></li>
>+                    <li><label for="isbn"> ISBN:</label><input type="text" id="isbn"  name="isbn" value="[% isbn | html %]" /></li>
>+                    <li><label for="publishercode"> Publisher:</label><input type="text" id="publishercode" name="publishercode" value="[% publishercode | html %]" /></li>
>+                    <li><label for="copyrightdate_filter"> Copyright date:</label><input type="text" id="copyrightdate_filter" name="copyrightdate" value="[% copyrightdate | html %]" /></li>
>+                    <li><label for="collectiontitle"> Collection title:</label><input type="text" id="collectiontitle" name="collectiontitle" value="[% collectiontitle | html %]" /></li><li><input type="submit" value="Go" /></li></ol>
>                 </fieldset>
> 				 <fieldset class="brief"><h4 class="local_collapse"><a href="#">Suggestion information</a></h4>
>                     <ol>
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 14423: 40383 | 40435 | 40436 | 40437 | 40438 | 40439 | 40440 | 40441 | 40449 | 40450 | 40451 | 40452 | 40453 | 40454 | 40455 | 40495 | 40496 | 40497 | 40498 | 40499 | 40500 | 40501 | 40503