Attachment 40454 Details for Bug 14423 – Bug 14423 : Multiple XSS vulnerabilities in serials-search

[patch] Bug 14423 : Multiple XSS vulnerabilities in serials-search

Bug-14423--Multiple-XSS-vulnerabilities-in-serials.patch (text/plain), 6.62 KB, created by Jonathan Druart on 2015-06-22 09:47:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2015-06-22 09:47:18 UTC

Size: 6.62 KB

patch

obsolete

>From db0c0fd7e310a340ae95b5210e1fc7c446ce0b95 Mon Sep 17 00:00:00 2001
>From: Chris <chris@bigballofwax.co.nz>
>Date: Sun, 21 Jun 2015 09:20:51 +0000
>Subject: [PATCH] Bug 14423 : Multiple XSS vulnerabilities in serials-search
>
>To test
>
>1/ Hit a url like http://localhost:8081/cgi-bin/koha/serials/serials-search.pl?bookseller_filter=%22%22%22%3E%3Cscript%3Ealert%28%27oh%20noes%27%29%3C/script%3E&searched=1&title_filter=
>2/ Notice alert boxes
>3/ Apply patch
>4/ Reload, notice fixed
>
>Repeat for
>callnumber_filter
>EAN_filter
>ISSN_filter
>publisher_filter
>title_filter
>
>Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
>---
> .../prog/en/modules/serials/serials-search.tt      | 26 +++++++++++-----------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt
>index ae1484d..3b97849 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt
>@@ -60,29 +60,29 @@
>               <ol>
>                 <li>
>                   <label for="issn">ISSN:</label>
>-                  <input type="text" id="issn" name="ISSN_filter" value="[% ISSN_filter %]" />
>+                  <input type="text" id="issn" name="ISSN_filter" value="[% ISSN_filter | html %]" />
>                 </li>
>                 <li>
>                   <label for="title">Title:</label>
>-                  <input type="text" id="title" name="title_filter" value="[% title_filter %]" />
>+                  <input type="text" id="title" name="title_filter" value="[% title_filter | html %]" />
>                 </li>
>                 [% IF ( marcflavour == "UNIMARC" ) %]
>                 <li>
>                   <label for="ean">EAN:</label>
>-                  <input type="text" id="ean" name="EAN_filter" value="[% EAN_filter %]" />
>+                  <input type="text" id="ean" name="EAN_filter" value="[% EAN_filter | html %]" />
>                 </li>
>                 [% END %]
>                 <li>
>                   <label for="callnumber">Call number:</label>
>-                  <input type="text" id="callnumber" name="callnumber_filter" value="[% callnumber_filter %]" />
>+                  <input type="text" id="callnumber" name="callnumber_filter" value="[% callnumber_filter | html %]" />
>                 </li>
>                 <li>
>                   <label for="publisher">Publisher:</label>
>-                  <input type="text" id="publisher" name="publisher_filter" value="[% publisher_filter %]" />
>+                  <input type="text" id="publisher" name="publisher_filter" value="[% publisher_filter | html %]" />
>                 </li>
>                 <li>
>                   <label for="bookseller">Vendor:</label>
>-                  <input type="text" id="bookseller" name="bookseller_filter" value="[% bookseller_filter %]" />
>+                  <input type="text" id="bookseller" name="bookseller_filter" value="[% bookseller_filter | html %]" />
>                 </li>
>                 <li>
>                   <label for="branch">Library:</label>
>@@ -294,7 +294,7 @@
>                                     [% IF ( routing && CAN_user_serials_routing ) %]
>                                         [% UNLESS ( subscription.cannotedit ) %]
>                                             <li>
>-                                                <a href="/cgi-bin/koha/serials/serials-search.pl?subscriptionid=[% subscription.subscriptionid %]&amp;op=reopen&amp;routing=[% subscription.routing %]&amp;searched=1&amp;title_filter=[% title_filter %]&amp;ISSN_filter=[% ISSN_filter %]&amp;EAN_filter=[% EAN_filter %]&amp;published_filter=[% publisher_filter %]&amp;bookseller_filter=[% bookseller_filter %]&amp;branch_filter=[% branch_filter %]" id="reopensub"> <i class="icon-repeat"></i> Reopen</a>
>+                                                <a href="/cgi-bin/koha/serials/serials-search.pl?subscriptionid=[% subscription.subscriptionid %]&amp;op=reopen&amp;routing=[% subscription.routing %]&amp;searched=1&amp;title_filter=[% title_filter | uri %]&amp;ISSN_filter=[% ISSN_filter | uri %]&amp;EAN_filter=[% EAN_filter | uri %]&amp;published_filter=[% publisher_filter | uri %]&amp;bookseller_filter=[% bookseller_filter | uri %]&amp;branch_filter=[% branch_filter | uri %]" id="reopensub"> <i class="icon-repeat"></i> Reopen</a>
>                                             </li>
>                                         [% END %]
>                                     [% END # IF ( routing && CAN_user_serials_routing ) %]
>@@ -337,29 +337,29 @@
>               <ol>
>                 <li>
>                   <label for="issn">ISSN:</label>
>-                  <input type="text" id="issn" name="ISSN_filter" value="[% ISSN_filter %]" />
>+                  <input type="text" id="issn" name="ISSN_filter" value="[% ISSN_filter | html %]" />
>                 </li>
>                 <li>
>                   <label for="title">Title:</label>
>-                  <input type="text" id="title" name="title_filter" value="[% title_filter %]" />
>+                  <input type="text" id="title" name="title_filter" value="[% title_filter | html %]" />
>                 </li>
>                 [% IF ( marcflavour == "UNIMARC" ) %]
>                 <li>
>                   <label for="ean">EAN:</label>
>-                  <input type="text" id="ean" name="EAN_filter" value="[% EAN_filter %]" />
>+                  <input type="text" id="ean" name="EAN_filter" value="[% EAN_filter | html %]" />
>                 </li>
>                 [% END %]
>                 <li>
>                   <label for="callnumber">Call number:</label>
>-                  <input type="text" id="callnumber" name="callnumber_filter" value="[% callnumber_filter %]" />
>+                  <input type="text" id="callnumber" name="callnumber_filter" value="[% callnumber_filter | html %]" />
>                 </li>
>                 <li>
>                   <label for="publisher">Publisher:</label>
>-                  <input type="text" id="publisher" name="publisher_filter" value="[% publisher_filter %]" />
>+                  <input type="text" id="publisher" name="publisher_filter" value="[% publisher_filter | html %]" />
>                 </li>
>                 <li>
>                   <label for="bookseller">Vendor:</label>
>-                  <input type="text" id="bookseller" name="bookseller_filter" value="[% bookseller_filter %]" />
>+                  <input type="text" id="bookseller" name="bookseller_filter" value="[% bookseller_filter | html %]" />
>                 </li>
>                 <li>
>                   <label for="branch">Library:</label>
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 14423: 40383 | 40435 | 40436 | 40437 | 40438 | 40439 | 40440 | 40441 | 40449 | 40450 | 40451 | 40452 | 40453 | 40454 | 40455 | 40495 | 40496 | 40497 | 40498 | 40499 | 40500 | 40501 | 40503