Bugzilla – Attachment 4050 Details for
Bug 6315
depreciation warnings in C4::Serials in new perls
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed Patch
0001-Bug-6315-Fix-depreciated-constructions-in-C4-Serials.patch (text/plain), 1.78 KB, created by
Colin Campbell
on 2011-05-06 12:11:45 UTC
(
hide
)
Description:
Proposed Patch
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2011-05-06 12:11:45 UTC
Size:
1.78 KB
patch
obsolete
>From d63ce63c520703a5db1af070c93c67358f800351 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Fri, 6 May 2011 12:50:39 +0100 >Subject: [PATCH] Bug 6315: Fix depreciated constructions in C4::Serials >Content-Type: text/plain; charset="utf-8" > >Perl 5.14 will issue warnings in cases where it is assumed that >() will magically appear around qw() as the interpreter >will stop fooling itself that they are there >Added the missing () in the couple of cases they were required >--- > C4/Serials.pm | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Serials.pm b/C4/Serials.pm >index 20ae7a3..8aa6ebc 100644 >--- a/C4/Serials.pm >+++ b/C4/Serials.pm >@@ -581,7 +581,7 @@ sub GetSubscriptions { > my @sqlstrings; > my @strings_to_search; > @strings_to_search = map { "%$_%" } split( / /, $string ); >- foreach my $index qw(biblio.title subscription.callnumber subscription.location subscription.notes subscription.internalnotes) { >+ foreach my $index (qw(biblio.title subscription.callnumber subscription.location subscription.notes subscription.internalnotes)) { > push @bind_params, @strings_to_search; > my $tmpstring = "AND $index LIKE ? " x scalar(@strings_to_search); > $debug && warn "$tmpstring"; >@@ -594,7 +594,7 @@ sub GetSubscriptions { > my @sqlstrings; > my @strings_to_search; > @strings_to_search = map { "%$_%" } split( / /, $issn ); >- foreach my $index qw(biblioitems.issn subscription.callnumber) { >+ foreach my $index ( qw(biblioitems.issn subscription.callnumber)) { > push @bind_params, @strings_to_search; > my $tmpstring = "OR $index LIKE ? " x scalar(@strings_to_search); > $debug && warn "$tmpstring"; >-- >1.7.4.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6315
:
4050
|
4096