Attachment 40553 Details for Bug 13799 – Bug 13799: Use Koha::Objects

[patch] Bug 13799: Use Koha::Objects

Bug-13799-Use-KohaObjects.patch (text/plain), 2.26 KB, created by Olli-Antti Kivilahti on 2015-06-24 08:35:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Olli-Antti Kivilahti

Created: 2015-06-24 08:35:24 UTC

Size: 2.26 KB

patch

obsolete

>From 94fb62a0f351de802e3163522ff4655c8a00fa30 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Tue, 17 Mar 2015 10:45:27 +0100
>Subject: [PATCH] Bug 13799: Use Koha::Objects
>
>This add 'unblessed' subroutines to both Koha::Objects and Koha::Object
>to be able to pass it to Mojolicious
>---
> Koha/Object.pm            |   12 ++++++++++++
> Koha/Objects.pm           |   12 ++++++++++++
> Koha/REST/V1/Borrowers.pm |   10 +++++-----
> 3 files changed, 29 insertions(+), 5 deletions(-)
>
>diff --git a/Koha/Object.pm b/Koha/Object.pm
>index a77eb5c..6e53461 100644
>--- a/Koha/Object.pm
>+++ b/Koha/Object.pm
>@@ -207,6 +207,18 @@ sub id {
>     return $id;
> }
> 
>+=head3 $object->unblessed();
>+
>+Returns an unblessed representation of object.
>+
>+=cut
>+
>+sub unblessed {
>+    my ($self) = @_;
>+
>+    return { $self->_result->get_columns };
>+}
>+
> =head3 $object->_result();
> 
> Returns the internal DBIC Row object
>diff --git a/Koha/Objects.pm b/Koha/Objects.pm
>index 8ef6390..1ff91cb 100644
>--- a/Koha/Objects.pm
>+++ b/Koha/Objects.pm
>@@ -181,6 +181,18 @@ sub as_list {
>     return wantarray ? @objects : \@objects;
> }
> 
>+=head3 Koha::Objects->unblessed
>+
>+Returns an unblessed representation of objects.
>+
>+=cut
>+
>+sub unblessed {
>+    my ($self) = @_;
>+
>+    return [ map { $_->unblessed } $self->as_list ];
>+}
>+
> =head3 Koha::Objects->_wrap
> 
> wraps the DBIC object in a corresponding Koha object
>diff --git a/Koha/REST/V1/Borrowers.pm b/Koha/REST/V1/Borrowers.pm
>index 332cdeb..b58ad2a 100644
>--- a/Koha/REST/V1/Borrowers.pm
>+++ b/Koha/REST/V1/Borrowers.pm
>@@ -4,23 +4,23 @@ use Modern::Perl;
> 
> use Mojo::Base 'Mojolicious::Controller';
> 
>-use C4::Members;
>+use Koha::Borrowers;
> 
> sub list_borrowers {
>     my ($c, $args, $cb) = @_;
> 
>-    my $borrowers = C4::Members::Search;
>+    my $borrowers = Koha::Borrowers->search;
> 
>-    $c->$cb($borrowers, 200);
>+    $c->$cb($borrowers->unblessed, 200);
> }
> 
> sub get_borrower {
>     my ($c, $args, $cb) = @_;
> 
>-    my $borrower = C4::Members::GetMemberDetails($args->{borrowernumber});
>+    my $borrower = Koha::Borrowers->find($args->{borrowernumber});
> 
>     if ($borrower) {
>-        return $c->$cb($borrower, 200);
>+        return $c->$cb($borrower->unblessed, 200);
>     }
> 
>     $c->$cb({error => "Borrower not found"}, 404);
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 13799: 36700 | 36705 | 36938 | 36941 | 37119 | 37132 | 37172 | 38246 | 39156 | 39158 | 39159 | 39160 | 39161 | 39162 | 39163 | 39164 | 40088 | 40092 | 40093 | 40094 | 40098 | 40099 | 40101 | 40140 | 40141 | 40142 | 40463 | 40464 | 40465 | 40466 | 40467 | 40468 | 40469 | 40470 | 40471 | 40551 | 40552 | 40553 | 40554 | 40560 | 40561 | 40584 | 40585 | 40586 | 40587 | 40616 | 40617 | 40618 | 40619 | 41160 | 41161 | 41162 | 41268 | 41269 | 41270 | 41271 | 41272 | 41273 | 41274 | 41320 | 41321 | 41326 | 41327 | 41328 | 41329 | 41330 | 41331 | 41538 | 41539 | 41540 | 41541 | 41542 | 41543 | 41547 | 41554 | 42044 | 42085 | 42086 | 42123 | 42518 | 42766 | 42768 | 42801 | 42874 | 42875 | 42876 | 42877 | 42878 | 43186 | 43187 | 43189 | 43190 | 43191 | 43192 | 43204 | 43205 | 43206 | 43207 | 43208 | 43209 | 43210 | 43211 | 43212 | 43213 | 43214 | 43980 | 43981 | 43987 | 43989 | 43990 | 43991 | 43992 | 43993 | 43994 | 43995 | 43996 | 43997 | 43998 | 43999 | 44000 | 44001 | 44185 | 44285 | 44313 | 44375 | 44376 | 44377 | 44378 | 44379 | 44380 | 44381 | 44382 | 44383 | 44384 | 44385