Attachment 40597 Details for Bug 13014 – Bug 13014: (QA followup) have new warnings tested

[patch] Bug 13014: (QA followup) have new warnings tested

Bug-13014-QA-followup-have-new-warnings-tested.patch (text/plain), 2.61 KB, created by Tomás Cohen Arazi (tcohen) on 2015-06-24 17:57:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2015-06-24 17:57:50 UTC

Size: 2.61 KB

patch

obsolete

>From 186b635a75c4e67b20d6fd80d9fee3a8cb3cd2cb Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Wed, 24 Jun 2015 14:54:36 -0300
>Subject: [PATCH] Bug 13014: (QA followup) have new warnings tested
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> t/db_dependent/Suggestions.t | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/Suggestions.t b/t/db_dependent/Suggestions.t
>index df8e93b..29e59bb 100644
>--- a/t/db_dependent/Suggestions.t
>+++ b/t/db_dependent/Suggestions.t
>@@ -365,7 +365,7 @@ $suggestion = GetSuggestion($my_suggestionid_test_budgetid);
> is( $suggestion->{budgetid}, undef, 'NewSuggestion Should set budgetid to NULL if equals an empty string' );
> 
> subtest 'GetUnprocessedSuggestions' => sub {
>-    plan tests => 9;
>+    plan tests => 11;
>     $dbh->do(q|DELETE FROM suggestions|);
>     my $my_suggestionid         = NewSuggestion($my_suggestion);
>     my $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
>@@ -380,11 +380,15 @@ subtest 'GetUnprocessedSuggestions' => sub {
>     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
>     is( scalar(@$unprocessed_suggestions), 1, 'GetUnprocessedSuggestions should return the suggestion if the suggestion is linked to a fund and has not been processed yet' );
> 
>-    ModSuggestion( { suggestionid => $my_suggestionid, STATUS => 'REJECTED' } );
>+    warning_is { ModSuggestion( { suggestionid => $my_suggestionid, STATUS => 'REJECTED' } ) }
>+                'No suggestions REJECTED letter transported by email',
>+                'Warning raised if no REJECTED letter by email';
>     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
>     is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should return the suggestion if the suggestion is linked to a fund and has not been processed yet' );
> 
>-    ModSuggestion( { suggestionid => $my_suggestionid, STATUS => 'ASKED', suggesteddate => dt_from_string->add_duration( DateTime::Duration->new( days => -4 ) ) } );
>+    warning_is { ModSuggestion( { suggestionid => $my_suggestionid, STATUS => 'ASKED', suggesteddate => dt_from_string->add_duration( DateTime::Duration->new( days => -4 ) ) } ); }
>+                'No suggestions ASKED letter transported by email',
>+                'Warning raised if no ASKED letter by email';
>     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
>     is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should use 0 as default value for days' );
>     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions(4);
>-- 
>2.4.4

Actions: View | Diff | Splinter Review

Attachments on bug 13014: 31950 | 31951 | 31952 | 33247 | 33265 | 33266 | 33267 | 33293 | 33294 | 34792 | 34793 | 34794 | 34795 | 34796 | 35603 | 35604 | 35605 | 35606 | 35607 | 36272 | 36273 | 36275 | 36276 | 36277 | 38006 | 38007 | 38009 | 38012 | 38013 | 38014 | 38015 | 38016 | 38017 | 40597