Bugzilla – Attachment 40607 Details for
Bug 14440
get_template_and_user can not have an empty template_name
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 14440: get_template_and_user can not have an empty template_name (updatesupplier.pl)
SIGNED-OFF-Bug-14440-gettemplateanduser-can-not-ha.patch (text/plain), 1.83 KB, created by
Tomás Cohen Arazi (tcohen)
on 2015-06-24 21:27:56 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 14440: get_template_and_user can not have an empty template_name (updatesupplier.pl)
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2015-06-24 21:27:56 UTC
Size:
1.83 KB
patch
obsolete
>From 2c505275ccb4aedcc10acf812496e6adc9b21127 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Tue, 23 Jun 2015 16:45:21 +0200 >Subject: [PATCH] [SIGNED OFF] Bug 14440: get_template_and_user can not have an > empty template_name (updatesupplier.pl) > >Since Bug 14408, the method get_template_and_user can not have an empty template_name. >Pages calling with an empty value should use C4::Auth::checkauth() > >This patch corrects acqui/updatesupplier.pl > >Test plan : >- Apply patch >- Connect to intranet with a user having "vendors_manage" permission >- Go to acquisition module >- Create a new vendor >- Click on "Edit vendor" >- Change some information and save >=> Your change is saved >- Connect to intranet with a user not having "vendors_manage" permission >- Try to access <intranet>/cgi-bin/koha/acqui/updatesupplier.pl >=> Access is denied >- Disconnect from intranet >- Try to access <intranet>/cgi-bin/koha/acqui/updatesupplier.pl >=> Access is denied > >Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > acqui/updatesupplier.pl | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > >diff --git a/acqui/updatesupplier.pl b/acqui/updatesupplier.pl >index 65093d8..c064f76 100755 >--- a/acqui/updatesupplier.pl >+++ b/acqui/updatesupplier.pl >@@ -59,15 +59,8 @@ use C4::Output; > use CGI qw ( -utf8 ); > > my $input=new CGI; >-my ($template, $loggedinuser, $cookie) = get_template_and_user( >- { template_name => "", >- query => $input, >- type => "intranet", >- authnotrequired => 0, >- flagsrequired => { acquisition => 'vendors_manage' }, >- debug => 1, >- } >-); >+ >+checkauth( $input, 0, { acquisition => 'vendors_manage' }, 'intranet' ); > > #print $input->header(); > my $booksellerid=$input->param('booksellerid'); >-- >2.4.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14440
:
40533
|
40544
|
40546
|
40559
|
40595
|
40600
|
40601
|
40602
|
40607
|
40608
|
40609
|
40620
|
40621
|
40622
|
40648